SalesForceContact

Complexity

Total Complexity

11

Size/Duplication

Total Lines	162
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	onAfterWrite()	0	20	7
A	prepareFieldsToSendToSalesForce()	0	11	3
A	getCMSFields()	0	35	1

<?php

use SForce\Wsdl\SaveResult;

class SalesForceContact extends DataObject
{

    private static $fields_to_send_to_sales_force = [
        'FirstName',
        'LastName',
        'Email',
    ];

    /**
     * Singular name for CMS
     * @var string
     */
    private static $singular_name = 'Sales Force Contact';

    /**
     * Plural name for CMS
     * @var string
     */
    private static $plural_name = 'Sales Force Contacts';

    /**
     * SS4 prep!
     * @var string
     */
    private static $table_name = 'SalesForceContact';

    private static $db = [
        'SalesForceIdentifier' => 'Varchar(40)',
        'FirstName' => 'Varchar(255)',
        'LastName' => 'Varchar(255)',
        'Email' => 'Varchar(255)',
        'SentToSalesForce' => 'Boolean',
        'CommsErrors' => 'Text',
    ];


    private static $default_sort = [
        'ID' => 'DESC'
    ];

    /**
     * Defines a default list of filters for the search context
     * @var array
     */
    private static $searchable_fields = [
        'SentToSalesForce' => 'ExactMatchFilter',
        'SalesForceIdentifier' => 'PartialMatchField',
        'FirstName' => 'PartialMatchField',
        'LastName' => 'PartialMatchField',
        'Email' => 'PartialMatchField',
    ];

    /**
     * Defines summary fields commonly used in table columns
     * as a quick overview of the data for this dataobject
     * @var array
     */
    private static $summary_fields = [
        'SentToSalesForce' => 'Sent to SF',
        'SalesForceIdentifier' => 'SF ID',
        'FirstName' => 'First Name',
        'LastName' => 'Last Name',
        'Email' => 'Email',
    ];

    private static $indexes = [
        'Created' => true,
        'LastEdited' => true,
        'SentToSalesForce' => true,
        'SalesForceIdentifier' => true,
        'FirstName' => true,
        'LastName' => true,
        'Email' => true,
    ];


    protected $onAfterWriteDone = false;
    /**
     * Event handler called after writing to the database.
     */
    public function onAfterWrite()
    {
        parent::onAfterWrite();
        if($this->onAfterWriteDone === false) {
            if(! $this->SentToSalesForce) {

The property SentToSalesForce does not exist on SalesForceContact. Since you implemented __get, consider adding a @property annotation.

                $outcomes = MySalesForcePartnerAPI::create_contact(
                    $this->prepareFieldsToSendToSalesForce()
                );
                if(count($outcomes) === 1) {

It seems like $outcomes can also be of type SForce\Wsdl\SaveResult; however, parameter $var of count() does only seem to accept Countable|array, maybe add an additional type check?

                    foreach($outcomes as $outcome) {
                        $this->CommsErrors .= $outcome->getErrors()." ||| ";

The property CommsErrors does not exist on SalesForceContact. Since you implemented __get, consider adding a @property annotation.

                        $this->SentToSalesForce .= $outcome->getSuccess() ? true : false;
                        if(! $this->SalesForceIdentifier) {
                            $this->SalesForceIdentifier = $outcome->getId();

The property SalesForceIdentifier does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                        }
                    }
                    $this->write();
                    $this->onAfterWriteDone = true;
                } else {
                    user_error('unexpected number of outcomes: '.count($outcomes));
                }
            }
        }
    }

    protected function prepareFieldsToSendToSalesForce()
    {
        $return = [];
        $fields = Config::inst()->get('SalesForceContact', 'fields_to_send_to_sales_force');
        foreach($fields as $field) {
            if($this->$field) {
                $return[$field] = $this->$field;
            }
        }

        return $return;
    }

    /**
     * CMS Fields
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->replaceField(
            'SalesForceIdentifier',
            ReadonlyField::create(
                'SalesForceIdentifier',
                'Sales Force Identifier'
            )
        );
        $fields->replaceField(
            'SentToSalesForce',
            ReadonlyField::create(
                'SentToSalesForce',
                'Sent to Sales Force'
            )->setRightTitle('Set to TRUE (1) if sent successfully.')
        );
        $fields->replaceField(
            'CommsErrors',
            ReadonlyField::create(
                'CommsErrors',
                'Communication Errors'
            )->setRightTitle('Separated by three ||| symbols.')
        );
        $fields->addFieldToTab(
            'Root.Advanced',
            LiteralField::create(
                'WhatWeSend',
                '
                    <h2>What is Send</h2>,
                    <pre>'.print_r($this->prepareFieldsToSendToSalesForce(), 1).'</pre>
                '
            )
        );
        return $fields;
    }


}