SalesforceSignupForm::__construct() - Code Metrics - Inspection of "MAJOR: cleanup" - sunnysideup/silverstripe-salesforcepartner - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 14ed89...8aec5a )

by Nicolaas

created 2019-07-11 22:35 UTC

SalesforceSignupForm::__construct() A

↳ Parent: SalesforceSignupForm

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	2
dl	0
loc	14
rs	10
c	0
b	0
f	0

<?php

/**
 * This class can be used by controllers in your project to set up a basic sign up
 * form.
 *
 * You can test it in isolation using the SalesforceExamplesSignupController class.
 */

class SalesforceSignupForm extends Form
{

    private static $allowed_actions = [

        'doSalesforceSignUp' => true
    ];

    private static $based_on_instance_of = 'SalesforceContact';


    /**
     * Our constructor only requires the controller and the name of the form
     * method. We'll create the fields and actions in here.
     *
     */
    public function __construct($controller, $name)
    {
        $fields = $this->getBaseFields();

        $actions = $this->getBaseAction();

        $required = $this->getBaseRequiredFields();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        // now we create the actual form with our fields and actions defined
        // within this class
        parent::__construct($controller, $name, $fields, $actions, $required);

        // any modifications we need to make to the form.
        $this->loadDataFrom($_REQUEST);
    }


    public function setSigupFields(array $fieldArray)
    public function setSigupFields(/** @scrutinizer ignore-unused */ array $fieldArray)
    {
        $newList = new FieldList();
        $oldFields = $this->Fields();
        foreach($fieldsArray as $field) {

            $newField = $oldFields->dataFieldByName($field);
            $newList->push($newField);
        }

        $this->setFields($newList);

        return $this;
    }

    public function setRequiredFields(array $fieldArray)
    {
        $this->setRequiredFields(new RequiredFields($fieldArray));
        $this->setRequiredFields(/** @scrutinizer ignore-type */ new RequiredFields($fieldArray));

        return $this;
    }


    public function setFormSubmitText(string $label)
    {
        $newFields = new FieldList(
            FormAction::create('doSalesforceSignUp', $label)
        );
        $this->setActions($newFields);

        return $this;
    }

    protected function getBaseFields()
    {
        $newInstanceClassName = Config::inst()->get('SalesforceSignupForm', 'based_on_instance_of');
        $newInstance = $newInstanceClassName::create();

        return $newInstance->getFrontEndFields();

    }

    protected function getBaseAction()
    {
        return new FieldList(
            FormAction::create('doSalesforceSignUp', 'Register')
        );
    }

    protected function getBaseRequiredFields()
    {
        new RequiredFields(
            [
                'FirstName',
                'LastName',
                'Email',
            ]
        );
    }


    public function doSalesforceSignUp($data, Form $form)
    public function doSalesforceSignUp($data, /** @scrutinizer ignore-unused */ Form $form)
    {
        MySalesforcePartnerApi::create_contact($data);
                                create_contact($data);
        die('We need the option here to set a redirection link AND/OR provide an AJAX response');

    }


}


sunnysideup / silverstripe-salesforcepartner

Push — master ( 14ed89...8aec5a )

SalesforceSignupForm::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like