SalesforceContactLog::serializedToHTML() - Code Metrics - Inspection of "MAJOR: cleanup" - sunnysideup/silverstripe-salesforcepartner - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 14ed89...8aec5a )

by Nicolaas

created 2019-07-11 22:35 UTC

SalesforceContactLog::serializedToHTML() A

↳ Parent: SalesforceContactLog

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	5
rs	10
c	1
b	0
f	0

<?php

use SForce\Wsdl\SaveResult;

class SalesforceContactLog extends DataObject
{

    /**
     * create contact log
     * @param  string $type
     * @param  array $fieldsSent
     * @param  array $filters
     *
     * @return SalesforceContactLog
     */
    public static function create_contact_log($type, array $fieldsSent, array $filters) : SalesforceContactLog
    public static function create_contact_log($type, array $fieldsSent, /** @scrutinizer ignore-unused */ array $filters) : SalesforceContactLog
    {
        $fieldsSent = serialize($fieldsSent);
        $filters = serialize($fieldsSent);
        $obj = SalesforceContactLog::create(
            [
                'Type' => $type,
                'FieldsSent' => $fieldsSent,
                'Filters' => $filters,
            ]
        );
        $id = $obj->write();

        return SalesforceContactLog::get()->byID($id);

    }

    /**
     * returns true if the contact update was successful
     * @param  SalesforceContactLog $obj
     * @param  mixed $response
     *
     * @return bool
     */
    public function endContactLog(SalesforceContactLog $obj, $response) : bool
    public function endContactLog(/** @scrutinizer ignore-unused */ SalesforceContactLog $obj, $response) : bool
    {
        $id = '';

        $errors = '';

        print_r($response);
        die();
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
        $obj->SalesforceIdentifier = $errors;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        $obj->Errors = $id;
        $obj->write();

        return $obj->SalesforceIdentifier ? true : false;
    }

    /**
     * Singular name for CMS
     * @var string
     */
    private static $singular_name = 'Sales Force Contact Log';


    /**
     * Plural name for CMS
     * @var string
     */
    private static $plural_name = 'Sales Force Contact Log Entries';


    /**
     * SS4 prep!
     * @var string
     */
    private static $table_name = 'SalesforceContactLog';


    private static $db = [

        'SalesforceIdentifier' => 'Varchar(40)',
        'Type' => 'Enum("Created,Updated")',
        'FieldsSent' => 'Text',
        'Filters' => 'Text',
        'Errors' => 'Text',
    ];


    private static $default_sort = [

        'ID' => 'DESC'
    ];

    /**
     * Defines a default list of filters for the search context
     * @var array
     */
    private static $searchable_fields = [

        'SentToSalesforce' => 'ExactMatchFilter',
        'Type' => 'ExactMatchFilter',
        'SalesforceIdentifier' => 'PartialMatchField',
        'FieldsSent' => 'PartialMatchField',
        'Filters' => 'PartialMatchField',
        'Errors' => 'PartialMatchField',
    ];

    /**
     * Defines summary fields commonly used in table columns
     * as a quick overview of the data for this dataobject
     * @var array
     */
    private static $summary_fields = [

        'SentToSalesforce' => 'Sent to SF',
        'SalesforceIdentifier' => 'SF ID',
        'Type' => 'Type',
        'Errors' => 'Errors'
    ];

    private static $indexes = [

        'Created' => true,
        'LastEdited' => true,
        'SentToSalesforce' => true,
        'SalesforceIdentifier' => true,
        'FirstName' => true,
        'LastName' => true,
        'Email' => true,
    ];

    /**
     * CMS Fields
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->addFieldsToTab(
            'Root.Main',
            [
                ReadonlyField::create(
                    'SalesforceIdentifier',
                    'Sales Force Identifier'
                ),
                ReadonlyField::create(
                    'FieldsSent',
                    'Fields Sent',
                    $this->serializedToHTML($this->FieldsSent)

                ),
                ReadonlyField::create(
                    'Type',
                    'Type'
                ),
                ReadonlyField::create(
                    'Filters',
                    'Filters',
                    $this->serializedToHTML($this->Filters)

                ),
                ReadonlyField::create(
                    'Errors',
                    'Communication Errors'
                )->setRightTitle('Separated by three ||| symbols.')
            ]
        );

        return $fields;
    }

    /**
     * DataObject create permissions
     * @param Member $member
     * @return bool
     */
    public function canCreate($member = null)
    {
        return false;
    }

    /**
     * DataObject edit permissions
     * @param Member $member
     * @return bool
     */
    public function canEdit($member = null)
    {
        return false;
    }

    /**
     * DataObject delete permissions
     * @param Member $member
     * @return bool
     */
    public function canDelete($member = null)
    {
        return false;
    }

    /**
     *
     * @param  string $serializedString (serialised data)
     * @return string (html)
     */
    protected function serializedToHTML($serializedString)
    {
        $s = unserialize($serializedString);

        return '<pre>'.print_r($s, 1).'</pre>';
    }

}


sunnysideup / silverstripe-salesforcepartner

Push — master ( 14ed89...8aec5a )

SalesforceContactLog::serializedToHTML() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like