SalesforceContactLog

Complexity

Total Complexity

9

Size/Duplication

Total Lines	187
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	create_contact_log()	0	14	1
A	getCMSFields()	0	32	1
A	serializedToHTML()	0	5	1
A	canDelete()	0	3	1
A	hasError()	0	3	2
A	confirmContactLog()	0	11	1
A	canCreate()	0	3	1
A	canEdit()	0	3	1

<?php

use SForce\Wsdl\SaveResult;

class SalesforceContactLog extends DataObject
{

    /**
     * create contact log
     * @param  string $type
     * @param  array $fieldsSent
     * @param  array $filters
     *
     * @return SalesforceContactLog
     */
    public static function create_contact_log($type, array $fieldsSent, array $filters) : SalesforceContactLog

The parameter $filters is not used and could be removed.

    {
        $fieldsSent = serialize($fieldsSent);
        $filters = serialize($fieldsSent);
        $obj = SalesforceContactLog::create(
            [
                'Type' => $type,
                'FieldsSent' => $fieldsSent,
                'Filters' => $filters,
            ]
        );
        $id = $obj->write();

        return SalesforceContactLog::get()->byID($id);

The expression return SalesforceContactLog::get()->byID($id) returns the type DataObject which includes types incompatible with the type-hinted return SalesforceContactLog.

    }

    /**
     * returns true if the contact update was successful
     * @param  mixed $response
     *
     * @return bool
     */
    public function confirmContactLog($response) : bool
    {
        $id = '';

The assignment to $id is dead and can be removed.

        $errors = '';

The assignment to $errors is dead and can be removed.

        print_r($response);
        die();

Using exit here is not recommended.

In this branch, the function will implicitly return null which is incompatible with the type-hinted return boolean. Consider adding a return statement or allowing null as return value.

        $this->SalesforceIdentifier = $id;

$this->SalesforceIdentifier = $id is not reachable.

        $this->Errors = $errors;
        $this->write();

        return $this->hasError();
    }

    public function hasError() : bool
    {
        return $this->SalesforceIdentifier ? false : true;
    }

    /**
     * Singular name for CMS
     * @var string
     */
    private static $singular_name = 'Sales Force Contact Log';

The private property $singular_name is not used, and could be removed.

    /**
     * Plural name for CMS
     * @var string
     */
    private static $plural_name = 'Sales Force Contact Log Entries';

The private property $plural_name is not used, and could be removed.

    /**
     * SS4 prep!
     * @var string
     */
    private static $table_name = 'SalesforceContactLog';

The private property $table_name is not used, and could be removed.

    private static $db = [

The private property $db is not used, and could be removed.

        'SalesforceIdentifier' => 'Varchar(40)',
        'Type' => 'Enum("Created,Updated")',
        'FieldsSent' => 'Text',
        'Filters' => 'Text',
        'Errors' => 'Text',
    ];


    private static $default_sort = [

The private property $default_sort is not used, and could be removed.

        'ID' => 'DESC'
    ];

    /**
     * Defines a default list of filters for the search context
     * @var array
     */
    private static $searchable_fields = [

The private property $searchable_fields is not used, and could be removed.

        'Type' => 'ExactMatchFilter',
        'SalesforceIdentifier' => 'PartialMatchField',
        'FieldsSent' => 'PartialMatchField',
        'Filters' => 'PartialMatchField',
        'Errors' => 'PartialMatchField',
    ];

    /**
     * Defines summary fields commonly used in table columns
     * as a quick overview of the data for this dataobject
     * @var array
     */
    private static $summary_fields = [

The private property $summary_fields is not used, and could be removed.

        'SalesforceIdentifier' => 'SF ID',
        'Type' => 'Type',
        'Errors' => 'Errors'
    ];

    private static $indexes = [

The private property $indexes is not used, and could be removed.

        'SalesforceIdentifier' => true
    ];

    /**
     * CMS Fields
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->addFieldsToTab(
            'Root.Main',
            [
                ReadonlyField::create(
                    'SalesforceIdentifier',
                    'Sales Force Identifier'
                ),
                ReadonlyField::create(
                    'FieldsSent',
                    'Fields Sent',
                    $this->serializedToHTML($this->FieldsSent)

The property FieldsSent does not exist on SalesforceContactLog. Since you implemented __get, consider adding a @property annotation.

                ),
                ReadonlyField::create(
                    'Type',
                    'Type'
                ),
                ReadonlyField::create(
                    'Filters',
                    'Filters',
                    $this->serializedToHTML($this->Filters)

The property Filters does not exist on SalesforceContactLog. Since you implemented __get, consider adding a @property annotation.

                ),
                ReadonlyField::create(
                    'Errors',
                    'Communication Errors'
                )->setRightTitle('Separated by three ||| symbols.')
            ]
        );

        return $fields;
    }

    /**
     * DataObject create permissions
     * @param Member $member
     * @return bool
     */
    public function canCreate($member = null)
    {
        return false;
    }

    /**
     * DataObject edit permissions
     * @param Member $member
     * @return bool
     */
    public function canEdit($member = null)
    {
        return false;
    }

    /**
     * DataObject delete permissions
     * @param Member $member
     * @return bool
     */
    public function canDelete($member = null)
    {
        return false;
    }

    /**
     *
     * @param  string $serializedString (serialised data)
     * @return string (html)
     */
    protected function serializedToHTML($serializedString)
    {
        $s = unserialize($serializedString);

        return '<pre>'.print_r($s, 1).'</pre>';
    }

}