SalesForceDefaultContactField

Complexity

Total Complexity

24

Size/Duplication

Total Lines	220
Duplicated Lines	0 %

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	get_fields_to_send()	0	7	1
A	getTitle()	0	3	1
A	get_fields_for_filter()	0	7	1
A	select_field()	0	16	2
A	fields_to_filter_field()	0	16	3
A	fields_to_send_field()	0	16	3
A	BetterValue()	0	16	5
A	requireDefaultRecords()	0	12	3
A	mixed_to_array()	0	15	5

<?php

/**
 * this can be linked to pages / other objects using many_many relationships
 * so that you can send default record values to Salesforce
 */
class SalesForceDefaultContactField extends DataObject
{

    /**
     * contact fields that should be created by default...
     * @var array
     */
    private static $defaults_records = [];

The private property $defaults_records is not used, and could be removed.

    private static $site_wide_fields_to_send = [];

The private property $site_wide_fields_to_send is not used, and could be removed.

    private static $site_wide_filter_values = [];

The private property $site_wide_filter_values is not used, and could be removed.

    /**
     * Needs to link to a many-many relationship (SalesforceDefaultContactFields)
     * @param  array $array fields to send
     *
     * @return CheckboxSetField
     */
    public static function select_field(
        $fieldName = 'SalesforceDefaultContactFields',
        $title = 'Default Fields'
    )
    {
        $htmlArray = [];
        foreach($array as $field => $value) {

The variable $array seems to be never defined.

            $htmlArray[] = $field.' = '.$value.' ('.gettype($value).')';
        }

        return CheckboxSetField::create(
            $fieldName,
            $title,
            SalesForceDefaultContactField::get()->map->toArray()

The method toArray() does not exist on null.

        )
            ->setDescription('
                These default fields are always sent to Salesforce, you can
                <a href="/admin/salesforceadmin">Edit or Add to the List</a> as required.
                Please change with care.
            ')
        ;
    }

    /**
     *
     * @param  array|DataList|null $array fields to send
     * @param  string $title fields to send
     *
     * @return LiteralField
     */
    public static function fields_to_send_field(
        $mixed = null,
        $title  = 'Fields Added'
    )
    {
        $array = self::get_fields_to_send($mixed);
        $htmlArray = [];
        foreach($array as $field => $value) {
            $htmlArray[] = $field.' = '.$value.' ('.gettype($value).')';
        }
        if(!count($htmlArray) == 0) {
            $htmlArray[] = 'none';
        }
        return LiteralField::create(
            'FieldsToSendToSalesforce',
            '<h2>'.$title.'</h2><p>- '.implode('</p><p>', $htmlArray).'</p>'
        );
    }
    /**
     *
     * @param  array|DataList|null $array fields to send
     * @param  string $title fields to send
     *
     * @return LiteralField
     */
    public static function fields_to_filter_field(
        $mixed = null,
        $title  = 'Filter Fields'
    )
    {
        $array = self::get_fields_to_send($mixed);
        $htmlArray = [];
        foreach($array as $field => $value) {
            $htmlArray[] = $field.' = '.$value.' ('.gettype($value).')';
        }
        if(!count($htmlArray) == 0) {
            $htmlArray[] = 'none';
        }
        return LiteralField::create(
            'FieldsToFilterForSalesforce',
            '<h2>'.$title.'</h2><p>- '.implode('</p><p>', $htmlArray).'</p>'
        );
    }

    /**
     *
     * @param  array|DataList|null $mixed fields to send
     *
     * @return array
     */
    public static function get_fields_to_send($mixed = null)
    {
        $array = self::mixed_to_array($mixed);

        return array_merge(
            Config::inst()->get('SalesForceDefaultContactField', 'site_wide_fields_to_send'),

It seems like Config::inst()->get('SalesForceDefaultContactField', 'site_wide_fields_to_send') can also be of type boolean and double and integer and string; however, parameter $array1 of array_merge() does only seem to accept array, maybe add an additional type check?

            $array
        );
    }

    /**
     *
     * @param  array|DataList|null $mixed fields to send
     *
     * @return array|DataList|null
     */
    public static function get_fields_for_filter($mixed = null)
    {
        $array = self::mixed_to_array($mixed);

        return array_merge(
            Config::inst()->get('SalesForceDefaultContactField', 'site_wide_filter_values'),

It seems like Config::inst()->get('SalesForceDefaultContactField', 'site_wide_filter_values') can also be of type boolean and double and integer and string; however, parameter $array1 of array_merge() does only seem to accept array, maybe add an additional type check?

            $array
        );
    }

    protected static function mixed_to_array($mixed = null)
    {
        if($mixed === null) {
            $array = [];
        }
        elseif($mixed instanceof DataList) {
            $array = [];
            foreach($mixed as $object) {
                $array[trim($object->Field)] = $object->BetterValue();
            }
        } elseif(! is_array($array)) {

The variable $array seems to be never defined.

            user_error('Variable '.vardump($mixed).'Should be an array');

The function vardump was not found. Maybe you did not declare it correctly or list all dependencies?

        }

        return $array;

The variable $array does not seem to be defined for all execution paths leading up to this point.

    }


    /**
     * Singular name for CMS
     * @var string
     */
    private static $singular_name = 'Default Contact Field';

The private property $singular_name is not used, and could be removed.

    /**
     * Plural name for CMS
     * @var string
     */
    private static $plural_name = 'Default Contact Fields';

The private property $plural_name is not used, and could be removed.

    /**
     *
     * @var array
     */
    private static $db = [

The private property $db is not used, and could be removed.

        'Key' => 'Varchar',
        'Value' => 'Varchar'
    ];

    /**
     * Defines summary fields commonly used in table columns
     * as a quick overview of the data for this dataobject
     * @var array
     */
    private static $summary_fields = [

The private property $summary_fields is not used, and could be removed.

        'Key' => 'Field Name',
        'Value' => 'Field Value'
    ];

    /**
     *
     * @return string
     */
    public function getTitle()
    {
        return $this->Key . ' - '.$this->Value;

The property Key does not exist on SalesForceDefaultContactField. Since you implemented __get, consider adding a @property annotation.

    }


    public function requireDefaultRecords()
    {
        foreach($this->Config()->get('default_records') as $key => $value) {
            $filter = [
                'Key' => $key
            ];

            $obj = SalesForceDefaultContactField::get()->filter($filter)->first();
            if(! $obj) {
                $obj->create($filter);
                $obj->Value = $value;
                $obj->write();
            }

        }
    }

    /**
     * @return mixed
     */
    public function BetterValue()
    {
        if(strtolower($this->Value) === 'true') {
            return true;
        }
        if(strtolower($this->Value) === 'false') {
            return false;
        }
        if(floatval($this->Value)) {
            return floatval($this->Value);
        }
        if(intval($this->Value)) {
            return intval($this->Value);
        }

        return trim($this->Value);
    }



}