SalesforceContactLog::getCMSFields() - Code Metrics - Inspection of "PATCH: debug" - sunnysideup/silverstripe-salesforcepartner - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 0c3b7f...5df6a0 )

by Nicolaas

created 2019-07-12 04:11 UTC

SalesforceContactLog::getCMSFields() A

↳ Parent: SalesforceContactLog

Complexity

Conditions	1
Paths	1

Size

Total Lines	54
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	1
eloc	38
c	2
b	0
f	0
nc	1
nop	0
dl	0
loc	54
rs	9.312

How to fix Long Method

<?php

use SForce\Wsdl\SaveResult;

class SalesforceContactLog extends DataObject
{

    /**
     * create contact log
     * @param  string $type
     * @param  array $fieldsSent
     * @param  array $filters
     *
     * @return SalesforceContactLog
     */
    public static function create_contact_log($type, array $fieldsSent, array $filters) : SalesforceContactLog
    public static function create_contact_log($type, array $fieldsSent, /** @scrutinizer ignore-unused */ array $filters) : SalesforceContactLog
    {
        $fieldsSent = serialize($fieldsSent);
        $filters = serialize($fieldsSent);
        $obj = SalesforceContactLog::create(
            [
                'Type' => $type,
                'FieldsSent' => $fieldsSent,
                'Filters' => $filters,
            ]
        );
        $id = $obj->write();

        return SalesforceContactLog::get()->byID($id);

    }

    /**
     * returns true if the contact update was successful
     * @param  mixed $response
     *
     * @return bool
     */
    public function confirmContactLog($response) : bool
    {
        $id = '';
        $errors = '';
        $hasError = false;
        if(is_array($response)) {
            $response = $response[0];
        }
        if($response instanceof \SForce\Wsdl\SaveResult) {
            $id = $response->getId();
            $errors = serialize($response->getErrors());
            if($response->getSuccess()) {
                $hasError = false;
            } else {
                $hasError = true;
            }
        } else {
            $errors = 'Unexpected response: '.serialize($response);
            // print_r($response);
            user_error('unexptected response');
        }
        $this->SalesforceIdentifier = $id;

        $this->Errors = $errors;

        $this->HasError = $hasError;

        $this->write();

        return $this->HasError;
    }

    /**
     * Singular name for CMS
     * @var string
     */
    private static $singular_name = 'Sales Force Contact Log';


    /**
     * Plural name for CMS
     * @var string
     */
    private static $plural_name = 'Sales Force Contact Log Entries';


    /**
     * SS4 prep!
     * @var string
     */
    private static $table_name = 'SalesforceContactLog';


    private static $db = [

        'SalesforceIdentifier' => 'Varchar(40)',
        'Type' => 'Enum("Created,Updated")',
        'Executed' => 'Boolean',
        'FieldsSent' => 'Text',
        'Filters' => 'Text',
        'HasError' => 'Boolean',
        'Errors' => 'Text',
    ];


    private static $default_sort = [

        'ID' => 'DESC'
    ];

    /**
     * Defines a default list of filters for the search context
     * @var array
     */
    private static $searchable_fields = [

        'Type' => 'ExactMatchFilter',
        'Executed' => 'ExactMatchFilter',
        'HasError' => 'ExactMatchFilter',
        'SalesforceIdentifier' => 'PartialMatchField',
        'FieldsSent' => 'PartialMatchField',
        'Filters' => 'PartialMatchField',
        'Errors' => 'PartialMatchField',
    ];

    /**
     * Defines summary fields commonly used in table columns
     * as a quick overview of the data for this dataobject
     * @var array
     */
    private static $summary_fields = [

        'Created.Nice' => 'Created',
        'SalesforceIdentifier' => 'SF ID',
        'Type' => 'Type',
        'Executed.Nice' => 'Executed',
        'Type' => 'Type',
        'HasError.Nice' => 'Errors',
        'Errors' => 'Errors',
    ];

    private static $indexes = [

        'SalesforceIdentifier' => true
    ];

    /**
     * CMS Fields
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->removeFieldsFromTab(
            'Root.Main',
            [
                'FieldsSent',
                'Filters',
                'HasError',
                'Executed',
            ]
        );
        $fields->addFieldsToTab(
            'Root.Main',
            [
                ReadonlyField::create(
                    'Created',
                    'Created',
                    DBField::create_field('SS_DateTime', $this->Created)->Nice()
                ),
                ReadonlyField::create(
                    'SalesforceIdentifier',
                    'Sales Force Identifier'
                ),
                LiteralField::create(
                    'FieldsSentNice',
                    '<h2>Fields Sent</h2>'.$this->serializedToHTML($this->FieldsSent)

                ),
                ReadonlyField::create(
                    'Type',
                    'Type'
                ),
                LiteralField::create(
                    'FiltersNice',
                    '<h2>Filters</h2>'.$this->serializedToHTML($this->Filters)

                ),
                ReadonlyField::create(
                    'ExecutedNice',
                    'Executed',
                    DBField::create_field('Boolean', $this->Executed)->Nice()

                ),
                ReadonlyField::create(
                    'HasErrorNice',
                    'HasError',
                    DBField::create_field('Boolean', $this->HasError)->Nice()
                ),
                ReadonlyField::create(
                    'Errors',
                    'Communication Errors'
                )->setRightTitle('Separated by three ||| symbols.')
            ]
        );

        return $fields;
    }

    /**
     * DataObject create permissions
     * @param Member $member
     * @return bool
     */
    public function canCreate($member = null)
    {
        return false;
    }

    /**
     * DataObject edit permissions
     * @param Member $member
     * @return bool
     */
    public function canEdit($member = null)
    {
        return false;
    }

    /**
     * DataObject delete permissions
     * @param Member $member
     * @return bool
     */
    public function canDelete($member = null)
    {
        return false;
    }

    /**
     *
     * @param  string $serializedString (serialised data)
     * @return string (html)
     */
    protected function serializedToHTML($serializedString)
    {
        $s = unserialize($serializedString);

        return '<pre>'.print_r($s, 1).'</pre>';
    }

}


sunnysideup / silverstripe-salesforcepartner

Push — master ( 0c3b7f...5df6a0 )

SalesforceContactLog::getCMSFields() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like