SalesforceDefaultContactField::BetterValue() - Code Metrics - Inspection of "REFACTOR" - sunnysideup/silverstripe-salesforcepartner - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d0bd04...1327da )

by Nicolaas

created 2019-07-12 03:19 UTC

SalesforceDefaultContactField::BetterValue() A

↳ Parent: SalesforceDefaultContactField

Complexity

Conditions	5
Paths	5

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	9
c	1
b	0
f	0
nc	5
nop	0
dl	0
loc	16
rs	9.6111

<?php

/**
 * this can be linked to pages / other objects using many_many relationships
 * so that you can send default record values to Salesforce
 */
class SalesforceDefaultContactField extends DataObject
{

    /**
     * contact fields that should be created by default...
     * @var array
     */
    private static $defaults_records = [];


    /**
     * Singular name for CMS
     * @var string
     */
    private static $singular_name = 'Default Contact Field';


    /**
     * Plural name for CMS
     * @var string
     */
    private static $plural_name = 'Default Contact Fields';


    /**
     *
     * @var array
     */
    private static $db = [

        'Key' => 'Varchar',
        'Value' => 'Varchar',
        'IsFilter' => 'Boolean',
    ];

    /**
     * Defines summary fields commonly used in table columns
     * as a quick overview of the data for this dataobject
     * @var array
     */
    private static $summary_fields = [

        'Key' => 'Field Name',
        'Value' => 'Field Value',
        'IsFilter.Nice' => 'Is Filter',
    ];

    /**
     *
     * @return string
     */
    public function getTitle()
    {
        return $this->Key . ' = '.$this->Value;

    }


    public function requireDefaultRecords()
    {
        foreach($this->Config()->get('default_records') as $key => $value) {
            $filter = [
                'Key' => $key
            ];

            $obj = SalesforceDefaultContactField::get()->filter($filter)->first();
            if(! $obj) {
                $obj = SalesforceDefaultContactField::create($filter);
                $obj->Value = $value;
                $obj->write();
            }

        }
    }

    /**
     * @return mixed
     */
    public function BetterValue()
    {
        if(strtolower($this->Value) === 'true') {
            return true;
        }
        if(strtolower($this->Value) === 'false') {
            return false;
        }
        if(floatval($this->Value)) {
            return floatval($this->Value);
        }
        if(intval($this->Value)) {
            return intval($this->Value);
        }

        return trim($this->Value);
    }




}


1			<?php
2
3			/**
4			* this can be linked to pages / other objects using many_many relationships
5			* so that you can send default record values to Salesforce
6			*/
7			class SalesforceDefaultContactField extends DataObject
8			{
9
10			/**
11			* contact fields that should be created by default...
12			* @var array
13			*/
14			private static $defaults_records = [];
			1 ignored issue – show introduced 2019-07-10 23:02 UTC by Report Bug Copy Issue Report The private property `$defaults_records` is not used, and could be removed. Loading history...
15
16			/**
17			* Singular name for CMS
18			* @var string
19			*/
20			private static $singular_name = 'Default Contact Field';
			1 ignored issue – show introduced 2019-07-10 23:11 UTC by Report Bug Copy Issue Report The private property `$singular_name` is not used, and could be removed. Loading history...
21
22			/**
23			* Plural name for CMS
24			* @var string
25			*/
26			private static $plural_name = 'Default Contact Fields';
			1 ignored issue – show introduced 2019-07-10 23:11 UTC by Report Bug Copy Issue Report The private property `$plural_name` is not used, and could be removed. Loading history...
27
28			/**
29			*
30			* @var array
31			*/
32			private static $db = [
			1 ignored issue – show introduced 2019-07-10 23:02 UTC by Report Bug Copy Issue Report The private property `$db` is not used, and could be removed. Loading history...
33			'Key' => 'Varchar',
34			'Value' => 'Varchar',
35			'IsFilter' => 'Boolean',
36			];
37
38			/**
39			* Defines summary fields commonly used in table columns
40			* as a quick overview of the data for this dataobject
41			* @var array
42			*/
43			private static $summary_fields = [
			1 ignored issue – show introduced 2019-07-10 23:02 UTC by Report Bug Copy Issue Report The private property `$summary_fields` is not used, and could be removed. Loading history...
44			'Key' => 'Field Name',
45			'Value' => 'Field Value',
46			'IsFilter.Nice' => 'Is Filter',
47			];
48
49			/**
50			*
51			* @return string
52			*/
53			public function getTitle()
54			{
55			return $this->Key . ' = '.$this->Value;
			1 ignored issue – show Bug Best Practice introduced 2019-07-11 22:37 UTC by Report Bug Copy Issue Report The property `Key` does not exist on `SalesforceDefaultContactField`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
56			}
57
58
59			public function requireDefaultRecords()
60			{
61			foreach($this->Config()->get('default_records') as $key => $value) {
62			$filter = [
63			'Key' => $key
64			];
65
66			$obj = SalesforceDefaultContactField::get()->filter($filter)->first();
67			if(! $obj) {
68			$obj = SalesforceDefaultContactField::create($filter);
69			$obj->Value = $value;
70			$obj->write();
71			}
72
73			}
74			}
75
76			/**
77			* @return mixed
78			*/
79			public function BetterValue()
80			{
81			if(strtolower($this->Value) === 'true') {
82			return true;
83			}
84			if(strtolower($this->Value) === 'false') {
85			return false;
86			}
87			if(floatval($this->Value)) {
88			return floatval($this->Value);
89			}
90			if(intval($this->Value)) {
91			return intval($this->Value);
92			}
93
94			return trim($this->Value);
95			}
96
97
98
99
100			}
101

sunnysideup / silverstripe-salesforcepartner

Push — master ( d0bd04...1327da )

SalesforceDefaultContactField::BetterValue() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like