sunnysideup / silverstripe-presentation

code/PresentationPage.php

<?php

class PresentationPage extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $splash_image_location = '/assets/splasimages';

The property $splash_image_location is not used and could be removed.

    private static $db = array(

The property $db is not used and could be removed.

        'Website' => "Varchar(100)",
        'StartSlogan' => "Varchar(100)"
    );
    private static $has_one = array(

The property $has_one is not used and could be removed.

        'BackgroundImage' => "Image"
    );

    private static $icon = "mysite/images/treeicons/Presentation";

The property $icon is not used and could be removed.

    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $fields = parent::getCMSFields();
        $fields->addFieldToTab("Root.Splash", TextField::create('Website'));
        $fields->addFieldToTab("Root.Splash", TextField::create('StartSlogan'));
        $fields->addFieldToTab("Root.Splash", UploadField::create('BackgroundImage','Background Image'));
        $fields->addFieldToTab("Root.Splash", HtmlEditorField::create('Content'));
        return $fields;
    }

}

class PresentationPage_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{


    function init()

It is generally recommended to explicitly declare the visibility for methods.

    {
        ContentController::init();
    }


    public function index()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->renderWith('PresentationPage_Splash');
    }


    /**
     * Private variables to locally cache the selected image index and
     * shuffled array with the images URLs
     */
    private $_selectedImage = null;

    private $_shuffledImages = array();


    /**
     * Returns the URL of the first image to be shown on the Splash
     * @return String
     */
    public function getRandomSplashImage()
    {

        if ($this->_selectedImage === null) {
            if($this->BackgroundImageID) {
                if($image = $this->BackgroundImage()) {
                    $this->_selectedImage = $image->Link();
                }
            }
            if ($this->_selectedImage === null) {
                $this->_shuffledImages = Config::inst()->get('PresentationPage', 'splash_images');
                shuffle($this->_shuffledImages);
                $randomIndex = array_rand($this->_shuffledImages);
                $this->_selectedImage = Config::inst()->get('PresentationPage', 'splash_image_location').
                    '/'.
                    $this->_shuffledImages[$randomIndex];
            }
        }
        return $this->_selectedImage;
    }

    /**
     * Returns the index of the first image to be shown on the Presentation Page Splash.
     * @return Integer

Should the return type not be string?

     */
    public function getRandomSplashImageIndex()
    {
        return $this->_selectedImage;
    }

    /**
     * Generates a Javascript Array command from the list of Shuffled images.
     * @return String
     */
    public function getJavaImageArray()
    {
        $imageArray  = $this->_shuffledImages; //Config::inst()->get('Presentation Page', 'splash_images');

72% of this comment could be valid code. Did you maybe forget this after debugging?

        return "new Array('/images/".implode("', '/images/", $imageArray)."'),";
    }

    /**
     * Returns an html message with tags other tahn <a><span> removed.
     * @return String
     */
    public function getSplashMessageClean()
    {
        $strippedHMTL = str_replace('>', '>', $this->Content);
        $strippedHMTL = strip_tags($strippedHMTL, '<a><span>');
        $strippedHMTL = str_replace('&nbsp;', ' ', $strippedHMTL);
        $obj = DBField::create_field('Varchar', $strippedHMTL);
        $value = $obj->raw();
        $value = str_replace("'", '&rsquo;', $value);
        $value = str_replace("\r", ' ', $value);
        $value = str_replace("\n", ' ', $value);
        $value = str_replace("\t", ' ', $value);
        $value = preg_replace("/\s{1,}/", " ", $value);;

It is generally recommended to place each PHP statement on a line by itself.

        if(strlen($value) < 10) {
            return 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam.';
        }

        return $value;
    }

    function PreviousPage()

The return type could not be reliably inferred; please add a @return annotation.

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        return PresentationPage::get()
            ->sort(array('Sort' => 'DESC'))
            ->where('Sort < '.$this->Sort.' AND ShowInSearch = 1')
            ->First();
    }

    function NextPage()

The return type could not be reliably inferred; please add a @return annotation.

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        return PresentationPage::get()
            ->where('Sort >= '.$this->Sort.'  AND ShowInSearch = 1')
            ->sort(array('Sort' => 'ASC'))
            ->exclude(array('ID' => $this->ID))
            ->First();
    }

}