PhoneField

Complexity

Total Complexity

8

Size/Duplication

Total Lines	92
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	3

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	IntlFormat()	0	17	2
A	TellLink()	0	4	1
A	CallToLink()	0	4	1
A	scaffoldFormField()	0	8	2
A	literalLeftTrim()	0	7	2

<?php
/**
 * you can now use the following in your silverstripe templates
 * $MyPhoneField.TellLink
 * which then removes the first 0
 * adds country code at the end
 * and adds + and country code
 *
 * e.g
 * 09 5556789
 * becomes
 * tel:+649555789
 *
 * if you would like a different country code then use:
 * $MyPhoneField.TellLink(55)
 */

class PhoneField extends Varchar

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $default_country_code = "64";

The property $default_country_code is not used and could be removed.

    private static $casting = array(

Consider using a different property name as you override a private property of the parent class.

The property $casting is not used and could be removed.

        "TellLink" => "Varchar",
        "CallToLink" => "Varchar"
    );


    /**
     * This method is accessed by other pages!
     *
     * @param int $countryCode (e.g. 64)

Should the type for parameter $countryCode not be string|integer?

     *
     * @return string
     */
    public function IntlFormat($countryCode = "")
    {
        //remove non digits
        if (!$countryCode) {
            $countryCode = $this->Config()->default_country_code;
        }
        //remove non-digits
        $phoneNumber = preg_replace('/\D/', '', $this->value);
        //remove country code with plus - NOT NECESSARY
        //$phoneNumber = $this->literalLeftTrim($phoneNumber, '+'.$countryCode);

63% of this comment could be valid code. Did you maybe forget this after debugging?

        //remove country code
        $phoneNumber = $this->literalLeftTrim($phoneNumber, $countryCode);

It seems like $phoneNumber can also be of type array<integer,string>; however, PhoneField::literalLeftTrim() does only seem to accept string, maybe add an additional type check?

        //remove leading zero
        $phoneNumber = $this->literalLeftTrim($phoneNumber, '0');

        return '+'.$countryCode.$phoneNumber;
    }

    /**
     * This method is accessed by other pages!
     *
     * @param int $countryCode (e.g. 64)

Should the type for parameter $countryCode not be string|integer?

     *
     * @return string
     */
    public function TellLink($countryCode = "")
    {
        return 'tel:'.$this->IntlFormat($countryCode);
    }



    /**
     *
     * @param countryCode $countryCode (e.g. 64)

Should the type for parameter $countryCode not be string|countryCode?

     *
     * @return string
     */
    public function CallToLink($countryCode = "")
    {
        return 'callto:'.$this->IntlFormat($countryCode);
    }

    /**
     * @see DBField::scaffoldFormField()
     *
     * @param string $title (optional)

Should the type for parameter $title not be string|null?

     * @param array $params (optional)

Should the type for parameter $params not be array|null?

     *
     * @return PhoneNumberField | NullableField

Should the return type not be NullableField|TextField?

     */
    public function scaffoldFormField($title = null, $params = null)
    {
        if (!$this->nullifyEmpty) {
            return NullableField::create(TextField::create($this->name, $title));
        } else {
            return TextField::create($this->name, $title);
        }
    }

    /**
     * removes a string at the start of a string, if present...
     * @param string $str - the haystack
     * @param string $prefix - the needle
     *
     * @return string
     */
    protected function literalLeftTrim($str, $prefix)
    {
        if (substr($str, 0, strlen($prefix)) == $prefix) {
            $str = substr($str, strlen($prefix));
        }
        return $str;
    }
}