PhoneField

Complexity

Total Complexity

5

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	3

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	TellLink()	0	24	2
A	CallToLink()	0	4	1
A	scaffoldFormField()	0	8	2

<?php
/**
 * you can now use the following in your silverstripe templates
 * $MyPhoneField.TellLink
 * which then removes the first 0
 * adds country code at the end
 * and adds + and country code
 *
 * e.g
 * 09 5556789
 * becomes
 * tel:+649555789
 *
 * if you would like a different country code then use:
 * $MyPhoneField.TellLink(55)
 */

class PhoneField extends Varchar

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $default_country_code = "64";

The property $default_country_code is not used and could be removed.

    private static $casting = array(

Consider using a different property name as you override a private property of the parent class.

The property $casting is not used and could be removed.

        "TellLink" => "Varchar",
        "CallToLink" => "Varchar"
    );

    /**
     * This method is accessed by other pages!
     *
     * @param int $countryCode (e.g. 64)

Should the type for parameter $countryCode not be string|integer?

     *
     * @return string
     */
    public function TellLink($countryCode = "")
    {
        //remove non digits
        if (!$countryCode) {
            $countryCode = $this->Config()->default_country_code;
        }
        $phoneNumber = preg_replace('/\D/', '', $this->value);

        //hack the 1300 scenario
        //if (substr($phoneNumber, 0, 4) == '1300') {

60% of this comment could be valid code. Did you maybe forget this after debugging?

        //    $phoneNumber = preg_replace('/^1300/', '+611300', $phoneNumber);

57% of this comment could be valid code. Did you maybe forget this after debugging?

        //} else {
            //remove leading zero
            $phoneNumber = preg_replace('/^0/', '+'.$countryCode, $phoneNumber);
        //}
        //remove double-ups
        $phoneNumber = str_replace(
            '+'.$countryCode.''.$countryCode,
            '+'.$countryCode,
            $phoneNumber
        );
        $phoneNumber = "tel:+".$phoneNumber;
        return $phoneNumber;
    }



    /**
     *
     * @param countryCode $countryCode (e.g. 64)

Should the type for parameter $countryCode not be string|countryCode?

     *
     * @return string
     */
    public function CallToLink($countryCode = "")
    {
        return str_replace('tel:', 'callto:', $this->TellLink($countryCode));
    }
    
    /**
     * @see DBField::scaffoldFormField()
     *
     * @param string $title (optional)

Should the type for parameter $title not be string|null?

     * @param array $params (optional)

Should the type for parameter $params not be array|null?

     *
     * @return PhoneNumberField | NullableField
     */
    public function scaffoldFormField($title = null, $params = null)
    {
        if (!$this->nullifyEmpty) {
            return NullableField::create(PhoneNumberField::create($this->name, $title));
        } else {
            return PhoneNumberField::create($this->name, $title);
        }
    }
    
}