Conditions | 38 |
Paths | > 20000 |
Total Lines | 191 |
Code Lines | 148 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
136 | public function CreateGroup( |
||
137 | $code = '', |
||
138 | $name, |
||
139 | $parentGroup = null, |
||
140 | $permissionCode = '', |
||
141 | $roleTitle = '', |
||
142 | array $permissionArray = [], |
||
143 | $member = null |
||
144 | ) |
||
145 | { |
||
146 | if(! $name) {$name = $this->name;} |
||
147 | if(! $code) {$code = $this->code;} |
||
148 | if(! $parentGroup) { $parentGroup = $this->parentGroup;} |
||
149 | if(! $permissionCode) { $permissionCode = $this->permissionCode;} |
||
150 | if(! $permissionArray || count($permissionArray) === 0) { $permissionArray = $this->permissionArray;} |
||
151 | if(! $member) { $member = $this->member;} |
||
152 | if(!$name) { |
||
153 | $name = 'New Group '.rand(0,999999); |
||
154 | } |
||
155 | if(!$code) { |
||
156 | $code = $name; |
||
157 | } |
||
158 | $code = str_replace(' ', '_', $code); |
||
159 | $code = preg_replace("/[\W_]+/u", '', $code); |
||
160 | //changing to lower case seems to be very important |
||
161 | //unidentified bug so far |
||
162 | $code = strtolower($code); |
||
163 | |||
164 | $filterArrayForGroup = array('Code' => $code); |
||
165 | $groupDataList = Group::get()->filter($filterArrayForGroup); |
||
166 | $groupCount = $groupDataList->count(); |
||
167 | $groupStyle = 'updated'; |
||
168 | if ($groupCount > 1) { |
||
169 | user_error("There is more than one group with the $name ($code) Code"); |
||
170 | } |
||
171 | if ($groupCount == 0) { |
||
172 | $group = Group::create($filterArrayForGroup); |
||
173 | $groupStyle = 'created'; |
||
174 | } else { |
||
175 | $group = $groupDataList->First(); |
||
176 | } |
||
177 | $group->Locked = 1; |
||
178 | $group->Title = $name; |
||
179 | $parentGroupStyle = 'updated'; |
||
180 | if ($parentGroup) { |
||
181 | DB::alteration_message('adding parent group'); |
||
182 | if (is_string($parentGroup)) { |
||
183 | $parentGroupName = $parentGroup; |
||
184 | $parentGroup = DataObject::get_one( |
||
185 | 'Group', |
||
186 | array('Title' => $parentGroupName), |
||
187 | $cacheDataObjectGetOne = false |
||
188 | ); |
||
189 | if (!$parentGroup) { |
||
190 | $parentGroup = Group::create(); |
||
191 | $parentGroupStyle = 'created'; |
||
192 | $parentGroup->Title = $parentGroupName; |
||
193 | $parentGroup->write(); |
||
194 | DB::alteration_message("$parentGroupStyle $parentGroupName", $parentGroupStyle); |
||
195 | } |
||
196 | } |
||
197 | if ($parentGroup) { |
||
198 | $group->ParentID = $parentGroup->ID; |
||
199 | } |
||
200 | } |
||
201 | $group->write(); |
||
202 | DB::alteration_message("$groupStyle $name ($code) group", $groupStyle); |
||
203 | $doubleGroups = Group::get() |
||
204 | ->filter(array('Code' => $code)) |
||
205 | ->exclude(array('ID' => $group->ID)); |
||
206 | if ($doubleGroups->count()) { |
||
207 | DB::alteration_message($doubleGroups->count().' groups with the same name', 'deleted'); |
||
208 | $realMembers = $group->Members(); |
||
209 | foreach ($doubleGroups as $doubleGroup) { |
||
210 | $fakeMembers = $doubleGroup->Members(); |
||
211 | foreach ($fakeMembers as $fakeMember) { |
||
212 | DB::alteration_message('adding customers: '.$fakeMember->Email, 'created'); |
||
213 | $realMembers->add($fakeMember); |
||
214 | } |
||
215 | DB::alteration_message('deleting double group ', 'deleted'); |
||
216 | $doubleGroup->delete(); |
||
217 | } |
||
218 | } |
||
219 | if ($permissionCode) { |
||
220 | $permissionCodeCount = DB::query("SELECT * FROM \"Permission\" WHERE \"GroupID\" = '".$group->ID."' AND \"Code\" LIKE '".$permissionCode."'")->numRecords(); |
||
221 | if ($permissionCodeCount == 0) { |
||
222 | DB::alteration_message('granting '.$name." permission code $permissionCode ", 'created'); |
||
223 | Permission::grant($group->ID, $permissionCode); |
||
224 | } else { |
||
225 | DB::alteration_message($name." permission code $permissionCode already granted"); |
||
226 | } |
||
227 | } |
||
228 | //we unset it here to avoid confusion with the |
||
229 | //other codes we use later on |
||
230 | $permissionArray[] = $permissionCode; |
||
231 | unset($permissionCode); |
||
232 | if ($roleTitle) { |
||
233 | $permissionRoleCount = PermissionRole::get() |
||
234 | ->Filter(array('Title' => $roleTitle)) |
||
235 | ->Count(); |
||
236 | if ($permissionRoleCount > 1) { |
||
237 | db::alteration_message("There is more than one Permission Role with title $roleTitle ($permissionRoleCount)", 'deleted'); |
||
238 | $permissionRolesFirst = DataObject::get_one( |
||
239 | 'PermissionRole', |
||
240 | array('Title' => $roleTitle), |
||
241 | $cacheDataObjectGetOne = false |
||
242 | ); |
||
243 | $permissionRolesToDelete = PermissionRole::get() |
||
244 | ->Filter(array('Title' => $roleTitle)) |
||
245 | ->Exclude(array('ID' => $permissionRolesFirst->ID)); |
||
246 | foreach ($permissionRolesToDelete as $permissionRoleToDelete) { |
||
247 | db::alteration_message("DELETING double permission role $roleTitle", 'deleted'); |
||
248 | $permissionRoleToDelete->delete(); |
||
249 | } |
||
250 | } |
||
251 | elseif ($permissionRoleCount == 1) { |
||
252 | //do nothing |
||
253 | DB::alteration_message("$roleTitle role in place"); |
||
254 | } else { |
||
255 | DB::alteration_message("adding $roleTitle role", 'created'); |
||
256 | $permissionRole = PermissionRole::create(); |
||
257 | $permissionRole->Title = $roleTitle; |
||
258 | $permissionRole->OnlyAdminCanApply = true; |
||
259 | $permissionRole->write(); |
||
260 | } |
||
261 | $permissionRole = DataObject::get_one( |
||
262 | 'PermissionRole', |
||
263 | array('Title' => $roleTitle), |
||
264 | $cacheDataObjectGetOne = false |
||
265 | ); |
||
266 | if ($permissionRole) { |
||
267 | if (is_array($permissionArray) && count($permissionArray)) { |
||
268 | DB::alteration_message('working with '.implode(', ', $permissionArray)); |
||
269 | foreach ($permissionArray as $permissionRoleCode) { |
||
270 | $permissionRoleCodeObject = DataObject::get_one( |
||
271 | 'PermissionRoleCode', |
||
272 | array('Code' => $permissionRoleCode, 'RoleID' => $permissionRole->ID), |
||
273 | $cacheDataObjectGetOne = false |
||
274 | ); |
||
275 | $permissionRoleCodeObjectCount = PermissionRoleCode::get() |
||
276 | ->Filter(array('Code' => $permissionRoleCode, 'RoleID' => $permissionRole->ID)) |
||
277 | ->Count(); |
||
278 | if ($permissionRoleCodeObjectCount > 1) { |
||
279 | $permissionRoleCodeObjectsToDelete = PermissionRoleCode::get() |
||
280 | ->Filter(array('Code' => $permissionRoleCode, 'RoleID' => $permissionRole->ID)) |
||
281 | ->Exclude(array('ID' => $permissionRoleCodeObject->ID)); |
||
282 | foreach ($permissionRoleCodeObjectsToDelete as $permissionRoleCodeObjectToDelete) { |
||
283 | db::alteration_message("DELETING double permission code $permissionRoleCode for ".$permissionRole->Title, 'deleted'); |
||
284 | $permissionRoleCodeObjectToDelete->delete(); |
||
285 | } |
||
286 | db::alteration_message('There is more than one Permission Role Code in '.$permissionRole->Title." with Code = $permissionRoleCode ($permissionRoleCodeObjectCount)", 'deleted'); |
||
287 | } |
||
288 | elseif ($permissionRoleCodeObjectCount == 1) { |
||
289 | //do nothing |
||
290 | } else { |
||
291 | $permissionRoleCodeObject = PermissionRoleCode::create(); |
||
292 | $permissionRoleCodeObject->Code = $permissionRoleCode; |
||
293 | $permissionRoleCodeObject->RoleID = $permissionRole->ID; |
||
294 | } |
||
295 | DB::alteration_message('adding '.$permissionRoleCodeObject->Code.' to '.$permissionRole->Title); |
||
296 | $permissionRoleCodeObject->write(); |
||
297 | } |
||
298 | } |
||
299 | if ($group && $permissionRole) { |
||
300 | if (DB::query('SELECT COUNT(*) FROM Group_Roles WHERE GroupID = '.$group->ID.' AND PermissionRoleID = '.$permissionRole->ID)->value() == 0) { |
||
301 | db::alteration_message('ADDING '.$permissionRole->Title.' permission role to '.$group->Title.' group', 'created'); |
||
302 | $existingGroups = $permissionRole->Groups(); |
||
303 | $existingGroups->add($group); |
||
304 | } else { |
||
305 | db::alteration_message('CHECKED '.$permissionRole->Title.' permission role to '.$group->Title.' group'); |
||
306 | } |
||
307 | } else { |
||
308 | db::alteration_message('ERROR: missing group or permissionRole', 'deleted'); |
||
309 | } |
||
310 | } |
||
311 | } |
||
312 | if ($member) { |
||
313 | if (is_string($member)) { |
||
314 | $email = $member; |
||
315 | $member = $this->CreateDefaultMember($email, $code, $name); |
||
316 | } |
||
317 | if ($member) { |
||
318 | DB::alteration_message(' adding member '.$member->Email.' to group '.$group->Title, 'created'); |
||
319 | $member->Groups()->add($group); |
||
320 | } |
||
321 | } else { |
||
322 | DB::alteration_message('No user provided.'); |
||
323 | } |
||
324 | |||
325 | return $group; |
||
326 | } |
||
327 | } |
||
328 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.