sunnysideup /
silverstripe-permission_provider
| Conditions | 38 |
| Paths | > 20000 |
| Total Lines | 200 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 197 | public function CreateGroup( |
||
| 198 | $code = '', |
||
| 199 | $name, |
||
| 200 | $parentGroup = null, |
||
| 201 | $permissionCode = '', |
||
| 202 | $roleTitle = '', |
||
| 203 | array $permissionArray = [], |
||
| 204 | $member = null |
||
| 205 | ) { |
||
| 206 | if (! $name) { |
||
| 207 | $name = $this->name; |
||
| 208 | } |
||
| 209 | if (! $code) { |
||
| 210 | $code = $this->code; |
||
| 211 | } |
||
| 212 | if (! $parentGroup) { |
||
| 213 | $parentGroup = $this->parentGroup; |
||
| 214 | } |
||
| 215 | if (! $permissionCode) { |
||
| 216 | $permissionCode = $this->permissionCode; |
||
| 217 | } |
||
| 218 | if (! $permissionArray || count($permissionArray) === 0) { |
||
| 219 | $permissionArray = $this->permissionArray; |
||
| 220 | } |
||
| 221 | if (! $member) { |
||
| 222 | $member = $this->member; |
||
| 223 | } |
||
| 224 | if (!$name) { |
||
| 225 | $name = 'New Group '.rand(0, 999999); |
||
| 226 | } |
||
| 227 | if (!$code) { |
||
| 228 | $code = $name; |
||
| 229 | } |
||
| 230 | $code = str_replace(' ', '_', $code); |
||
| 231 | $code = preg_replace("/[\W_]+/u", '', $code); |
||
| 232 | //changing to lower case seems to be very important |
||
| 233 | //unidentified bug so far |
||
| 234 | $code = strtolower($code); |
||
| 235 | |||
| 236 | $filterArrayForGroup = array('Code' => $code); |
||
| 237 | $groupDataList = Group::get()->filter($filterArrayForGroup); |
||
| 238 | $groupCount = $groupDataList->count(); |
||
| 239 | $groupStyle = 'updated'; |
||
| 240 | if ($groupCount > 1) { |
||
| 241 | user_error("There is more than one group with the $name ($code) Code"); |
||
| 242 | } |
||
| 243 | if ($groupCount == 0) { |
||
| 244 | $group = Group::create($filterArrayForGroup); |
||
| 245 | $groupStyle = 'created'; |
||
| 246 | } else { |
||
| 247 | $group = $groupDataList->First(); |
||
| 248 | } |
||
| 249 | $group->Locked = 1; |
||
| 250 | $group->Title = $name; |
||
| 251 | $parentGroupStyle = 'updated'; |
||
| 252 | if ($parentGroup) { |
||
| 253 | DB::alteration_message('adding parent group'); |
||
| 254 | if (is_string($parentGroup)) { |
||
| 255 | $parentGroupName = $parentGroup; |
||
| 256 | $parentGroup = DataObject::get_one( |
||
| 257 | 'Group', |
||
| 258 | array('Title' => $parentGroupName), |
||
| 259 | $cacheDataObjectGetOne = false |
||
| 260 | ); |
||
| 261 | if (!$parentGroup) { |
||
| 262 | $parentGroup = Group::create(); |
||
| 263 | $parentGroupStyle = 'created'; |
||
| 264 | $parentGroup->Title = $parentGroupName; |
||
| 265 | $parentGroup->write(); |
||
| 266 | DB::alteration_message("$parentGroupStyle $parentGroupName", $parentGroupStyle); |
||
| 267 | } |
||
| 268 | } |
||
| 269 | if ($parentGroup) { |
||
| 270 | $group->ParentID = $parentGroup->ID; |
||
| 271 | } |
||
| 272 | } |
||
| 273 | $group->write(); |
||
| 274 | DB::alteration_message("$groupStyle $name ($code) group", $groupStyle); |
||
| 275 | $doubleGroups = Group::get() |
||
| 276 | ->filter(array('Code' => $code)) |
||
| 277 | ->exclude(array('ID' => $group->ID)); |
||
| 278 | if ($doubleGroups->count()) { |
||
| 279 | DB::alteration_message($doubleGroups->count().' groups with the same name', 'deleted'); |
||
| 280 | $realMembers = $group->Members(); |
||
| 281 | foreach ($doubleGroups as $doubleGroup) { |
||
| 282 | $fakeMembers = $doubleGroup->Members(); |
||
| 283 | foreach ($fakeMembers as $fakeMember) { |
||
| 284 | DB::alteration_message('adding customers: '.$fakeMember->Email, 'created'); |
||
| 285 | $realMembers->add($fakeMember); |
||
| 286 | } |
||
| 287 | DB::alteration_message('deleting double group ', 'deleted'); |
||
| 288 | $doubleGroup->delete(); |
||
| 289 | } |
||
| 290 | } |
||
| 291 | if ($permissionCode) { |
||
| 292 | $permissionCodeCount = DB::query("SELECT * FROM \"Permission\" WHERE \"GroupID\" = '".$group->ID."' AND \"Code\" LIKE '".$permissionCode."'")->numRecords(); |
||
| 293 | if ($permissionCodeCount == 0) { |
||
| 294 | DB::alteration_message('granting '.$name." permission code $permissionCode ", 'created'); |
||
| 295 | Permission::grant($group->ID, $permissionCode); |
||
| 296 | } else { |
||
| 297 | DB::alteration_message($name." permission code $permissionCode already granted"); |
||
| 298 | } |
||
| 299 | } |
||
| 300 | //we unset it here to avoid confusion with the |
||
| 301 | //other codes we use later on |
||
| 302 | $permissionArray[] = $permissionCode; |
||
| 303 | unset($permissionCode); |
||
| 304 | if ($roleTitle) { |
||
| 305 | $permissionRoleCount = PermissionRole::get() |
||
| 306 | ->Filter(array('Title' => $roleTitle)) |
||
| 307 | ->Count(); |
||
| 308 | if ($permissionRoleCount > 1) { |
||
| 309 | db::alteration_message("There is more than one Permission Role with title $roleTitle ($permissionRoleCount)", 'deleted'); |
||
| 310 | $permissionRolesFirst = DataObject::get_one( |
||
| 311 | 'PermissionRole', |
||
| 312 | array('Title' => $roleTitle), |
||
| 313 | $cacheDataObjectGetOne = false |
||
| 314 | ); |
||
| 315 | $permissionRolesToDelete = PermissionRole::get() |
||
| 316 | ->Filter(array('Title' => $roleTitle)) |
||
| 317 | ->Exclude(array('ID' => $permissionRolesFirst->ID)); |
||
| 318 | foreach ($permissionRolesToDelete as $permissionRoleToDelete) { |
||
| 319 | db::alteration_message("DELETING double permission role $roleTitle", 'deleted'); |
||
| 320 | $permissionRoleToDelete->delete(); |
||
| 321 | } |
||
| 322 | } elseif ($permissionRoleCount == 1) { |
||
| 323 | //do nothing |
||
| 324 | DB::alteration_message("$roleTitle role in place"); |
||
| 325 | } else { |
||
| 326 | DB::alteration_message("adding $roleTitle role", 'created'); |
||
| 327 | $permissionRole = PermissionRole::create(); |
||
| 328 | $permissionRole->Title = $roleTitle; |
||
| 329 | $permissionRole->OnlyAdminCanApply = true; |
||
| 330 | $permissionRole->write(); |
||
| 331 | } |
||
| 332 | $permissionRole = DataObject::get_one( |
||
| 333 | 'PermissionRole', |
||
| 334 | array('Title' => $roleTitle), |
||
| 335 | $cacheDataObjectGetOne = false |
||
| 336 | ); |
||
| 337 | if ($permissionRole) { |
||
| 338 | if (is_array($permissionArray) && count($permissionArray)) { |
||
| 339 | DB::alteration_message('working with '.implode(', ', $permissionArray)); |
||
| 340 | foreach ($permissionArray as $permissionRoleCode) { |
||
| 341 | $permissionRoleCodeObject = DataObject::get_one( |
||
| 342 | 'PermissionRoleCode', |
||
| 343 | array('Code' => $permissionRoleCode, 'RoleID' => $permissionRole->ID), |
||
| 344 | $cacheDataObjectGetOne = false |
||
| 345 | ); |
||
| 346 | $permissionRoleCodeObjectCount = PermissionRoleCode::get() |
||
| 347 | ->Filter(array('Code' => $permissionRoleCode, 'RoleID' => $permissionRole->ID)) |
||
| 348 | ->Count(); |
||
| 349 | if ($permissionRoleCodeObjectCount > 1) { |
||
| 350 | $permissionRoleCodeObjectsToDelete = PermissionRoleCode::get() |
||
| 351 | ->Filter(array('Code' => $permissionRoleCode, 'RoleID' => $permissionRole->ID)) |
||
| 352 | ->Exclude(array('ID' => $permissionRoleCodeObject->ID)); |
||
| 353 | foreach ($permissionRoleCodeObjectsToDelete as $permissionRoleCodeObjectToDelete) { |
||
| 354 | db::alteration_message("DELETING double permission code $permissionRoleCode for ".$permissionRole->Title, 'deleted'); |
||
| 355 | $permissionRoleCodeObjectToDelete->delete(); |
||
| 356 | } |
||
| 357 | db::alteration_message('There is more than one Permission Role Code in '.$permissionRole->Title." with Code = $permissionRoleCode ($permissionRoleCodeObjectCount)", 'deleted'); |
||
| 358 | } elseif ($permissionRoleCodeObjectCount == 1) { |
||
| 359 | //do nothing |
||
| 360 | } else { |
||
| 361 | $permissionRoleCodeObject = PermissionRoleCode::create(); |
||
| 362 | $permissionRoleCodeObject->Code = $permissionRoleCode; |
||
| 363 | $permissionRoleCodeObject->RoleID = $permissionRole->ID; |
||
| 364 | } |
||
| 365 | DB::alteration_message('adding '.$permissionRoleCodeObject->Code.' to '.$permissionRole->Title); |
||
| 366 | $permissionRoleCodeObject->write(); |
||
| 367 | } |
||
| 368 | } |
||
| 369 | if ($group && $permissionRole) { |
||
| 370 | if (DB::query('SELECT COUNT(*) FROM Group_Roles WHERE GroupID = '.$group->ID.' AND PermissionRoleID = '.$permissionRole->ID)->value() == 0) { |
||
| 371 | db::alteration_message('ADDING '.$permissionRole->Title.' permission role to '.$group->Title.' group', 'created'); |
||
| 372 | $existingGroups = $permissionRole->Groups(); |
||
| 373 | $existingGroups->add($group); |
||
| 374 | } else { |
||
| 375 | db::alteration_message('CHECKED '.$permissionRole->Title.' permission role to '.$group->Title.' group'); |
||
| 376 | } |
||
| 377 | } else { |
||
| 378 | db::alteration_message('ERROR: missing group or permissionRole', 'deleted'); |
||
| 379 | } |
||
| 380 | } |
||
| 381 | } |
||
| 382 | if ($member) { |
||
| 383 | if (is_string($member)) { |
||
| 384 | $email = $member; |
||
| 385 | $member = $this->CreateDefaultMember($email, $code, $name); |
||
| 386 | } |
||
| 387 | if ($member) { |
||
| 388 | DB::alteration_message(' adding member '.$member->Email.' to group '.$group->Title, 'created'); |
||
| 389 | $member->Groups()->add($group); |
||
| 390 | } |
||
| 391 | } else { |
||
| 392 | DB::alteration_message('No user provided.'); |
||
| 393 | } |
||
| 394 | |||
| 395 | return $group; |
||
| 396 | } |
||
| 397 | } |
||
| 398 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.