PerfectCMSImage_Validator

Complexity

Total Complexity

15

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setFieldName()	0	4	1
C	validate()	0	26	7
A	isImageCorrectWidth()	0	10	3
A	getWidthOrHeight()	0	21	4

<?php

class PerfectCMSImage_Validator extends Upload_Validator

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    protected $fieldName = '';

    public function setFieldName($fieldName)
    {
        $this->fieldName = $fieldName;
    }
    /**
     * Looser check validation that doesn't do is_upload_file()
     * checks as we're faking a POST request that PHP didn't generate
     * itself.
     *
     * @return boolean
     */
    public function validate()
    {
        $hasError = false;
        if(PerfectCMSImageDataExtension::get_enforce_size($this->fieldName)) {
            $widthRecommendation = (PerfectCMSImageDataExtension::get_width($this->fieldName) * 2);
            $heightRecommendation = (PerfectCMSImageDataExtension::get_height($this->fieldName) * 2);
            if ($widthRecommendation) {
                if (! $this->isImageCorrectWidth(true, $widthRecommendation)) {
                    $this->errors[] = "Expected width: " . $widthRecommendation . "px;";
                    $hasError = true;
                }
            }

            if ($heightRecommendation) {
                if (! $this->isImageCorrectWidth(false, $heightRecommendation)) {
                    $this->errors[] = "Expected height: " . $heightRecommendation . "px;";
                    $hasError = true;
                }
            }
        }
        $parentResult = parent::validate();
        if ($hasError) {
            return false;
        }
        return $parentResult;
    }

    protected function isImageCorrectWidth($isWidth, $recommendedWidthOrHeight)
    {
        $actualWidthOrHeight = $this->getWidthOrHeight($isWidth);
        if ($actualWidthOrHeight) {
            if ($actualWidthOrHeight != $recommendedWidthOrHeight) {
                return false;
            }
        }
        return true;
    }


    protected function getWidthOrHeight($isWidth)

The return type could not be reliably inferred; please add a @return annotation.

    {
        $imageSize = false;
        if (isset($this->tmpFile["tmp_name"])) {
            $imageSize = getimagesize($this->tmpFile["tmp_name"]);
        } else {

This else statement is empty and can be removed.

            // $imagefile = $this->getFullPath();

55% of this comment could be valid code. Did you maybe forget this after debugging?

            // if($this->exists() && file_exists($imageFile)) {

67% of this comment could be valid code. Did you maybe forget this after debugging?

            //     $imageSize = getimagesize($imagefile);

50% of this comment could be valid code. Did you maybe forget this after debugging?

            // }
        }
        if ($imageSize === false) {
            return false;
        } else {
            if ($isWidth) {
                return $imageSize[0];
            } else {
                return $imageSize[1];
            }
        }
    }
}