Sunnysideup\PerfectCmsImages\Api\ImageManipulations

Complexity

Total Complexity

57

Size/Duplication

Total Lines	272
Duplicated Lines	0 %

Importance

Changes	11
Bugs	2	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	web_p_enabled()	0	13	5
C	web_p_link()	0	39	12
B	get_placeholder_image_tag()	0	22	7
A	get_backup_image()	0	9	2
B	add_fake_parts()	0	33	7
F	get_image_link()	0	113	24

<?php

namespace Sunnysideup\PerfectCmsImages\Api;

use SilverStripe\Assets\Image;
use SilverStripe\Control\Controller;
use SilverStripe\Control\Director;
use SilverStripe\Core\Config\Config;
use SilverStripe\Core\Config\Configurable;
use SilverStripe\Core\Convert;
use SilverStripe\Core\Injector\Injectable;
use SilverStripe\ORM\DataObject;
use SilverStripe\SiteConfig\SiteConfig;

class ImageManipulations
{
    use Configurable;
    use Injectable;

    private static $webp_enabled = true;

    private static $webp_quality = 77;

    private static $imageLinkCache = [];

    /**
     * work out the best image link.
     *
     * There are basically three options:
     * a. if the height and/or width matches or is smaller than it should be
     *    then just return natural image
     * b. if crop is set to true then Fill
     * c. otherwise resize Height/Width/Both
     *
     * @param Image     $image
     * @param null|bool $useRetina     optional
     * @param null|bool $forMobile     optional
     * @param null|int  $resizeToWidth optional
     */
    public static function get_image_link($image, string $name, ?bool $useRetina = null, ?bool $forMobile = null, ?int $resizeToWidth = 0): string
    {
        // if specified to use retina, then check if it is needed at all.
        if ($useRetina) {
            $useRetina = PerfectCMSImages::use_retina($name);
        }
        $cacheKey =
            implode(
                '_',
                array_filter(
                    [
                        $image->ID,
                        $name,
                        ($useRetina ? 'Y' : 'N'),
                        ($forMobile ? 'MY' : 'MN'),
                        $resizeToWidth
                    ]
                )
            );
        if (!isset(self::$imageLinkCache[$cacheKey])) {
            $link = '';

The assignment to $link is dead and can be removed.

            if ($forMobile) {
                $perfectWidth = (int) PerfectCMSImages::get_mobile_width($name, true);
                $perfectHeight = (int) PerfectCMSImages::get_mobile_height($name, true);
                if (!$perfectHeight && !$perfectWidth) {
                    self::$imageLinkCache[$cacheKey] = '';
                    return self::$imageLinkCache[$cacheKey];
                }
            } else {
                $perfectWidth = (int) PerfectCMSImages::get_width($name, true);
                $perfectHeight = (int) PerfectCMSImages::get_height($name, true);
            }

            $crop = PerfectCMSImages::is_crop($name);

            $multiplier = PerfectCMSImages::get_multiplier($useRetina);

It seems like $useRetina can also be of type null; however, parameter $useRetina of Sunnysideup\PerfectCmsImages\Api\PerfectCMSImages::get_multiplier() does only seem to accept boolean, maybe add an additional type check?

            $perfectWidth *= $multiplier;
            $perfectHeight *= $multiplier;

            //get current width and height
            $myWidth = $image->getWidth();
            $myHeight = $image->getHeight();
            //if we are trying to resize to a width that is small than the perfect width
            //and the resize width is small than the current width, then lets resize...
            if (0 !== (int) $resizeToWidth) {
                if ($resizeToWidth < $perfectWidth && $resizeToWidth < $myWidth) {
                    $perfectWidth = $resizeToWidth;
                }
            }

            $link = null;
            if ($perfectWidth && $perfectHeight) {

The expression $perfectWidth of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

                //if the height or the width are already perfect then we can not do anything about it.
                if ($myWidth === $perfectWidth && $myHeight === $perfectHeight) {
                    $link = $image->getURL();
                } elseif ($myWidth < $perfectWidth || $myHeight < $perfectHeight) {
                    $link = $image->getImageLinkCachedIfExists(
                        'Pad',
                        $perfectWidth,
                        $perfectHeight,
                        PerfectCMSImages::get_padding_bg_colour($name)
                    );
                } elseif ($crop) {
                    $link = $image->getImageLinkCachedIfExists(
                        'Fill',
                        $perfectWidth,
                        $perfectHeight
                    );
                } else {
                    $link = $image->getImageLinkCachedIfExists(
                        'FitMax',
                        $perfectWidth,
                        $perfectHeight
                    );
                }
            } elseif ($perfectWidth) {

The expression $perfectWidth of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

                if ($myWidth === $perfectWidth) {
                    $link = $image->getURL();
                } elseif ($crop) {
                    $link = $image->getImageLinkCachedIfExists(
                        'Fill',
                        $perfectWidth,
                        $myHeight
                    );
                } else {
                    $link = $image->getImageLinkCachedIfExists(
                        'ScaleWidth',
                        $perfectWidth
                    );
                }
            } elseif ($perfectHeight) {
                if ($myHeight === $perfectHeight) {
                    $link = $image->getUrl();
                } elseif ($crop) {
                    $link = $image->getImageLinkCachedIfExists(
                        'Fill',
                        $myWidth,
                        $perfectHeight
                    );
                } else {
                    $link = $image->getImageLinkCachedIfExists(
                        'ScaleHeight',
                        $perfectHeight
                    );
                }
            } else {
                // not for mobile, we definitely want to have some sort of link!
                $link = $image->getUrl();
            }
            self::$imageLinkCache[$cacheKey] = (string) $link;
        }

        return self::$imageLinkCache[$cacheKey];
    }

    /**
     * back-up image.
     *
     * @return null|Image
     */
    public static function get_backup_image(string $name)
    {
        $image = null;
        $backupObject = SiteConfig::current_site_config();
        if ($backupObject->hasMethod($name)) {
            $image = $backupObject->{$name}();
        }

        return $image;
    }

    /**
     * placeholder image.
     */
    public static function get_placeholder_image_tag(string $name): string
    {
        $multiplier = (int) PerfectCMSImages::get_multiplier(true);
        $perfectWidth = (int) PerfectCMSImages::get_width($name, true);
        $perfectHeight = (int) PerfectCMSImages::get_height($name, true);
        $perfectWidth *= $multiplier;
        $perfectHeight *= $multiplier;
        if ($perfectWidth || $perfectHeight) {
            if (0 === $perfectWidth && $perfectHeight === 0) {
                $perfectWidth = 200;
            } elseif (0 === $perfectWidth) {
                $perfectWidth = $perfectHeight;
            } elseif ($perfectHeight === 0) {
                $perfectHeight = $perfectWidth;
            }

            $text = "{$perfectWidth} x {$perfectHeight} /2 = " . round($perfectWidth / 2) . ' x ' . round($perfectHeight / 2) . '';

            return 'https://placehold.it/' . $perfectWidth . 'x' . $perfectHeight . '?text=' . urlencode($text);
        }

        return 'https://placehold.it/1500x1500?text=' . urlencode('no size set');
    }

    public static function web_p_link(string $link): string
    {
        if (self::web_p_enabled() && $link) {
            $fileNameWithBaseFolder = Director::baseFolder() . '/public' . $link;
            $arrayOfLink = explode('.', $link);
            $extension = array_pop($arrayOfLink);
            $pathWithoutExtension = rtrim($link, '.' . $extension);
            $webPFileName = $pathWithoutExtension . '_' . $extension . '.webp';
            $webPFileNameWithBaseFolder = Director::baseFolder() . '/public' . $webPFileName;
            if (file_exists($fileNameWithBaseFolder)) {
                if (isset($_GET['flush']) && file_exists($webPFileNameWithBaseFolder)) {
                    unlink($webPFileNameWithBaseFolder);
                }

                if (file_exists($webPFileNameWithBaseFolder)) {
                    //todo: check that image is the same ...
                } else {
                    list($width, $height, $type) = getimagesize($fileNameWithBaseFolder);
                    $img = null;
                    if ($width && $height) {
                        if (2 === $type) {
                            $img = imagecreatefromjpeg($fileNameWithBaseFolder);
                        } elseif (3 === $type) {
                            $img = imagecreatefrompng($fileNameWithBaseFolder);
                            imagesavealpha($img, true);
                        }

                        if (null !== $img) {
                            $quality = Config::inst()->get(ImageManipulations::class, 'webp_quality');
                            imagewebp($img, $webPFileNameWithBaseFolder, $quality);
                        }
                    }
                }

                return $webPFileName;
            }
        }

        return $link;
    }

    public static function add_fake_parts($image, string $link): string
    {
        // first get the timestamp
        $time1 = strtotime((string) $image->LastEdited);
        $time2 = 0;
        $path = Controller::join_links(Director::baseFolder(), PUBLIC_DIR, $link);
        if (file_exists($path)) {
            $time2 = filemtime($path);
        }

        // first convert to hash extension
        if (class_exists('HashPathExtension')) {
            /** @var null|Controller $curr */
            $curr = Controller::curr();
            if ($curr) {

$curr is of type SilverStripe\Control\Controller, thus it always evaluated to true.

                if ($curr->hasMethod('HashPath')) {
                    $link = $curr->HashPath($link, false);
                }
            }
        }

        // now you can add the time
        $link .= '?time=' . max($time1, $time2);

        // finally add the title
        if ($image->Title) {
            $imageClasses = Config::inst()->get(PerfectCMSImages::class, 'perfect_cms_images_append_title_to_image_links_classes');
            if (in_array($image->ClassName, $imageClasses, true)) {
                $link .= '&title=' . urlencode(Convert::raw2att($image->Title));

It seems like SilverStripe\Core\Convert::raw2att($image->Title) can also be of type array and array; however, parameter $string of urlencode() does only seem to accept string, maybe add an additional type check?

            }
        }

        return $link;
    }

    public static function web_p_enabled(): bool
    {
        if (Config::inst()->get(ImageManipulations::class, 'webp_enabled')) {
            if (function_exists('imagewebp')) {
                if (function_exists('imagecreatefromjpeg')) {
                    if (function_exists('imagecreatefrompng')) {
                        return true;
                    }
                }
            }
        }

        return false;
    }
}