PDFUploadField

Complexity

Total Complexity

2

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	24	2

<?php

/**
 * allow a pdf to be uploaded...
 *
 * Usage:
 *     $field = PDFUploadField::create(
 *         "ReportField",
 *         "Title",
 *         null,
 *         "folder-name"
 *     );
 */
class PDFUploadField extends UploadField

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $pdf_folder_name = "pdfs";

The property $pdf_folder_name is not used and could be removed.

    /**
     * @param string  $name
     * @param string  $title
     * @param SS_List $items If no items are defined, the field will try to auto-detect an existing relation on

Should the type for parameter $items not be null|SS_List?

     *
     *                       @link $record}, with the same name as the field name.
     *
     * @param string $folderName
     *
     * @return ReportUploadField

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct(
        $name,
        $title,
        SS_List $items = null,
        $folderName = ""
    ) {
        parent::__construct(
            $name,
            $title,
            $items
        );
        $this->setRightTitle('Only PDF files are accepted.');
        //create folder
        if (!$folderName) {
            $folderName = Config::inst()->get('PDFUploadField', 'pdf_folder_name');
        }
        Folder::find_or_make(Director::baseFolder()."/assets/".$folderName);
        //set folder
        $this->setFolderName($folderName);
        $this->setAllowedExtensions(array('pdf'));
        $this->setAllowedMaxFileNumber(1);

        return $this;

Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct?

    }
}