Issues in DpsPxPayPayment.php (master) - Issues in master - sunnysideup/silverstripe-payment_dps - Measure and Improve Code Quality continuously with Scrutinizer

Issues (187)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/DpsPxPayPayment.php (21 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 *@author nicolaas[at]sunnysideup.co.nz
 *@description: OrderNumber and PaymentID
 *
 *
 **/

class DpsPxPayPayment extends EcommercePayment
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        'TxnRef' => 'Text',
        'DebugMessage' => 'HTMLText'
    );

    protected $Currency = "";
    public function setCurrency($s)
    {
        $this->Currency = $s;
    }

    // DPS Information

    private static $privacy_link = 'http://www.paymentexpress.com/privacypolicy.htm';


    private static $logo = 'payment_dps/images/dps_paymentexpress_small.png';



    // URLs

    // Please set from YAML. See _config/payment_dps.yml.example
    private static $credit_cards = array(
        /*'Visa' => 'ecommerce/images/paymentmethods/visa.jpg',

        'MasterCard' => 'ecommerce/images/paymentmethods/mastercard.jpg',
        'American Express' => 'ecommerce/images/paymentmethods/american-express.gif',
        'Dinners Club' => 'ecommerce/images/paymentmethods/dinners-club.jpg',
        'JCB' => 'ecommerce/images/paymentmethods/jcb.jpg'*/
    );

    public static function remove_credit_card($creditCard)
    {
        unset(self::$credit_cards[$creditCard]);
    }

    private static $email_debug = false;


    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->replaceField("DebugMessage", new ReadonlyField("DebugMessage", "Debug info"));
        return $fields;
    }

    public function getPaymentFormFields()
    {
        $logo = '<img src="' . $this->config()->get("logo"). '" alt="Credit card payments powered by DPS"/>';
        $privacyLink = '<a href="' . $this->config()->get("privacy_link"). '" target="_blank" title="Read DPS\'s privacy policy">' . $logo . '</a><br/>';
        $paymentsList = '';
        if ($cards = $this->config()->get("credit_cards")) {
            foreach ($cards as $name => $image) {
                $paymentsList .= '<img src="' . $image . '" alt="' . $name . '"/>';
            }
        }
        $fields = new FieldList(
            new LiteralField('DPSInfo', $privacyLink),
            new LiteralField('DPSPaymentsList', $paymentsList)
        );
        return $fields;
    }

    public function getPaymentFormRequirements()
    {
        return array();
    }

    /**
     * @param array $data The form request data - see OrderForm
     * @param OrderForm $form The form object submitted on
     *
     * @return EcommercePayment_Result
     */
    public function processPayment($data, $form)
    {
        $order = $this->Order();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        //if currency has been pre-set use this
        $currency = $this->Amount->Currency;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        //if amout has been pre-set, use this
        $amount = $this->Amount->Amount;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if ($order && $order->exists()) {
            //amount may need to be adjusted to total outstanding
            //or amount may not have been set yet
            $amount = $order->TotalOutstanding();
            //get currency from Order
            //this is better than the pre-set currency one
            //which may have been set to the default
            $currencyObject = $order->CurrencyUsed();
            if ($currencyObject) {
                $currency = $currencyObject->Code;
            }
        }
        if (!$amount && !empty($data["Amount"])) {
            $amount = floatval($data["Amount"]);
        }
        if (!$currency && !empty($data["Currency"])) {
            $currency = floatval($data["Currency"]);
        }
        //final backup for currency
        if (!$currency) {
            $currency = EcommercePayment::site_currency();
        }
        $this->Amount->Currency = $currency;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->Amount->Amount = $amount;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        //no need to write here, as it will be done by BuildURL
        //$this->write();

        $url = $this->buildURL($amount, $currency);
        return $this->executeURL($url);
    }

    /**
     *
     * @param Float $amount
     * @param String $currency - e.g. NZD
     * @return String
     *
     */
    protected function buildURL($amount, $currency)
    {
        $commsObject = new DpsPxPayComs();

        /**
        * order details
        **/
        $commsObject->setTxnType(DpsPxPayComs::get_txn_type());
        $commsObject->setMerchantReference($this->ID);
        //replace any character that is NOT [0-9] or dot (.)

        $commsObject->setAmountInput(floatval(preg_replace("/[^0-9\.]/", "", $amount)));
        $commsObject->setCurrencyInput($currency);

        /**
        * details of the redirection
        **/
        $commsObject->setUrlFail(DpsPxPayPayment_Handler::absolute_complete_link());
        $commsObject->setUrlSuccess(DpsPxPayPayment_Handler::absolute_complete_link());

        /**
        * process payment data (check if it is OK and go forward if it is...
        **/
        $url = $commsObject->startPaymentProcess();
        $debugMessage = $commsObject->getDebugMessage();
        $this->DebugMessage = $debugMessage;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->write();
        if ($this->config()->get("email_debug")) {
            $from = Email::config()->admin_email;
            $to = Email::config()->admin_email;
            $subject = "DPS Debug Information";
            $body = $debugMessage;
            $email = new Email($from, $to, $subject, $body);
            $email->send();
        }
        return $url;
    }

    public function executeURL($url)
    {
        $url = str_replace("&", "&amp;", $url);
        $url = str_replace("&amp;&amp;", "&amp;", $url);
        //$url = str_replace("==", "", $url);

        if ($url) {
            /**
            * build redirection page
            **/
            $page = new SiteTree();
            $page->Title = 'Redirection to DPS...';
            $page->Logo = '<img src="' . $this->config()->get("logo") . '" alt="Payments powered by DPS"/>';
            $page->Form = $this->DPSForm($url);
            $controller = new ContentController($page);
            Requirements::clear();
            Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
            //Requirements::block(THIRDPARTY_DIR."/jquery/jquery.js");

            //Requirements::javascript(Director::protocol()."ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js");

            return EcommercePayment_Processing::create($controller->renderWith('PaymentProcessingPage'));
        } else {
            $page = new SiteTree();
            $page->Title = 'Sorry, DPS can not be contacted at the moment ...';
            $page->Logo = 'Sorry, an error has occured in contacting the Payment Processing Provider, please try again in a few minutes...';
            $page->Form = $this->DPSForm($url);
            $controller = new ContentController($page);
            Requirements::clear();
            Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
            //Requirements::block(THIRDPARTY_DIR."/jquery/jquery.js");

            //Requirements::javascript(Director::protocol()."ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js");

            return EcommercePayment_Failure::create($controller->renderWith('PaymentProcessingPage'));
        }
    }

    public function DPSForm($url)

    {
        $urlWithoutAmpersand = Convert::raw2js(str_replace('&amp;', '&', $url));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        return <<<HTML
            <form id="PaymentFormDPS" method="post" action="$url">
                <input type="submit" value="pay now" />
            </form>
            <script type="text/javascript">
                jQuery(document).ready(function() {
                    if(!jQuery.browser.msie) {
                        jQuery("#PaymentFormDPS").submit();
                    }
                });
            </script>
HTML;
    }
}


sunnysideup / silverstripe-payment_dps

Issues (187)

Security Analysis not enabled

code/DpsPxPayPayment.php (21 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like