DpsPxPost::processPayment() - Code Metrics - sunnysideup/silverstripe-payment_dps - Measure and Improve Code Quality continuously with Scrutinizer

DpsPxPost::processPayment() C
last analyzed 2018-05-14 05:39 UTC

↳ Parent: DpsPxPost
Complexity

Conditions	7
Paths	4
Size

Total Lines	68
Code Lines	50
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	7
eloc	50
nc	4
nop	2
dl	0
loc	68
rs	6.9654
c	0
b	0
f	0
How to fix Long Method

<?php

/**
 *
 *
 * @see: https://www.paymentexpress.com/Technical_Resources/Ecommerce_NonHosted/PxPost
 */


class DpsPxPost extends EcommercePayment
namespace YourVendor;

class YourClass { }
{

    /**
     * set the required privacy link as you see fit...
     * also see: https://www.paymentexpress.com/About/Artwork_Downloads
     * also see: https://www.paymentexpress.com/About/About_DPS/Privacy_Policy
     * @var String
     */
    private static $dps_logo_and_link = '

	<div id="PXPostPrivacy">
		<a href="https://www.paymentexpress.com/About/About_DPS/Privacy_Policy">
			<img src="https://www.paymentexpress.com/DPS/media/theme/pxlogostackedreg.png" alt="Payment Processor" width="50%" height="50%" />
		</a>
		<span>
			<a href="https://www.paymentexpress.com/About/About_DPS/Privacy_Policy">
				Payment processing provided by DPS (view Privacy Policy)
			</a>
		</span>
	</div>
	';

    /**
     * we use yes / no as this is more reliable than a boolean value
     * for configs
     * @var String
     */
    private static $is_test = "yes";


    /**
     * we use yes / no as this is more reliable than a boolean value
     * for configs
     * @var boolean
     */
    private static $is_live = "no";


    /**
     *
     * @var string
     */
    private static $username = "";


    /**
     *
     * @var string
     */
    private static $password = "";


    /**
     * type: purchase / Authorisation / refund ...
     * @var string
     */
    private static $type = "Purchase";


    /**
     * Incomplete (default): Payment created but nothing confirmed as successful
     * Success: Payment successful
     * Failure: Payment failed during process
     * Pending: Payment awaiting receipt/bank transfer etc
     */
    private static $db = array(

        "CardNumber" => "Varchar(64)",
        "NameOnCard" => "Varchar(40)",
        "ExpiryDate" => "Varchar(4)",
        "CVVNumber" => "Varchar(3)",
        "Request" => "Text",
        "Response" => "Text"
    );

    private static $casting = array(

        "RequestDetails" => "HTMLText",
        "ResponseDetails" => "HTMLText"
    );

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->addFieldToTab("Root.Details", new LiteralField("Request", $this->getRequestDetails()));
        $fields->addFieldToTab("Root.Details", new LiteralField("Response", $this->getResponseDetails()));
        return $fields;
    }

    /**
     * Return the payment form fields that should
     * be shown on the checkout order form for the
     * payment type. Example: for {@link DPSPayment},
     * this would be a set of fields to enter your
     * credit card details.
     *
     * @return FieldList
     */
    public function getPaymentFormFields()
    {
        $formHelper = $this->ecommercePaymentFormSetupAndValidationObject();
        $fieldList = $formHelper->getCreditCardPaymentFormFields($this);
        $fieldList->insertBefore(
            new LiteralField("DpsPxPost_Logo", $this->Config()->get("dps_logo_and_link")),
            "DpsPxPost_CreditCard"
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
        return $fieldList;
    }

    /**
     * Define what fields defined in {@link Order->getPaymentFormFields()}
     * should be required.
     *
     * @see DPSPayment->getPaymentFormRequirements() for an example on how
     * this is implemented.
     *
     * @return array

     */
    public function getPaymentFormRequirements()
    {
        $formHelper = $this->ecommercePaymentFormSetupAndValidationObject();
        return $formHelper->getCreditCardPaymentFormFields($this);
    }

    /**
     * returns true if all the data is correct.
     *
     * @param array $data The form request data - see OrderForm
     * @param OrderForm $form The form object submitted on
     *
     * @return Boolean
     */
    public function validatePayment($data, $form)
    {
        $formHelper = $this->ecommercePaymentFormSetupAndValidationObject();
        return $formHelper->validateAndSaveCreditCardInformation($data, $form, $this);
    }

    /**
     * Perform payment processing for the type of
     * payment. For example, if this was a credit card
     * payment type, you would perform the data send
     * off to the payment gateway on this function for
     * your payment subclass.
     *
     * This is used by {@link OrderForm} when it is
     * submitted.
     *
     * @param array $data The form request data - see OrderForm
     * @param OrderForm $form The form object submitted on
     *
     * @return EcommercePayment_Result
     */
    public function processPayment($data, $form)
    {
        //save data
        $this->write();

        //get variables
        $isTest = $this->isTest();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $order = $this->Order();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        //if currency has been pre-set use this
        $currency = strtoupper($this->Amount->Currency);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        //if amout has been pre-set, use this
        $amount = $this->Amount->Amount;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $username = $this->Config()->get("username");
        $password = $this->Config()->get("password");
        if (!$username || !$password) {
            user_error("Make sure to set a username and password.");
        }

        $xml  = "<Txn>";
        $xml .= "<PostUsername>".$username."</PostUsername>";
        $xml .= "<PostPassword>".$password."</PostPassword>";
        $xml .= "<CardHolderName>".Convert::raw2xml($this->NameOnCard)."</CardHolderName>";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $xml .= "<CardNumber>".$this->CardNumber."</CardNumber>";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $xml .= "<Amount>".round($amount, 2)."</Amount>";
        $xml .= "<DateExpiry>".$this->ExpiryDate."</DateExpiry>";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $xml .= "<Cvc2>".$this->CVVNumber."</Cvc2>";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $xml .= "<Cvc2Presence>1</Cvc2Presence>";
        $xml .= "<InputCurrency>".Convert::raw2xml(strtoupper($currency))."</InputCurrency>";
        $xml .= "<TxnType>".Convert::raw2xml($this->Config()->get("type"))."</TxnType>";
        $xml .= "<TxnId>".$this->ID."</TxnId>";
        $xml .= "<MerchantReference>".$this->OrderID."</MerchantReference>";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $xml .= "</Txn>";
        $URL = "sec.paymentexpress.com/pxpost.aspx";
        //echo "\n\n\n\nSENT:\n$cmdDoTxnTransaction\n\n\n\n\n$";

        $ch = curl_init();
        curl_setopt($ch, CURLOPT_URL, "https://".$URL);
        curl_setopt($ch, CURLOPT_POST, 1);
        curl_setopt($ch, CURLOPT_POSTFIELDS, $xml);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
        curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, 0); //Needs to be included if no *.crt is available to verify SSL certificates

        $result = curl_exec($ch);
        curl_close($ch);

        $params = new SimpleXMLElement($result);
        $txn = $params->Transaction;


        //save basic info
        //$this->Request = Convert::raw2sql($xml);

        $this->Response = str_replace('\n', "\n", Convert::raw2sql(print_r($params, 1)));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->Message = Convert::raw2sql($txn->CardHolderResponseText." ".$txn->CardHolderResponseDescription);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->CardNumber = Convert::raw2sql($txn->CardNumber);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if (
            $params->Success == 1 &&
            $amount == $txn->Amount &&
            $currency == $txn->CurrencyName &&
            trim($this->OrderID) == trim($txn->MerchantReference)
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        ) {
            $this->Status = "Success";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $returnObject = EcommercePayment_Success::create();
        } else {
            $this->Status = "Failure";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $returnObject = EcommercePayment_Failure::create();
        }
        $this->write();
        return $returnObject;
    }


    /**
     * are you running in test mode?
     *
     * @return Boolean

     */
    protected function isTest()
    {
        if ($this->Config()->get("is_test") == "yes" && $this->Config()->get("is_live") == "no") {
            return true;
        } elseif ($this->Config()->get("is_test") == "no" && $this->Config()->get("is_live") == "yes") {
            return false;
        } else {
            user_error("Class not set to live or test correctly.");
        }
    }

    public function getRequestDetails()
    {
        return "<pre>".$this->Request."</pre>";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getResponseDetails()
    {
        return "<pre>".$this->Response."</pre>";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}

sunnysideup / silverstripe-payment_dps

DpsPxPost::processPayment() C last analyzed 2018-05-14 05:39 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

DpsPxPost::processPayment() C
last analyzed 2018-05-14 05:39 UTC
