DpsPxPayPayment::processPayment() - Code Metrics - sunnysideup/silverstripe-payment_dps - Measure and Improve Code Quality continuously with Scrutinizer

DpsPxPayPayment::processPayment() D
last analyzed 2018-05-14 05:39 UTC

↳ Parent: DpsPxPayPayment

Complexity

Conditions	9
Paths	24

Size

Total Lines	36
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	9
eloc	19
nc	24
nop	2
dl	0
loc	36
rs	4.909
c	0
b	0
f	0

<?php

/**
 *@author nicolaas[at]sunnysideup.co.nz
 *@description: OrderNumber and PaymentID
 *
 *
 **/

class DpsPxPayPayment extends EcommercePayment
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        'TxnRef' => 'Text',
        'DebugMessage' => 'HTMLText'
    );

    protected $Currency = "";
    public function setCurrency($s)
    {
        $this->Currency = $s;
    }

    // DPS Information

    private static $privacy_link = 'http://www.paymentexpress.com/privacypolicy.htm';


    private static $logo = 'payment_dps/images/dps_paymentexpress_small.png';



    // URLs

    // Please set from YAML. See _config/payment_dps.yml.example
    private static $credit_cards = array(
        /*'Visa' => 'ecommerce/images/paymentmethods/visa.jpg',

        'MasterCard' => 'ecommerce/images/paymentmethods/mastercard.jpg',
        'American Express' => 'ecommerce/images/paymentmethods/american-express.gif',
        'Dinners Club' => 'ecommerce/images/paymentmethods/dinners-club.jpg',
        'JCB' => 'ecommerce/images/paymentmethods/jcb.jpg'*/
    );

    public static function remove_credit_card($creditCard)
    {
        unset(self::$credit_cards[$creditCard]);
    }

    private static $email_debug = false;


    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->replaceField("DebugMessage", new ReadonlyField("DebugMessage", "Debug info"));
        return $fields;
    }

    public function getPaymentFormFields()
    {
        $logo = '<img src="' . $this->config()->get("logo"). '" alt="Credit card payments powered by DPS"/>';
        $privacyLink = '<a href="' . $this->config()->get("privacy_link"). '" target="_blank" title="Read DPS\'s privacy policy">' . $logo . '</a><br/>';
        $paymentsList = '';
        if ($cards = $this->config()->get("credit_cards")) {
            foreach ($cards as $name => $image) {
                $paymentsList .= '<img src="' . $image . '" alt="' . $name . '"/>';
            }
        }
        $fields = new FieldList(
            new LiteralField('DPSInfo', $privacyLink),
            new LiteralField('DPSPaymentsList', $paymentsList)
        );
        return $fields;
    }

    public function getPaymentFormRequirements()
    {
        return array();
    }

    /**
     * @param array $data The form request data - see OrderForm
     * @param OrderForm $form The form object submitted on
     *
     * @return EcommercePayment_Result
     */
    public function processPayment($data, $form)
    {
        $order = $this->Order();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        //if currency has been pre-set use this
        $currency = $this->Amount->Currency;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        //if amout has been pre-set, use this
        $amount = $this->Amount->Amount;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if ($order && $order->exists()) {
            //amount may need to be adjusted to total outstanding
            //or amount may not have been set yet
            $amount = $order->TotalOutstanding();
            //get currency from Order
            //this is better than the pre-set currency one
            //which may have been set to the default
            $currencyObject = $order->CurrencyUsed();
            if ($currencyObject) {
                $currency = $currencyObject->Code;
            }
        }
        if (!$amount && !empty($data["Amount"])) {
            $amount = floatval($data["Amount"]);
        }
        if (!$currency && !empty($data["Currency"])) {
            $currency = floatval($data["Currency"]);
        }
        //final backup for currency
        if (!$currency) {
            $currency = EcommercePayment::site_currency();
        }
        $this->Amount->Currency = $currency;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->Amount->Amount = $amount;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        //no need to write here, as it will be done by BuildURL
        //$this->write();

        $url = $this->buildURL($amount, $currency);
        return $this->executeURL($url);
    }

    /**
     *
     * @param Float $amount
     * @param String $currency - e.g. NZD
     * @return String
     *
     */
    protected function buildURL($amount, $currency)
    {
        $commsObject = new DpsPxPayComs();

        /**
        * order details
        **/
        $commsObject->setTxnType(DpsPxPayComs::get_txn_type());
        $commsObject->setMerchantReference($this->ID);
        //replace any character that is NOT [0-9] or dot (.)

        $commsObject->setAmountInput(floatval(preg_replace("/[^0-9\.]/", "", $amount)));
        $commsObject->setCurrencyInput($currency);

        /**
        * details of the redirection
        **/
        $commsObject->setUrlFail(DpsPxPayPayment_Handler::absolute_complete_link());
        $commsObject->setUrlSuccess(DpsPxPayPayment_Handler::absolute_complete_link());

        /**
        * process payment data (check if it is OK and go forward if it is...
        **/
        $url = $commsObject->startPaymentProcess();
        $debugMessage = $commsObject->getDebugMessage();
        $this->DebugMessage = $debugMessage;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->write();
        if ($this->config()->get("email_debug")) {
            $from = Email::config()->admin_email;
            $to = Email::config()->admin_email;
            $subject = "DPS Debug Information";
            $body = $debugMessage;
            $email = new Email($from, $to, $subject, $body);
            $email->send();
        }
        return $url;
    }

    public function executeURL($url)
    {
        $url = str_replace("&", "&amp;", $url);
        $url = str_replace("&amp;&amp;", "&amp;", $url);
        //$url = str_replace("==", "", $url);

        if ($url) {
            /**
            * build redirection page
            **/
            $page = new SiteTree();
            $page->Title = 'Redirection to DPS...';
            $page->Logo = '<img src="' . $this->config()->get("logo") . '" alt="Payments powered by DPS"/>';
            $page->Form = $this->DPSForm($url);
            $controller = new ContentController($page);
            Requirements::clear();
            Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
            //Requirements::block(THIRDPARTY_DIR."/jquery/jquery.js");

            //Requirements::javascript(Director::protocol()."ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js");

            return EcommercePayment_Processing::create($controller->renderWith('PaymentProcessingPage'));
        } else {
            $page = new SiteTree();
            $page->Title = 'Sorry, DPS can not be contacted at the moment ...';
            $page->Logo = 'Sorry, an error has occured in contacting the Payment Processing Provider, please try again in a few minutes...';
            $page->Form = $this->DPSForm($url);
            $controller = new ContentController($page);
            Requirements::clear();
            Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
            //Requirements::block(THIRDPARTY_DIR."/jquery/jquery.js");

            //Requirements::javascript(Director::protocol()."ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js");

            return EcommercePayment_Failure::create($controller->renderWith('PaymentProcessingPage'));
        }
    }

    public function DPSForm($url)

    {
        $urlWithoutAmpersand = Convert::raw2js(str_replace('&amp;', '&', $url));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        return <<<HTML
            <form id="PaymentFormDPS" method="post" action="$url">
                <input type="submit" value="pay now" />
            </form>
            <script type="text/javascript">
                jQuery(document).ready(function() {
                    if(!jQuery.browser.msie) {
                        jQuery("#PaymentFormDPS").submit();
                    }
                });
            </script>
HTML;
    }
}


1			<?php
2
3			/**
4			*@author nicolaas[at]sunnysideup.co.nz
5			*@description: OrderNumber and PaymentID
6			*
7			*
8			**/
9
10			class DpsPxPayPayment extends EcommercePayment
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
11			{
12			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
13			'TxnRef' => 'Text',
14			'DebugMessage' => 'HTMLText'
15			);
16
17			protected $Currency = "";
18			public function setCurrency($s)
19			{
20			$this->Currency = $s;
21			}
22
23			// DPS Information
24
25			private static $privacy_link = 'http://www.paymentexpress.com/privacypolicy.htm';
			0 ignored issues – show Unused Code introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report The property `$privacy_link` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
26
27			private static $logo = 'payment_dps/images/dps_paymentexpress_small.png';
			0 ignored issues – show Unused Code introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report The property `$logo` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
28
29
30			// URLs
31
32			// Please set from YAML. See _config/payment_dps.yml.example
33			private static $credit_cards = array(
34			/*'Visa' => 'ecommerce/images/paymentmethods/visa.jpg',
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
35			'MasterCard' => 'ecommerce/images/paymentmethods/mastercard.jpg',

sunnysideup / silverstripe-payment_dps

DpsPxPayPayment::processPayment() D last analyzed 2018-05-14 05:39 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

DpsPxPayPayment::processPayment() D
last analyzed 2018-05-14 05:39 UTC