DpsPxPayStoredPayment - Code Metrics - sunnysideup/silverstripe-payment_dps - Measure and Improve Code Quality continuously with Scrutinizer

DpsPxPayStoredPayment B
last analyzed 2018-05-14 05:39 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	270
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	15

Importance

Changes

Metric	Value
dl	0
loc	270
rs	7.7
c	0
b	0
f	0
wmc	38
lcom	2
cbo	15

6 Methods

Rating	Name	Size	Complexity
B	getPaymentFormFields()	39	6
A	autoProcessPayment()	22	1
D	processPayment()	31	10
C	processViaPostRatherThanPxPay()	52	9
C	doPayment()	65	9
B	buildURL()	32	3

<?php

/**
 *@author nicolaas [at] sunny side up. co . nz
 *
 *
 **/


class DpsPxPayStoredPayment extends DpsPxPayPayment
namespace YourVendor;

class YourClass { }
{
    private static $pxaccess_url = 'https://sec.paymentexpress.com/pxpay/pxaccess.aspx';


    private static $pxpost_url = 'https://sec.paymentexpress.com/pxpost.aspx';


    private static $username = '';


    private static $password = '';


    private static $add_card_explanation = "Storing a Card means your Credit Card will be kept on file for your next purchase. ";


    public function getPaymentFormFields()
    {
        $logo = '<img src="' . self::$logo . '" alt="Credit Card Payments Powered by DPS"/>';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $privacyLink = '<a href="' . self::$privacy_link . '" target="_blank" title="Read DPS\'s privacy policy">' . $logo . '</a><br/>';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $paymentsList = '';
        foreach (self::$credit_cards as $name => $image) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $paymentsList .= '<img src="' . $image . '" alt="' . $name . '"/>';
        }

        $fields = new FieldList();
        $storedCards = null;
        if ($m = Member::currentUser()) {
            $storedCards = DpsPxPayStoredCard::get()->filter(array("MemberID" => $m->ID));
        }

        $cardsDropdown = array('' => ' --- Select Stored Card ---');

        if ($storedCards->count()) {
            foreach ($storedCards as $card) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $cardsDropdown[$card->BillingID] = $card->CardHolder.' - '.$card->CardNumber.' ('.$card->CardName.')';
            }
            $s = "";
            if ($storedCards->count()>1) {
                $s = "s";
            }
            $cardsDropdown["deletecards"] = " --- Delete Stored Card$s --- ";
            $fields->push(new DropdownField('DPSUseStoredCard', 'Use a stored card?', $cardsDropdown, $value = $card->BillingID, $form = null, $emptyString = "--- use new Credit Card ---"));
foreach ($a as $b) {
}

// $b is defined here only if $a has elements, for example if $a is array()
// then $b would not be defined here. To avoid that, we recommend to set a
// default value for $b.


// Better
$b = 0; // or whatever default makes sense in your context
foreach ($a as $b) {
}

// $b is now guaranteed to be defined here.
        } else {
            $fields->push(new DropdownField('DPSStoreCard', '', array(1 => 'Store Credit Card', 0 => 'Do NOT Store Credit Card')));
            $fields->push(new LiteralField("AddCardExplanation", "<p>".Config::inst()->get('DpsPxPayStoredPayment', 'add_card_explanation')."</p>"));
        }
        $fields->push(new LiteralField('DPSInfo', $privacyLink));
        $fields->push(new LiteralField('DPSPaymentsList', $paymentsList));
        Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
        //Requirements::block(THIRDPARTY_DIR."/jquery/jquery.js");

        //Requirements::javascript(Director::protocol()."ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js");

        Requirements::javascript("payment_dps/javascript/DpxPxPayStoredPayment.js");
        return $fields;
    }

    public function autoProcessPayment($amount, $ref)
    {
        $DPSUrl = $this->buildURL($amount, $ref, false);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        /*

        add CURL HERE
        $data = array('page' => $page);
        // create our curl object
        $ch = curl_init();
        $lurl = 'http://www.test.com';
        curl_setopt( $ch, CURLOPT_POST, true );
        curl_setopt( $ch, CURLOPT_POSTFIELDS,$data);
        curl_setopt($ch, CURLOPT_URL, $lurl);
        curl_setopt($ch, CURLOPT_FOLLOWLOCATION  ,1);
        curl_setopt($ch, CURLOPT_HEADER, 0);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
        curl_setopt($ch, CURLOPT_CONNECTTIMEOUT, 5);
        curl_setopt($ch, CURLOPT_FAILONERROR, 0);
        $content = curl_exec($ch);
        curl_close($ch);
        return $content;
        */
    }

    /**
     * @param array $data The form request data - see OrderForm
     * @param OrderForm $form The form object submitted on
     *
     * @return EcommercePayment_Result
     */
    public function processPayment($data, $form)
    {
        if (!isset($data["DPSUseStoredCard"])) {
            $data["DPSUseStoredCard"] = null;
        }
        if (!isset($data["DPSStoreCard"])) {
            $data["DPSStoreCard"] = null;
        }
        if (!isset($data["Amount"])) {
            USER_ERROR("There was no amount information for processing the payment.", E_USER_WARNING);
        }
        if ($data["DPSUseStoredCard"] == "deletecards") {
            //important!!!
            $data["DPSUseStoredCard"] = null;
            if ($m = Member::currentUser()) {
                $storedCards = DpsPxPayStoredCard::get()->filter(array("MemberID" => $m->ID));
                if ($storedCards->count()) {
                    foreach ($storedCards as $card) {
                        $card->delete();
                    }
                    if ($storedCards = DpsPxPayStoredCard::get()->filter(array("MemberID" => $m->ID))) {
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                        DB::query("DELETE FROM DpsPxPayStoredCard WHERE MemberID = ".$m->ID);
                    }
                }
            }
        } elseif ($data["DPSUseStoredCard"]) {
            return $this->processViaPostRatherThanPxPay($data, $form, $data["DPSUseStoredCard"]);
        }
        $url = $this->buildURL($data["Amount"], $data["DPSUseStoredCard"], $data["DPSStoreCard"]);
        return $this->executeURL($url);
    }




    public function processViaPostRatherThanPxPay($data, $form, $cardToUse)

    {

        // 1) Main Settings

        $inputs['PostUsername'] = $this->config->get("username");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $inputs['PostPassword'] = $this->config->get("password");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // 2) Payment Informations

        $inputs['Amount'] = $this->Amount->Amount;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $inputs['InputCurrency'] = $this->Amount->Currency;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $inputs['TxnId'] = $this->ID;
        $inputs['TxnType'] = DpsPxPayComs::get_txn_type();
        $inputs["MerchantReference"] = $this->ID;

        // 3) Credit Card Informations
        $inputs["DpsBillingId"] = $cardToUse;


        // 4) DPS Transaction Sending

        $responseFields = $this->doPayment($inputs);
        // 5) DPS Response Management

        if (isset($responseFields['SUCCESS']) && $responseFields['SUCCESS']) {
            $this->Status = 'Success';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $result = EcommercePayment_Success::create();
        } else {
            $this->Status = 'Failure';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $result = EcommercePayment_Failure::create();
        }
        if (isset($responseFields['DPSTXNREF'])) {
            if ($transactionRef = $responseFields['DPSTXNREF']) {
                $this->TxnRef = $transactionRef;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
        }

        if (isset($responseFields['HELPTEXT'])) {
            if ($helpText = $responseFields['HELPTEXT']) {
                $this->Message = $helpText;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
        }
        if (isset($responseFields['RESPONSETEXT'])) {
            if ($responseText = $responseFields['RESPONSETEXT']) {
                $this->Message .= $responseText;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
        }

        $this->write();
        return $result;
    }

    public function doPayment(array $inputs)

    {

        // 1) Transaction Creation
        $transaction = "<Txn>";
        foreach ($inputs as $name => $value) {
            if ($name == "Amount") {
                $value = number_format($value, 2, '.', '');
            }
            $transaction .= "<$name>$value</$name>";
        }
        $transaction .= "</Txn>";

        // 2) CURL Creation
        $clientURL = curl_init();
        curl_setopt($clientURL, CURLOPT_URL, $this->config()-get("pxpost_url"));
        curl_setopt($clientURL, CURLOPT_POST, 1);
        curl_setopt($clientURL, CURLOPT_POSTFIELDS, $transaction);
        curl_setopt($clientURL, CURLOPT_RETURNTRANSFER, 1);
        //curl_setopt($clientURL, CURLOPT_SSLVERSION, 3);


        // 3) CURL Execution

        $resultXml = curl_exec($clientURL);

        // 4) CURL Closing

        curl_close($clientURL);

        // 5) XML Parser Creation

        $xmlParser = xml_parser_create();
        $values = null;
        $indexes = null;
        xml_parse_into_struct($xmlParser, $resultXml, $values, $indexes);
        xml_parser_free($xmlParser);

        // 6) XML Result Parsed In A PHP Array

        $resultPhp = array();
        $level = array();
        foreach ($values as $xmlElement) {
            if ($xmlElement['type'] == 'open') {
                if (array_key_exists('attributes', $xmlElement)) {
                    $arrayValues = array_values($xmlElement['attributes']);
                    list($level[$xmlElement['level']], $extra) = $arrayValues;
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
                } else {
                    $level[$xmlElement['level']] = $xmlElement['tag'];
                }
            } elseif ($xmlElement['type'] == 'complete') {
                $startLevel = 1;
                $phpArray = '$resultPhp';
                while ($startLevel < $xmlElement['level']) {
                    $phpArray .= '[$level['. $startLevel++ .']]';
                }
                $phpArray .= '[$xmlElement[\'tag\']] = array_key_exists(\'value\', $xmlElement)? $xmlElement[\'value\'] : null;';
                eval($phpArray);

            }
        }
        if (!isset($resultPhp['TXN'])) {
            return false;
        }
        $result = $resultPhp['TXN'];
        return $result;
    }



    protected function buildURL($amount, $cardToUse = '', $storeCard = false)

    {
        $commsObject = new DpsPxPayComs();

        /**
        * order details
        **/
        $commsObject->setTxnType(DpsPxPayComs::get_txn_type());
        $commsObject->setMerchantReference($this->ID);
        //replace any character that is NOT [0-9] or dot (.)
        $commsObject->setAmountInput(floatval(preg_replace("/[^0-9\.]/", "", $amount)));

        if (isset($cardToUse)) {
            $commsObject->setBillingId($cardToUse);
        } elseif ($storeCard) {
            $commsObject->setEnableAddBillCard(1);
        }

        /**
        * details of the redirection
        **/
        $link = DpsPxPayStoredPayment_Handler::absolute_complete_link();
        $commsObject->setUrlFail($link);
        $commsObject->setUrlSuccess($link);

        /**
        * process payment data (check if it is OK and go forward if it is...
        **/
        $url = $commsObject->startPaymentProcess();

        return $url;
    }
}


1			<?php
2
3			/**
4			*@author nicolaas [at] sunny side up. co . nz
5			*
6			*
7			**/
8
9
10			class DpsPxPayStoredPayment extends DpsPxPayPayment
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
11			{
12			private static $pxaccess_url = 'https://sec.paymentexpress.com/pxpay/pxaccess.aspx';
			0 ignored issues – show Unused Code introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report The property `$pxaccess_url` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
13
14			private static $pxpost_url = 'https://sec.paymentexpress.com/pxpost.aspx';
			0 ignored issues – show Unused Code introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report The property `$pxpost_url` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
15
16			private static $username = '';
			0 ignored issues – show Unused Code introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report The property `$username` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
17
18			private static $password = '';
			0 ignored issues – show Unused Code introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report The property `$password` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
19
20			private static $add_card_explanation = "Storing a Card means your Credit Card will be kept on file for your next purchase. ";
			0 ignored issues – show Unused Code introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report The property `$add_card_explanation` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
21
22			public function getPaymentFormFields()
23			{
24			$logo = '<img src="' . self::$logo . '" alt="Credit Card Payments Powered by DPS"/>';
			0 ignored issues – show Documentation introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report The property `$logo` is declared private in `DpsPxPayPayment`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
25			$privacyLink = '<a href="' . self::$privacy_link . '" target="_blank" title="Read DPS\'s privacy policy">' . $logo . '</a><br/>';
			0 ignored issues – show Documentation introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report The property `$privacy_link` is declared private in `DpsPxPayPayment`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
26			$paymentsList = '';
27			foreach (self::$credit_cards as $name => $image) {
			0 ignored issues – show Documentation introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report The property `$credit_cards` is declared private in `DpsPxPayPayment`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
28			$paymentsList .= '<img src="' . $image . '" alt="' . $name . '"/>';
29			}
30
31			$fields = new FieldList();

sunnysideup / silverstripe-payment_dps

DpsPxPayStoredPayment B last analyzed 2018-05-14 05:39 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

Duplication Side-by-Side

Filter issues like

DpsPxPayStoredPayment B
last analyzed 2018-05-14 05:39 UTC