DpsPxPayStoredCard

Complexity

Total Complexity

8

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	canCreate()	0	4	1
A	canView()	0	13	4
A	canEdit()	0	4	1
A	canDelete()	0	8	2

<?php

class DpsPxPayStoredCard extends DataObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'CardName' => 'Varchar',
        'CardHolder' => 'Varchar',
        'CardNumber' => 'Varchar',
        'BillingID' => 'Varchar'
    );

    private static $has_one = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        'Member' => 'Member'
    );

    private static $searchable_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $searchable_fields is not used and could be removed.

        'CardHolder' => 'PartialMatchFilter',
        'CardNumber' => 'PartialMatchFilter'
    );

    //database related settings
    private static $field_labels = array(

Consider using a different property name as you override a private property of the parent class.

The property $field_labels is not used and could be removed.

        'CardName' => 'Card Name',
        'CardHolder' => 'Card Holder',
        'CardNumber' => 'Card Number',
        'MemberID' => 'Card Owner'
    );
    private static $summary_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $summary_fields is not used and could be removed.

        'CardName' => 'Card Name',
        'CardHolder' => 'Card Holder',
        'CardNumber' => 'Card Number',
        'Member.Title' => 'Card Owner'
    );

    private static $singular_name = "DPS PX Pay Stored Card";

Consider using a different property name as you override a private property of the parent class.

The property $singular_name is not used and could be removed.

    private static $plural_name = "DPS PX Pay Stored Cards";

Consider using a different property name as you override a private property of the parent class.

The property $plural_name is not used and could be removed.

    private static $default_sort = "Created DESC";

Consider using a different property name as you override a private property of the parent class.

The property $default_sort is not used and could be removed.

    private static $defaults = array();//use fieldName => Default Value

Consider using a different property name as you override a private property of the parent class.

The property $defaults is not used and could be removed.

    private static $can_create = false;

The property $can_create is not used and could be removed.

    public function canCreate($member = null)
    {
        return false;
    }

    public function canView($member = null)

The return type could not be reliably inferred; please add a @return annotation.

    {
        if (!$member) {
            $member = Member::currentUser();
        }
        $extended = $this->extendedCan(__FUNCTION__, $member);
        if ($extended !== null) {
            return $extended;
        }
        if ($member) {
            return $member->IsAdmin();
        }
    }

    public function canEdit($member = null)
    {
        return false;
    }

    public function canDelete($member = null)

The return type could not be reliably inferred; please add a @return annotation.

    {
        $extended = $this->extendedCan(__FUNCTION__, $member);
        if ($extended !== null) {
            return $extended;
        }
        return $this->canView($member = null);
    }
}