DpsPxPayPayment_Handler

Complexity

Total Complexity

7

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	9

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	complete_link()	0	4	1
A	absolute_complete_link()	0	4	1
B	paid()	0	25	5

<?php


class DpsPxPayPayment_Handler extends Controller

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        "complete_link",
        "absolute_complete_link",
        "paid"
    );

    private static $url_segment = 'dpspxpaypayment';

The property $url_segment is not used and could be removed.

    public static function complete_link()
    {
        return Config::inst()->get('DpsPxPayPayment_Handler', 'url_segment') . '/paid/';
    }

    public static function absolute_complete_link()
    {
        return Director::AbsoluteURL(self::complete_link());
    }

    public function paid()
    {
        EcommercePayment::get_supported_methods();
        $this->extend("DpsPxPayPayment_Handler_completion_start");
        $commsObject = new DpsPxPayComs();
        $response = $commsObject->processRequestAndReturnResultsAsObject();
        if ($payment = DpsPxPayPayment::get()->byID($response->getMerchantReference())) {
            if (1 == $response->getSuccess()) {
                $payment->Status = 'Success';
            } else {
                $payment->Status = 'Failure';
            }
            if ($DpsTxnRef = $response->getDpsTxnRef()) {
                $payment->TxnRef = $DpsTxnRef;
            }
            if ($ResponseText = $response->getResponseText()) {
                $payment->Message = $ResponseText;
            }
            $payment->write();
            $payment->redirectToOrder();
        } else {
            USER_ERROR("could not find payment with matching ID", E_USER_WARNING);
        }
        return;
    }
}