Issues in DirectCreditPayment.php (master) - Issues in master - sunnysideup/silverstripe-payment_directcredit - Measure and Improve Code Quality continuously with Scrutinizer

Issues (41)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/DirectCreditPayment.php (39 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Payment object representing a DirectCredit payment.
 * @author Nicolaas [at] sunnysideup.co.nz
 * @package payment
 */
class DirectCreditPayment extends EcommercePayment
namespace YourVendor;

class YourClass { }
{

    /**
     * Message shown before payment is made
     * @var String
     */
    private static $before_payment_message = "";


    /**
     * Message shown after payment is made
     * @var String
     */
    private static $after_payment_message = "";


    /**
     * Default Status for Payment
     * @var String
     */
    private static $default_status = "Pending";



    /**
     * Process the DirectCredit payment method
     */
    public function processPayment($data, $form)
    {
        $this->Status = Config::inst()->get("DirectCreditPayment", "default_status");

        $this->Message = Config::inst()->get("DirectCreditPayment", "after_payment_message");

        $this->write();
        return EcommercePayment_Success::create();
    }

    public function getPaymentFormFields()
    {
        return new FieldList(
            new LiteralField($this->ClassName.'_BeforeMessage', '<div id="'.$this->ClassName.'_BeforeMessage">' . Config::inst()->get("DirectCreditPayment", "before_payment_message") . '</div>'),
            new HiddenField($this->ClassName, $this->ClassName, 0)
        );
    }

    public function getPaymentFormRequirements()
    {
        return null;
    }
}

class DirectCreditPayment_ViaCreditCart extends EcommercePayment
namespace YourVendor;

class YourClass { }
{

    /**
     * Message shown before payment is made
     * @var String
     */
    private static $before_payment_message = "";


    /**
     * Message shown after payment is made
     * @var String
     */
    private static $after_payment_message = "";


    /**
     * Default Status for Payment
     * @var String
     */
    private static $default_status = "Pending";


    /**
     * Process the DirectCredit payment method
     */
    public function processPayment($data, $form)
    {
        $this->Status = Config::inst()->get("DirectCreditPayment_ViaCreditCart", "default_status");

        $this->Message = Config::inst()->get("DirectCreditPayment_ViaCreditCart", "after_payment_message");

        $this->write();
        return EcommercePayment_Success::create();
    }

    public function getPaymentFormFields()
    {
        return new FieldList(
            new LiteralField($this->ClassName.'_BeforeMessage', '<div id="'.$this->ClassName.'_BeforeMessage">' . Config::inst()->get("DirectCreditPayment_ViaCreditCart", "before_payment_message") . '</div>'),
            new HiddenField($this->ClassName, $this->ClassName, 0)
        );
    }

    public function getPaymentFormRequirements()
    {
        return null;
    }
}

class DirectCreditPayment_ViaCheque extends EcommercePayment
namespace YourVendor;

class YourClass { }
{

    /**
     * Message shown before payment is made
     * @var String
     */
    private static $before_payment_message = "";


    /**
     * Message shown after payment is made
     * @var String
     */
    private static $after_payment_message = "";


    /**
     * Default Status for Payment
     * @var String
     */
    private static $default_status = "Pending";


    /**
     * Process the DirectCredit payment method
     */
    public function processPayment($data, $form)
    {
        $this->Status = Config::inst()->get("DirectCreditPayment_ViaCheque", "default_status");

        $this->Message = Config::inst()->get("DirectCreditPayment_ViaCheque", "after_payment_message");

        $this->write();
        return EcommercePayment_Success::create();
    }

    public function getPaymentFormFields()
    {
        return new FieldList(
            new LiteralField($this->ClassName.'_BeforeMessage', '<div id="'.$this->ClassName.'_BeforeMessage">' . Config::inst()->get("DirectCreditPayment_ViaCheque", "before_payment_message") . '</div>'),
            new HiddenField($this->ClassName, $this->ClassName, 0)
        );
    }

    public function getPaymentFormRequirements()
    {
        return null;
    }
}

class DirectCreditPayment_TESTSUCCESS extends EcommercePayment
namespace YourVendor;

class YourClass { }
{

    /**
     * Message shown before payment is made
     * @var String
     */
    private static $before_payment_message = "This is for testing purposes only";


    /**
     * Message shown after payment is made
     * @var String
     */
    private static $after_payment_message = "Payment is always successful";


    /**
     * Default Status for Payment
     * @var String
     */
    private static $default_status = "Success";


    /**
     * Process the DirectCredit payment method
     */
    public function processPayment($data, $form)
    {
        $this->Status = Config::inst()->get("DirectCreditPayment_TESTSUCCESS", "default_status");

        $this->Message = Config::inst()->get("DirectCreditPayment_TESTSUCCESS", "after_payment_message");

        $this->write();
        return EcommercePayment_Success::create();
    }

    public function getPaymentFormFields()
    {
        return new FieldList(
            new LiteralField($this->ClassName.'_BeforeMessage', '<div id="'.$this->ClassName.'_BeforeMessage">' . Config::inst()->get("DirectCreditPayment_TESTSUCCESS", "before_payment_message") . '</div>'),
            new HiddenField($this->ClassName, $this->ClassName, 0)
        );
    }

    public function getPaymentFormRequirements()
    {
        return null;
    }
}


class DirectCreditPayment_TESTFAILURE extends EcommercePayment
namespace YourVendor;

class YourClass { }
{

    /**
     * Message shown before payment is made
     * @var String
     */
    private static $before_payment_message = "This is for testing purposes only";


    /**
     * Message shown after payment is made
     * @var String
     */
    private static $after_payment_message = "Payment is always unsuccessful";


    /**
     * Default Status for Payment
     * @var String
     */
    private static $default_status = "Failure";


    /**
     * Process the DirectCredit payment method
     */
    public function processPayment($data, $form)
    {
        $this->Status = Config::inst()->get("DirectCreditPayment_TESTFAILURE", "default_status");

        $this->Message = Config::inst()->get("DirectCreditPayment_TESTFAILURE", "after_payment_message");

        $this->write();
        return EcommercePayment_Success::create();
    }

    public function getPaymentFormFields()
    {
        return new FieldList(
            new LiteralField($this->ClassName.'_BeforeMessage', '<div id="'.$this->ClassName.'_BeforeMessage">' . Config::inst()->get("DirectCreditPayment_TESTFAILURE", "before_payment_message") . '</div>'),
            new HiddenField($this->ClassName, $this->ClassName, 0)
        );
    }

    public function getPaymentFormRequirements()
    {
        return null;
    }
}


1		<?php
2
3		/**
4		* Payment object representing a DirectCredit payment.
5		* @author Nicolaas [at] sunnysideup.co.nz
6		* @package payment
7		*/
8	View Code Duplication	class DirectCreditPayment extends EcommercePayment
		0 ignored issues – show Duplication introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style Compatibility introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9		{
10
11		/**
12		* Message shown before payment is made
13		* @var String
14		*/
15		private static $before_payment_message = "";
		0 ignored issues – show Unused Code introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$before_payment_message` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
16
17		/**
18		* Message shown after payment is made
19		* @var String
20		*/
21		private static $after_payment_message = "";
		0 ignored issues – show Unused Code introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$after_payment_message` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
22
23		/**
24		* Default Status for Payment
25		* @var String
26		*/
27		private static $default_status = "Pending";
		0 ignored issues – show Unused Code introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$default_status` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
28
29
30		/**
31		* Process the DirectCredit payment method
32		*/
33		public function processPayment($data, $form)
34		{
35		$this->Status = Config::inst()->get("DirectCreditPayment", "default_status");
		0 ignored issues – show Bug introduced 2017-01-03 01:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Status` does not seem to exist. Did you mean `default_status`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...

sunnysideup / silverstripe-payment_directcredit

Issues (41)

Security Analysis no request data

code/DirectCreditPayment.php (39 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like