Sunnysideup\PasswordSaver\Model\Fields\DBClientSidePassword

Complexity

Total Complexity

16

Size/Duplication

Total Lines	95
Duplicated Lines	0 %

Importance

Changes	10
Bugs	1	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	saveInto()	0	17	5
A	formInner()	0	6	1
A	__construct()	0	6	2
A	Nice()	0	3	1
A	forTemplate()	0	7	2
A	scaffoldFormField()	0	3	1
A	FormGet()	0	3	1
A	FormSet()	0	3	1
A	get_unique_value()	0	7	2

<?php

namespace Sunnysideup\PasswordSaver\Model\Fields;

use SilverStripe\ORM\DataObject;
use SilverStripe\ORM\FieldType\DBVarchar;
use Sunnysideup\PasswordSaver\Form\ClientSidePasswordField;
use Sunnysideup\UUDI\Api\HashCreator;

The type Sunnysideup\UUDI\Api\HashCreator was not found. Maybe you did not declare it correctly or list all dependencies?

class DBClientSidePassword extends DBVarchar
{
    protected $fieldLength = 7;

    private static $casting = [
        'FormGet' => 'HTMLText',
        'FormSet' => 'HTMLText',
    ];

    public function __construct($name = null, $size = 7, $options = [])
    {
        if ((int) $size) {
            $this->fieldLength = (int) $size;
        }
        parent::__construct($name, $size, $options);
    }

    public static function get_unique_value(?int $size = 7): string
    {
        if (! $size) {

The expression $size of type integer|null is loosely compared to false; this is ambiguous if the integer can be 0. You might want to explicitly use === null instead.

            $size = 7;
        }

        return HashCreator::generate_hash($size);
    }

    /**
     * Remove ugly parts of a url to make it nice.
     */
    public function Nice()
    {
        return $this->value;
    }

    /**
     * Scaffold the ExternalURLField for this ExternalURL.
     *
     * @param null|mixed $title
     * @param null|mixed $params
     */
    public function scaffoldFormField($title = null, $params = null)
    {
        return new ClientSidePasswordField($this->name, $title);
    }

    public function forTemplate()
    {
        if ($this->value) {
            return $this->Nice();
        }

        return '(no code available)';
    }

    /**
     * Saves this field to the given data object.
     *
     * @param DataObject $dataObject
     */
    public function saveInto($dataObject)
    {
        $fieldName = $this->name;
        if (empty($fieldName)) {
            throw new \BadMethodCallException(
                "DBField::saveInto() Called on a nameless '" . static::class . "' object"
            );
        }
        if (! $dataObject->{$fieldName}) {
            $dataObject->{$fieldName} = self::get_unique_value($this->fieldLength);
        }
        $length = strlen($dataObject->{$fieldName});
        if ($length < $this->fieldLength) {
            $dataObject->{$fieldName} .= self::get_unique_value($this->fieldLength - $length);
        }
        if ($length > $this->fieldLength) {
            $dataObject->{$fieldName} = substr($dataObject->{$fieldName}, 0, $this->fieldLength);
        }
    }

    public function FormGet(string $link, ?string $name = 'get'): string
    {
        return $this->formInner($link, $name);

It seems like $name can also be of type null; however, parameter $name of Sunnysideup\PasswordSaver\Model\Fields\DBClientSidePassword::formInner() does only seem to accept string, maybe add an additional type check?

    }

    public function FormSet(string $link, ?string $name = 'set'): string
    {
        return $this->formInner($link, $name);

It seems like $name can also be of type null; however, parameter $name of Sunnysideup\PasswordSaver\Model\Fields\DBClientSidePassword::formInner() does only seem to accept string, maybe add an additional type check?

    }

    protected function formInner(string $link, string $name): string
    {
        return '
            <form method="post" action="' . $link . '" class="password-getter-setter-form" formtarget="_blank" target="_blank" rel="noreferrer noopener">
                <input type="hidden" value="' . $this->value . '" name="Code" />
                <button type="submit" />' . $name . '</button>
            </form>
        ';
    }
}