Issues in PageRowPageExtension.php (master) - Issues in master - sunnysideup/silverstripe-pagerows - Measure and Improve Code Quality continuously with Scrutinizer

Issues (136)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/PageRowPageExtension.php (28 issues)

Labels

Severity

Nicolaas Thiemen Francken @ B&C 28

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class PageRowPageExtension extends SiteTreeExtension
namespace YourVendor;

class YourClass { }
{


    private static $many_many = [

        'PageRows' => 'PageRow'
    ];

    private static $many_many_extraFields = [

        'PageRows' => [
            'SortOrder' => 'Int'
        ]
    ];

    public function PageRows()

    {
        return $this->getPageRows();
    }

    public function getPageRows()

    {
        return $this->owner->getManyManyComponents('PageRows')->sort(['SortOrder' => 'ASC']);
    }

    #######################
    ### Further DB Field Details
    #######################

    #######################
    ### Field Names and Presentation Section
    #######################

    private static $field_labels = [

        'PageRows' => 'Content Blocks'
    ];

    private static $field_labels_right = [

        'PageRows' => 'Please edit with care! You can add content blocks that are not ready for publication, but they will not be visible until they are ticked as available.',
    ];


    #######################
    ### Casting Section
    #######################


    #######################
    ### can Section
    #######################



    #######################
    ### write Section
    #######################



    public function onAfterWrite()
    {
        if (Security::database_is_ready()  && $this->owner->HasPageRows()) {
            // debug::Log('-------------------------');

            $currentPageRows = [];
            if ($this->owner->PageRows()->count() > 0) {
                $sortOrder = 1;
                foreach ($this->owner->PageRows() as $pageRow) {
                    $currentPageRows[$sortOrder] = $pageRow;
                    $sortOrder++;
                }
            }
            $rowClassNames = $this->owner->DefaultPageRows();
            $sortOrder = 1;
            foreach ($rowClassNames as $className) {
                $childClassName = null;
                if (is_array($className)) {
                    $childClassName = $className['Child'];
                    // debug::log($childClassName);

                    $className = $className['Parent'];
                }
                if (isset($currentPageRows[$sortOrder])) {
                    $row = $currentPageRows[$sortOrder];
                    if ($row->ClassName === $className) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                        //all OK!
                    } else {
if (rand(1, 6) > 3) {
print "Check failed";
} else {
    //print "Check succeeded";
}
                        // $this->owner->removePageRowFromThisPage($row);

                        //we do not delete the row as it may be used somewhere else ...
                        // $this->owner->deletePageRowFromMe($row);

                    }
                } else {
                    $row = $className::create();
                    $row->Title = 'Title '.$row->singular_name().' #'.$className::get()->count().' for '.$this->owner->MenuTitle;
                    $row->write();
                    $this->owner->PageRows()->add($row, ['SortOrder' => $sortOrder]);
                    $currentPageRows[$sortOrder] = $row;
                }
                DB::query('
                    UPDATE "Page_PageRows"
                    SET "SortOrder" = '.$sortOrder.'
                    WHERE
                        "PageID" ='.$this->owner->ID.' AND
                        "PageRowID" = '.$row->ID.'
                    LIMIT 1;
                ');
                if ($childClassName) {
                    $childClassMethod = $row->ChildClassMethodName();
                    if ($childClassMethod) {
                        $child = $row->$childClassMethod();
                        if ($child && $child->exists()) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                        } else {
                            $childClassMethodFieldName = $childClassMethod.'ID';
                            $child = $childClassName::create();
                            $child->Title = 'New '.$child->singular_name().' for '.$row->getTitle();
                            $child->write();
                            // debug::log($childClassMethodFieldName);

                            // debug::log($child->ID);

                            // debug::log($child->Title);

                            $row->$childClassMethodFieldName = $child->ID;
                            $row->write();
                        }
                    } else {
                        user_error('no childclass method set in '.$row->ClassName);
                    }
                }
                $sortOrder++;
            }
            $sortOrder = 1;
            foreach ($this->owner->PageRows() as $pageRow) {
                $sortOrder++;
                $delete = false;
                if (!isset($rowClassNames[$sortOrder])) {
                    $delete = true;
                } elseif ($rowClassNames[$sortOrder] !== $pageRow->ClassName) {
                    $delete = true;
                }
                if ($delete) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                    // $this->owner->removePageRowFromThisPage($pageRow);

                }
            }
        }
    }

    protected function removePageRowFromThisPage($rowOrRowID)
    {
        if ($rowOrRowID instanceof PageRow) {
            $rowOrRowID = $rowOrRowID->ID;
        }
        DB::query('
            DELETE
            FROM "Page_PageRows"
            WHERE
                "PageID" ='.$this->owner->ID.' AND
                "PageRowID" = '.$rowOrRowID.'
            LIMIT 1;
        ');
    }


    public function DefaultPageRows()

    {
        if($this->owner->hasMethod('MyDefaultPageRows')) {
            return $this->owner->MyDefaultPageRows();
        }
        return [];
    }

    #######################
    ### Import / Export Section
    #######################



    #######################
    ### CMS Edit Section
    #######################

    /**
     * Update Fields
     * @return FieldList

     */
    public function updateCMSFields(FieldList $fields)
    {
        $list = $this->owner->PageRows();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if($this->owner->canEdit() && $this->owner->exists() && $this->HasPageRows()) {
            $fields->addFieldsToTab(
                'Root.ContentBlocks',
                $this->owner->ContentBlocksFields()
            );
        }
    }

    public function ContentBlocksFields()
    {
        $conf = GridFieldConfig_RelationEditor::create(100);
        $conf->addComponent(new GridFieldSortableRows('SortOrder'));
        // switch ($this->owner->ClassName) {

        //     case 'HomePage':
        //         // leave as is ...
        //         $conf->removeComponentsByType('GridFieldAddExistingAutocompleter');

        //         $conf->removeComponentsByType('GridFieldDeleteAction');

        //         $conf->removeComponentsByType('GridFieldAddNewButton');

        //         break;
        //     default:
        // }
        //
        $conf->getComponentByType('GridFieldAddExistingAutocompleter')->setSearchFields(['Code', 'Title']);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $pageRowField = GridField::create(
            'PageRows',
            'Content Blocks',
            $this->owner->PageRows(),
            $conf
        );
        $array = [$pageRowField];
        $arrayRowList = [];
        foreach ($this->owner->DefaultPageRows() as $count => $className) {
            if (is_array($className)) {
                $className = $className['Parent'];
            }
            $humanCount = $count + 1;
            $arrayRowList[$className.'_'.$count] = $humanCount . ' - '.Injector::inst()->get($className)->singular_name().' ('.$className.')';
        }
        if(count($arrayRowList)) {
            $array[] = LiteralField::create(
                'ListOfContentBlocks',
                '<h2>By default, this page type ('.$this->owner->singular_name().') has the following content blocks:</h2><p>'.implode('</p><p>', $arrayRowList).'</p>'
            );
        }

        return $array;
    }

    public function HasPageRows()

    {
        switch($this->owner->ClassName) {
            case 'ErrorPage':
            case 'RedirectorPage':
            case 'VirtualPage':
                return false;
        }
        if($this->owner->hasMethod('MyHasPageRows')) {
            return $this->owner->MyHasPageRows();
        }
        return true;
    }

}


Issues (136)

Security Analysis not enabled

code/PageRowPageExtension.php (28 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

1			<?php
2
3			class PageRowPageExtension extends SiteTreeExtension
			0 ignored issues – show Coding Style Compatibility introduced 2018-05-02 23:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5
6
7			private static $many_many = [
			0 ignored issues – show Unused Code introduced 2018-05-02 23:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$many_many` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
8			'PageRows' => 'PageRow'
9			];
10
11			private static $many_many_extraFields = [
			0 ignored issues – show Unused Code introduced 2018-05-02 23:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$many_many_extraFields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
12			'PageRows' => [
13			'SortOrder' => 'Int'
14			]
15			];
16
17			public function PageRows()
			0 ignored issues – show Documentation introduced 2018-05-02 23:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
18			{
19			return $this->getPageRows();
20			}
21
22			public function getPageRows()
			0 ignored issues – show Documentation introduced 2018-05-02 23:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
23			{
24			return $this->owner->getManyManyComponents('PageRows')->sort(['SortOrder' => 'ASC']);
25			}
26
27			#######################
28			### Further DB Field Details
29			#######################
30
31			#######################
32			### Field Names and Presentation Section
33			#######################
34
35			private static $field_labels = [

sunnysideup / silverstripe-pagerows

Issues (136)

Security Analysis not enabled

code/PageRowPageExtension.php (28 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like