PageNotFound_Controller

Complexity

Total Complexity

6

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	set_old_to_new_array()	0	4	1
B	init()	0	18	5

<?php
/**
 * ErrorPage holds the content for the page of an error response.
 * Renders the page on each publish action into a static HTML file
 * within the assets directory, after the naming convention
 * /assets/error-<statuscode>.html.
 * This enables us to show errors even if PHP experiences a recoverable error.
 * ErrorPages
 *
 * @see Debug::friendlyError()
 *
 * @package cms
 */
class PageNotFound extends ErrorPage

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public static $icon = "mysite/images/treeIcons/PageNotFound";

    public static $hide_ancestor = "ErrorPage";

    public function doPublish()
    {
        parent::doPublish();
    }
}
/**
 * Controller for ErrorPages.
 * @package cms
 */
class PageNotFound_Controller extends ErrorPage_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $old_to_new_array = array();

    public static function set_old_to_new_array(array $a)
    {
        self::$old_to_new_array = $a;
    }

    public function init()
    {
        parent::init();
        $bt = defined('DB::USE_ANSI_SQL') ? "\"" : "`";

$bt is not used, you could remove the assignment.

        $page = null;

$page is not used, you could remove the assignment.

        //NOTE: this function (Director::urlParam) is depreciated, but should actuall be kept
        $URLSegment = Director::urlParam("URLSegment");

The method Director::urlParam() has been deprecated with message: 3.0 Use SS_HTTPRequest->latestParam()

        $Action = Director::urlParam("Action");

The method Director::urlParam() has been deprecated with message: 3.0 Use SS_HTTPRequest->latestParam()

        foreach (self::$old_to_new_array as $oldURL => $newURL) {
            if ($URLSegment == $oldURL) {
                $page = DataObject::get_one("SiteTree", "URLSegment = '$newURL'");
                Director::redirect($page->Link(), 301);
            } elseif ($URLSegment."/".$Action == $oldURL) {
                $page = DataObject::get_one("SiteTree", "URLSegment = '$newURL'");
                Director::redirect($page->Link(), 301);
            }
        }
    }
}