EmogrifierMailer::sendHTML() - Code Metrics - sunnysideup/silverstripe-newsletter_emogrify - Measure and Improve Code Quality continuously with Scrutinizer

EmogrifierMailer::sendHTML() A
last analyzed 2018-03-20 01:22 UTC

↳ Parent: EmogrifierMailer

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	7

<?php

class EmogrifierMailer extends Mailer
namespace YourVendor;

class YourClass { }
{
    private static $css_file = '';


    public function sendHTML($to, $from, $subject, $htmlContent, $attachedFiles = false, $customheaders = false, $plainContent = false)
    {
        $cssFileLocation = Director::baseFolder() . Config::inst()->get("EmogrifierMailer", "css_file");
        $cssFileHandler = fopen($cssFileLocation, 'r');
        $css = fread($cssFileHandler,  filesize($cssFileLocation));
        fclose($cssFileHandler);
        $emog = new \Pelago\Emogrifier($htmlContent, $css);
        $htmlContent = $emog->emogrify();
        return parent::sendHTML($to, $from, $subject, $htmlContent, $attachedFiles, $customheaders, $plainContent);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			class EmogrifierMailer extends Mailer
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:24 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			private static $css_file = '';
			0 ignored issues – show Unused Code introduced 2017-01-03 01:24 UTC by Report Bug Copy Issue Report The property `$css_file` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
6
7			public function sendHTML($to, $from, $subject, $htmlContent, $attachedFiles = false, $customheaders = false, $plainContent = false)
8			{
9			$cssFileLocation = Director::baseFolder() . Config::inst()->get("EmogrifierMailer", "css_file");
10			$cssFileHandler = fopen($cssFileLocation, 'r');
11			$css = fread($cssFileHandler, filesize($cssFileLocation));
12			fclose($cssFileHandler);
13			$emog = new \Pelago\Emogrifier($htmlContent, $css);
14			$htmlContent = $emog->emogrify();
15			return parent::sendHTML($to, $from, $subject, $htmlContent, $attachedFiles, $customheaders, $plainContent);
			0 ignored issues – show Documentation introduced 2017-01-03 01:24 UTC by Report Bug Copy Issue Report `$attachedFiles` is of type `boolean`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2017-01-03 01:24 UTC by Report Bug Copy Issue Report `$customheaders` is of type `boolean`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2017-01-03 01:24 UTC by Report Bug Copy Issue Report `$plainContent` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
16			}
17			}
18

sunnysideup / silverstripe-newsletter_emogrify

EmogrifierMailer::sendHTML() A last analyzed 2018-03-20 01:22 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

EmogrifierMailer::sendHTML() A
last analyzed 2018-03-20 01:22 UTC