sunnysideup / silverstripe-modulechecks

code/api/RunCommandLineMethodOnModule.php

<?php

abstract class RunCommandLineMethodOnModule extends Object
{

      /**
       * root dir for module
       * e.g. /var/www/modules/mymodule
       * no final slash
       *
       * @var string
       */
    protected $rootDirForModule = '';

    /**
     *
     * @var string
     */
    protected $commands = [];

    public function setRootDirForModule($rootDirForModule)
    {
        $this->$rootDirForModule = $rootDirForModule;
    }

    /**
     *
     *
     * @param string
     */
    public function setCommand(array $commands)
    {
        $this->commands = $commands;

It seems like $commands of type array is incompatible with the declared type string of property $commands.

        return $this;
    }

    /**
     *
     *
     * @param string
     */
    public function addCommands(string $command)
    {
        $this->commands[] = $command;

        return $this;
    }

    public function __construct($rootDirForModule = '')
    {
        $this->rootDirForModule = $rootDirForModule;
    }

    public function run()
    {
        if (! $this->rootDirForModule) {
            user_error('no root dir for module has been set');
        }
        if (! count($this->commands)) {

$this->commands of type string is incompatible with the type Countable|array expected by parameter $var of count().

            user_error('command not set');
        }
        $this->runCommand();
    }

    /**
     * runs a command from the root dir or the module
     */
    protected function runCommand()
    {
        foreach($this->commands as $command) {

The expression $this->commands of type string is not traversable.

            GeneralMethods::output_to_screen('Running ' . $command);
            return exec(
              ' cd '.$this->rootDirForModule.';
                '.$command.'
                '
            );
        }
    }

    public static function CheckCommandExists($cmd)
    {
        return !empty(shell_exec("which $cmd"));
    }
}