sunnysideup / silverstripe-modulechecks

code/api/GeneralMethods.php

<?php


class GeneralMethods extends Object
{


    /**
     * opens a location with curl to see if it exists.
     *
     * @param string $url
     *
     * @return boolean
     */
    public static function check_location($url)
    {
        $handle = curl_init($url);
        curl_setopt($handle, CURLOPT_RETURNTRANSFER, true);

It seems like $handle can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        curl_setopt($handle, CURLOPT_CONNECTTIMEOUT, true);
        $response = curl_exec($handle);

The assignment to $response is dead and can be removed.

It seems like $handle can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        $httpCode = curl_getinfo($handle, CURLINFO_HTTP_CODE);

It seems like $handle can also be of type false; however, parameter $ch of curl_getinfo() does only seem to accept resource, maybe add an additional type check?

        $outcome = $httpCode == 200;
        curl_close($handle);

It seems like $handle can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

        return $outcome;
    }



    /**
     *
     * @use
     * ```
     *    GeneralMethods::output_to_screen('asdf', 'created')
     * ```
     * @see DB::alteration_message for types...
     *
     * @param  string $message
     * @param  string $type
     */
    public static function output_to_screen($message, $type = "")
    {
        if (Director::is_cli()) {
            DB::alteration_message($message, $type);
        } else {
            echo "<br />";
            flush();
            ob_end_flush();
            DB::alteration_message($message, $type);
            ob_start();
        }
    }

    /*
     * Recursively removes a directory
     *
     * @param  string $path
     */

    public static function removeDirectory($path)
    {
        FileSystem::removeFolder($path);
    }

    /*
     * Replaces all instances of a string in a file, and rewrites the file
     *
     * @param string $fileName
     * @param string $search
     * @param string $replacement
     *
     **/
    public static function replaceInFile($fileName, $search, $replacement)
    {
        $file = fopen($fileName, 'r');
        if ($file) {

$file is of type false|resource, thus it always evaluated to false.

            $content = fread($file, filesize($fileName) * 2);
            $newContent = str_replace($search, $replacement, $content);
            fclose($file);


            $file = fopen($fileName, 'w');
            if ($file) {
                fwrite($file, $newContent);
                fclose($file);
            }
        }
    }
}