+global\GitRepoFinder::get_repos_with_auth()

Complexity

Conditions	20
Paths	23

Size

Total Lines

116

Duplication

Lines	9
Ratio	7.76 %

Importance

Changes

0

<?php
    public static function get_repos_with_auth($username = '', $getNamesWithPrefix = false)
    {
        $preSelected = Config::inst()->get('UpdateModules', 'modules_to_update');
        if (is_array($preSelected) && count($preSelected)) {
            self::$_modules = $preSelected;

It seems like $preSelected of type array is incompatible with the declared type string of property $_modules.

        } else {
            if ($username) {
                $gitUserName = $username;
            } else {
                $gitUserName = Config::inst()->get('GitHubModule', "github_user_name");
            }
            print "<li>Retrieving List of modules from GitHub for user $username ... </li>";
            if (! count(self::$_modules)) {

self::_modules of type string is incompatible with the type Countable|array expected by parameter $var of count().

                $url = 'https://api.github.com/users/' . trim($gitUserName) . '/repos';
                $array  = array();
                for ($page = 0; $page < 10; $page++) {
                    $data = array(
                        'per_page' => 100,
                        'page'=>$page
                    );

                    $method = 'GET';
                    $ch = curl_init($url);
                    $header = "Content-Type: application/json";

                    if ($method == 'GET') {
                        $url .= '?'.http_build_query($data);
                    }

                    $gitApiUserName = trim(GitHubModule::Config()->get('git_api_login_username'));

It seems like GitHubModule::Config()->get('git_api_login_username') can also be of type array; however, parameter $str of trim() does only seem to accept string, maybe add an additional type check?

                    $gitUserName = trim(GitHubModule::Config()->get('github_user_name'));
                    $gitApiUserPassword = trim(GitHubModule::Config()->get('git_api_login_password'));

                    $gitApiAccessToken = trim(GitHubModule::Config()->get('git_personal_access_token'));
                    if (trim($gitApiAccessToken)) {
                        $gitApiUserPassword = $gitApiAccessToken;
                    }


                    curl_setopt($ch, CURLOPT_VERBOSE, 1);

It seems like $ch can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

                    curl_setopt($ch, CURLOPT_URL, $url);
                    curl_setopt($ch, CURLOPT_CUSTOMREQUEST, $method);
                    curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
                    curl_setopt($ch, CURLOPT_HTTPHEADER, array($header));
                    curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
                    curl_setopt(
                        $ch,
                        CURLOPT_USERAGENT,
                        'sunnysideupdevs'
                    );


                    if (isset($gitApiUserName) && isset($gitApiUserPassword)) {
                        curl_setopt($ch, CURLOPT_USERPWD, $gitApiUserName . ':' . $gitApiUserPassword);
                        curl_setopt($ch, CURLOPT_HTTPAUTH, CURLAUTH_BASIC);
                    }


                    $curlResult = curl_exec($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

                    if (! $curlResult) {
                        GeneralMethods::output_to_screen('Could not retrieve list of modules from GitHub');

                        UpdateModules::$unsolvedItems["all"] =  ('Could not retrieve list of modules from GitHub');
                        die('');

Using exit here is not recommended.

                    }

                    $array = array_merge($array, json_decode($curlResult));

It seems like $curlResult can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

                }


                $modules = array();

                if (count($array) > 0) {
                    foreach ($array as $repo) {

                        // see http://stackoverflow.com/questions/4345554/convert-php-object-to-associative-array
                        $repo = json_decode(json_encode($repo), true);


                        //dont bother about forks
                        if (isset($repo["fork"]) && !$repo["fork"]) {
                            //make sure we are the owners

                            if ($repo["owner"]["login"] == $gitUserName) {
                                $isSSModule =  (stripos($repo["name"], 'silverstripe-')  !== false);
                                //check it is silverstripe module

                                if (!$getNamesWithPrefix) {
                                    $name = $repo["name"];
                                } else {
                                    $name = preg_replace('/silverstripe/', "", $repo["name"], $limit = 1);
                                }

                                //if(strlen($name) < strlen($repo["name"])) {
                                if ($isSSModule) {
                                    //is it listed yet?
                                    if (!in_array($name, $modules)) {
                                        array_push($modules, $name);
                                    }
                                } else {
                                    GeneralMethods::output_to_screen("skipping ".$repo["name"]." as it does not appear to me a silverstripe module");
                                }
                            } else {
                                GeneralMethods::output_to_screen("skipping ".$repo["name"]." as it has a different owner");
                            }
                        } elseif (isset($repo["name"])) {
                            DB::alteration_message("skipping ".$repo["name"]." as it is a fork");
                        }
                    }
                }
                self::$_modules = $modules;
            }
        }
        return self::$_modules;
    }
}