sunnysideup / silverstripe-menucache

code/MenuCache.php

<?php

class MenuCache extends DataExtension
{
    /**
    * fields are typicall header, menu, footer
    */

    private static $db = array(

The property $db is not used and could be removed.

        "CachedSection0" => "HTMLText",
        "CachedSection1" => "HTMLText",
        "CachedSection2" => "HTMLText",
        "CachedSection3" => "HTMLText",
        "CachedSection4" => "HTMLText"
    );

    private static $fields = array(
        0 => "Header",
        1 => "Menu",
        2 => "Footer",
        3 => "LayoutSection",
        4 => "other",
    );

    /* sets the cache number used for getting the "$Layout" of the individual page */
    private static $layout_field = 3;

The property $layout_field is not used and could be removed.

    private static $tables_to_clear = array("SiteTree", "SiteTree_Live", "SiteTree_versions");

The property $tables_to_clear is not used and could be removed.

    public static function field_maker($fieldNumber)
    {
        return "CachedSection".$fieldNumber;
    }

    public static function fields_exists($number)
    {
        return (isset(self::$fields[$number]));
    }

    public function updateCMSFields(FieldList $fields)
    {
        $fields->addFieldToTab("Root.Caching", new CheckboxField("DoNotCacheMenu", "Do Not Cache Menu"));
        $fields->addFieldToTab("Root.Caching", new LiteralField("ClearCache", "<a href=\"".$this->owner->Link("clearallfieldcaches")."\">clear cache (do this at the end of all edit sessions)</a>"));
        return $fields;
    }

    //-------------------- menu cache ------------------ ------------------ ------------------ ------------------ ------------------ ------------------

    public function clearfieldcache($showoutput = false)
    {
        $fieldsToClear = array();
        $fieldsForEach = Config::inst()->get("MenuCache", "fields");
        foreach ($fieldsForEach as $key => $field) {
            $fieldName = self::field_maker($key);
            $fieldsToClear[] = "\"".$fieldName."\" = ''";
        }
        if (count($fieldsToClear)) {
            $tablesForEach = Config::inst()->get("MenuCache", "tables_to_clear");
            foreach ($tablesForEach as $table) {
                $msg = '';
                $sql = "UPDATE \"".$table."\" SET ".implode(", ", $fieldsToClear);
                if (Controller::curr()->getRequest()->param("ID") == "days" && $days = intval(Controller::curr()->getRequest()->param("OtherID"))) {
                    $sql .= ' WHERE \"LastEdited\" > ( NOW() - INTERVAL '.$days.' DAY )';
                    $msg .= ', created before the last '.$days.' days';
                } elseif (Controller::curr()->getRequest()->param("ID") == "thispage") {
                    $sql .= " WHERE  \"".$table."\".\"ID\" = ".$this->owner->ID;
                    $msg .= ', for page with ID = '.$this->owner->ID;
                }
                if ($showoutput) {
                    DB::alteration_message("Deleting cached data from $table, ".$msg);
                    debug::show($sql);
                }
                DB::query($sql);
            }
        }
        return array();
    }

    //add this function to your page class if needed
    public function onBeforeWrite()
    {
        //$this->clearfieldcache(); // technically this should be done, but it puts a lot of strain on saving so instead we encourage people to use ?flush=1

72% of this comment could be valid code. Did you maybe forget this after debugging?

        parent::onBeforeWrite();
    }
}

class MenuCache_Controller extends Extension
{
    private static $allowed_actions = array("showcachedfield","clearfieldcache","showuncachedfield", "clearallfieldcaches");

The property $allowed_actions is not used and could be removed.

    protected function getHtml($fieldNumber)
    {
        $layoutField = Config::inst()->get("MenuCache", "layout_field");
        if ($layoutField == $fieldNumber) {
            $className = $this->owner->ClassName;
            if ("Page" == $className) {
                $className = "PageCached";
            }
            return $this->owner->renderWith(array($className, "PageCached"));
        } else {
            return $this->owner->renderWith('UsedToCreateCache'.$fieldNumber);
        }
    }

    public function CachedField($fieldNumber)
    {
        $fieldName = MenuCache::field_maker($fieldNumber);
        if (isset($_REQUEST["flush"])) {
            $this->owner->clearfieldcache();
        }
        if (!(MenuCache::fields_exists($fieldNumber))) {
            user_error("$fieldName is not a field that can be cached", E_USER_ERROR);
        } else {
            if (!$this->owner->$fieldName || $this->owner->DoNotCacheMenu) {
                $fieldID = $fieldNumber;

$fieldID is not used, you could remove the assignment.

                $content = $this->getHtml($fieldNumber);
                $sql = "Update \"SiteTree_Live\" Set \"".$fieldName."\" = '".$this->compressAndPrepareHTML($content)."' WHERE \"ID\" = ".$this->owner->ID." LIMIT 1";
                DB::query($sql);
                return $content;
            } else {
                return $this->owner->$fieldName;
            }
        }
    }


    private function compressAndPrepareHTML($html)
    {
        $pat[0] = "/^\s+/";
        $pat[1] = "/\s{2,}/";
        $pat[2] = "/\s+\$/";
        $rep[0] = "";
        $rep[1] = " ";
        $rep[2] = "";
        $html = preg_replace($pat, $rep, $html);
        $html = trim($html);
        return addslashes($html);
    }



    public function showcachedfield($httpRequest = null)
    {
        $fieldNumber = $httpRequest->param("ID");
        return $this->getHtml($fieldNumber);
    }

    public function showuncachedfield($httpRequest = null)
    {
        $this->owner->clearfieldcache();
        return $this->showcachedfield($httpRequest);
    }

    public function clearallfieldcaches($httpRequest = null)

The parameter $httpRequest is not used and could be removed.

    {
        $this->owner->clearfieldcache(true);
        return 'fields have been cleared, <a href="/?flush=all">click to continue...</a>';
    }
}