Issues in ImageStyle.php (master) - Issues in master - sunnysideup/silverstripe-imagewithstyle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (150)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/model/ImageStyle.php (33 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php



class ImageStyle extends DataObject
namespace YourVendor;

class YourClass { }
{
    private static $default_style = 'unstyled-image';


    public static function get_default_style()
    {
        $defaultStyle = ImageStyle::get()->filter(
            [
                'ClassNameForCSS' => Config::inst()->get('ImageStyle', 'default_style')
            ]
        )->first();
        if (! $defaultStyle) {
            $defaultStyle = ImageStyle::get()->first();
            if (! $defaultStyle) {
                user_error('Could not find a default Style.');
            }
        }

        return $defaultStyle;
    }

    /**
     * see _config folder for details ...
     * @var array
     */
    private static $record_defaults = [];



    #######################
    ### Names Section
    #######################

    private static $singular_name = 'Image Style';


    public function i18n_singular_name()
    {
        return _t('ImageStyle.SINGULAR_NAME', 'Image Style');
    }

    private static $plural_name = 'Image Styles';


    public function i18n_plural_name()
    {
        return _t('ImageStyle.PLURAL_NAME', 'Image Styles');
    }


    #######################
    ### Model Section
    #######################

    private static $db = [

        'Title' => 'Varchar',
        'ClassNameForCSS' => 'Varchar',
        'Description' => 'Text',
        'Var1Name' => 'Varchar',
        'Var1Type' => 'Enum(\'Pixels,Percentage,Options\', \'Pixels\')',
        'Var1Options' => 'Varchar(200)',
        'Var1Description' => 'Varchar(200)',

        'Var2Name' => 'Varchar',
        'Var2Type' => 'Enum(\'Pixels,Percentage,Options\', \'Pixels\')',
        'Var2Options' => 'Varchar(200)',
        'Var2Description' => 'Varchar(200)',

        'Var3Name' => 'Varchar',
        'Var3Type' => 'Enum(\'Pixels,Percentage,Options\', \'Pixels\')',
        'Var3Options' => 'Varchar(200)',
        'Var3Description' => 'Varchar(200)',

        'Var4Name' => 'Varchar',
        'Var4Type' => 'Enum(\'Pixels,Percentage,Options\', \'Pixels\')',
        'Var4Options' => 'Varchar(200)',
        'Var4Description' => 'Varchar(200)',

        'Var5Name' => 'Varchar',
        'Var5Type' => 'Enum(\'Pixels,Percentage,Options\', \'Pixels\')',
        'Var5Options' => 'Varchar(200)',
        'Var5Description' => 'Varchar(200)',

    ];

    private static $has_many = [

        'ImagesWithStyle' => 'ImageWithStyle'
    ];


    #######################
    ### Further DB Field Details
    #######################

    private static $indexes = [

        'Title' => true
    ];

    private static $default_sort = [

        'Title' => 'ASC'
    ];

    private static $required_fields = [

        'Title',
        'ClassNameForCSS'
    ];

    private static $searchable_fields = [

        'Title' => 'PartialMatchFilter',
        'Description' => 'PartialMatchFilter',
        'ClassNameForCSS' => 'PartialMatchFilter'
    ];


    #######################
    ### Field Names and Presentation Section
    #######################

    private static $field_labels = [

        'Title' => 'Style',

        'Var1Name' => 'Variable 1 Label',
        'Var1Type' => 'Variable 1 Type',
        'Var1Options' => 'Variable 1 Options',
        'Var1Description' => 'Variable 1 Description',

        'Var2Name' => 'Variable 2 Label',
        'Var2Type' => 'Variable 2 Type',
        'Var2Options' => 'Variable 1 Options',
        'Var2Description' => 'Variable 1 Description',

        'Var3Name' => 'Variable 3 Label',
        'Var3Type' => 'Variable 3 Type',
        'Var3Options' => 'Variable 1 Options',
        'Var4Description' => 'Variable 1 Description',

        'Var4Name' => 'Variable 4 Label',
        'Var4Type' => 'Variable 4 Type',
        'Var4Options' => 'Variable 4 Options',
        'Var4Description' => 'Variable 4 Description',

        'Var5Name' => 'Variable 5 Label',
        'Var5Type' => 'Variable 5 Type',
        'Var5Options' => 'Variable 5 Options',
        'Var5Description' => 'Variable 5 Description',
    ];

    private static $field_labels_right = [];


    private static $summary_fields = [

        'Title' => 'Style',
        'ImagesWithStyle.Count' => 'Usage Count'
    ];


    #######################
    ### Casting Section
    #######################


    #######################
    ### can Section
    #######################

    public function canCreate($member = null)
    {
        return false;
    }

    public function canEdit($member = null)
    {
        //we block edits in CMS
        return parent::canEdit($member);
    }

    public function canDelete($member = null)
    {
        if ($this->ImagesWithStyle()->count() === 0) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return parent::canDelete($member);
        }

        return false;
    }



    #######################
    ### write Section
    #######################




    public function validate()

    {
        $result = parent::validate();
        $fieldLabels = $this->FieldLabels();
        $indexes = $this->Config()->get('indexes');
        $requiredFields = $this->Config()->get('required_fields');
        if (is_array($requiredFields)) {
            foreach ($requiredFields as $field) {
                $value = $this->$field;
                if (! $value) {
                    $fieldWithoutID = $field;
                    if (substr($fieldWithoutID, -2) === 'ID') {
                        $fieldWithoutID = substr($fieldWithoutID, 0, -2);
                    }
                    $myName = isset($fieldLabels[$fieldWithoutID]) ? $fieldLabels[$fieldWithoutID] : $fieldWithoutID;
                    $result->error(
                        _t(
                            'ImageStyle.'.$field.'_REQUIRED',
                            $myName.' is required'
                        ),
                        'REQUIRED_ImageStyle_'.$field
                    );
                }
                if (isset($indexes[$field]) && isset($indexes[$field]['type']) && $indexes[$field]['type'] === 'unique') {
                    $id = (empty($this->ID) ? 0 : $this->ID);
                    $count = ImageStyle::get()
                        ->filter(array($field => $value))
                        ->exclude(array('ID' => $id))
                        ->count();
                    if ($count > 0) {
                        $myName = $fieldLabels['$field'];
                        $result->error(
                            _t(
                                'ImageStyle.'.$field.'_UNIQUE',
                                $myName.' needs to be unique'
                            ),
                            'UNIQUE_ImageStyle_'.$field
                        );
                    }
                }
            }
        }

        return $result;
    }

    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        $this->ClassNameForCSS = preg_replace('/\W+/', '-', strtolower(strip_tags($this->ClassNameForCSS)));

        if (! $this->ClassNameForCSS) {

            $this->ClassNameForCSS = 'image-with-style-'.$this->ID;

        }
        //...
    }

    public function onAfterWrite()
    {
        parent::onAfterWrite();
        //...
    }

    public function requireDefaultRecords()
    {
        parent::requireDefaultRecords();
        //...
        $defaults = $this->Config()->record_defaults;
        $currentOnes = array_flip(ImageStyle::get()->column('ID'));
        $imageNames = Config::inst()->get('PerfectCMSImageDataExtension', 'perfect_cms_images_image_definitions');
        foreach ($defaults as $defaultValues) {
            foreach ($defaultValues as $field => $value) {
                if (is_array($value)) {
                    $defaultValues[$field] = serialize($value);
                }
            }
            $obj = ImageStyle::get()->filter(['Title' => $defaultValues['Title']])->first();
            if (!$obj) {
                $obj = ImageStyle::create($defaultValues);
            } else {
                foreach ($obj->db() as $field => $type) {
                    $obj->$field = null;
                }
                foreach ($defaultValues as $field => $value) {
                    $obj->$field = $value;
                }
            }
            unset($currentOnes[$obj->ID]);
            $obj->write();
            if (! isset($imageNames[$obj->ClassNameForCSS])) {

                user_error('You need to define a perfect CMS image with the following name: '.$obj->ClassNameForCSS);

            }
        }
        foreach ($currentOnes as $id) {
            $obj = ImageStyle::get()->byID($id);
            if ($obj && $obj->canDelete()) {
                $obj->delete();
            }
        }
    }


    #######################
    ### Import / Export Section
    #######################

    public function getExportFields()

    {
        //..
        return parent::getExportFields();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }



    #######################
    ### CMS Edit Section
    #######################


    public function CMSEditLink()
    {
        $controller = singleton("tba");

        return $controller->Link().$this->ClassName."/EditForm/field/".$this->ClassName."/item/".$this->ID."/edit";
    }

    public function CMSAddLink()
    {
        $controller = singleton("tba");

        return $controller->Link().$this->ClassName."/EditForm/field/".$this->ClassName."/item/new";
    }


    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        //do first??
        $rightFieldDescriptions = $this->Config()->get('field_labels_right');
        foreach ($rightFieldDescriptions as $field => $desc) {

            $formField = $fields->DataFieldByName($field);
            if (! $formField) {
                $formField = $fields->DataFieldByName($field.'ID');
            }
            if ($formField) {
                $formField->setDescription($desc);
            }
        }

        // move variables to their own tab
        for ($i = 1; $i < 6; $i++) {
            if ($this->HasStyleVariable('Var'.$i)) {
                $fieldsToAdd = [
                    $fields->dataFieldByName('Var'.$i.'Name'),
                    $fields->dataFieldByName('Var'.$i.'Type'),
                    $fields->dataFieldByName('Var'.$i.'Options'),
                    $fields->dataFieldByName('Var'.$i.'Description')
                ];
                $fields->addFieldsToTab(
                    'Root.Variable '.$i,
                    $fieldsToAdd
                );
            } else {
                $fields->removeByName('Var'.$i.'Name');
                $fields->removeByName('Var'.$i.'Type');
                $fields->removeByName('Var'.$i.'Options');
                $fields->removeByName('Var'.$i.'Description');
            }
        }
        $fields->removeByName('ImagesWithStyle');

        //make everything readonly
        foreach ($fields->saveableFields() as $field) {
            $fieldName = $field->getName();
            $oldField = $fields->dataFieldByName($fieldName);
            if ($oldField) {
                $newField = $oldField->performReadonlyTransformation();
                $fields->replaceField($fieldName, $newField);
            }
        }

        return $fields;
    }


    public function HasStyleVariable($varName)
    {
        $name = $varName.'Name';
        $type = $varName.'Type';
        $hasBase = $this->$name && $this->$type ? true : false;
        if ($this->$type === 'Options') {
            return $hasBase && is_array($this->OptionsAsArray($varName)) ? true : false;
        } else {
            return $hasBase;
        }
    }
    public function HasOptionsAsArray($varName)
    {
        $options = $this->OptionsAsArray($varName);

        return count($options) ? true : false;
    }

    public function OptionsAsArray($varName)
    {
        $options = $varName.'Options';
        $array = [];
        if ($this->$options) {
            $array = @unserialize($this->$options);
        }
        if (is_array($array)) {
            return $array;
        }

        return [];
    }
}


Issues (150)

Security Analysis no request data

code/model/ImageStyle.php (33 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

1			<?php
2
3
4
5			class ImageStyle extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2018-05-14 04:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6			{
7			private static $default_style = 'unstyled-image';
			0 ignored issues – show Unused Code introduced 2018-05-16 07:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$default_style` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
8
9			public static function get_default_style()
10			{
11			$defaultStyle = ImageStyle::get()->filter(
12			[
13			'ClassNameForCSS' => Config::inst()->get('ImageStyle', 'default_style')
14			]
15			)->first();
16			if (! $defaultStyle) {
17			$defaultStyle = ImageStyle::get()->first();
18			if (! $defaultStyle) {
19			user_error('Could not find a default Style.');
20			}
21			}
22
23			return $defaultStyle;
24			}
25
26			/**
27			* see _config folder for details ...
28			* @var array
29			*/
30			private static $record_defaults = [];
			0 ignored issues – show Unused Code introduced 2018-05-16 07:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$record_defaults` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
31
32
33			#######################
34			### Names Section
35			#######################
36
37			private static $singular_name = 'Image Style';

sunnysideup / silverstripe-imagewithstyle

Issues (150)

Security Analysis no request data

code/model/ImageStyle.php (33 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like