Issues in HideMailto.php (master) - Issues in master - sunnysideup/silverstripe-hidemailto - Measure and Improve Code Quality continuously with Scrutinizer

Issues (26)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/HideMailto.php (22 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


class HideMailto extends SiteTreeExtension
namespace YourVendor;

class YourClass { }
{
    private static $email_field = "Email";

    private static $default_subject = "enquiry";

    private static $replace_characters = array(

        "." => "&#x2e;",
        "@" => "&#x40;",
        "a" => "&#x61;",
        "b" => "&#x62;",
        "c" => "&#x63;",
        "d" => "&#x64;",
        "e" => "&#x65;",
        "f" => "&#x66;",
        "g" => "&#x67;",
        "h" => "&#x68;",
        "i" => "&#x69;"
    );

    /**
     *
     * @param String $email
     * @param String $subject
     * @return Obj (MailTo, Text, Original, Subject)

     */
    public static function convert_email($email, $subject = '')
    {
        $obj = new ViewableData();
        if (!$subject) {
            $subject = self::$default_subject;
        }
        //mailto part
        $mailTo = "mailto:".$email."?subject=".Convert::raw2mailto($subject);
        $mailToConverted = self::string_encoder($mailTo);
        $convertedEmail = self::string_encoder($email);
        $obj->MailTo = $mailToConverted;
        $obj->Text = $convertedEmail;
        $obj->Original = $email;
        $obj->Subject = $subject;
        //$obj->OnClick = "jQuery(this).attr('href', HideMailto2Email('".self::get_dot_replacer()."', '".$array[0]."', '".$array[1]."', '".Convert::raw2mailto($subject)."')); return true;";

        //TO DO: add a JS function that puts the
        Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
        //Requirements::javascript("hidemailto/javascript/HideMailto2Email.js");

        return $obj;
    }


    /**
     * encodes a string - randomly
     * @param String $string
     * @return String
     */
    private static function string_encoder($string)
    {
        $encodedString = '';
        $nowCodeString = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $originalLength = strlen($string);
        for ($i = 0; $i < $originalLength; $i++) {
            $encodeMode = rand(1, 2);
            switch ($encodeMode) {
                case 1: // Decimal code
                    $nowCodeString = '&#' . ord($string[$i]) . ';';
                    break;
                case 2: // Hexadecimal code
                    $nowCodeString = '&#x' . dechex(ord($string[$i])) . ';';
                    break;
                default:
                    return 'ERROR: wrong encoding mode.';
            }
            $encodedString .= $nowCodeString;
        }
        return $encodedString;
    }

    public function HideMailToObject()
    {
        if ($email = $this->getHiddenEmailData()) {
            $obj = self::convert_email($email);
            return $obj;
        }
    }

    private function getHiddenEmailData()

    {
        if ($field = self::$email_field) {
            if ($email = $this->owner->$field) {
                return $this->isEmail($email);
            }
        }
    }

    private function isEmail($email)

    {
        if (!preg_match("/^([A-Za-z0-9._-])+\@(([A-Za-z0-9-])+\.)+([A-Za-z0-9])+$/", trim($email))) {
            return "";
        } else {
            return $email;
        }
    }
}

class HideMailto_Role extends DataExtension
namespace YourVendor;

class YourClass { }
{

    //member link

    public function HideMailtoLink()
    {
        return "mailto/" . $this->owner->ID;
    }
}

/**
 * Generates obfusticated links, and also holds the method called when /mailto/
 * is called via the URL. As noted above, take a look at the _config.php file to
 * see how mailto/ maps to this class.
 */
class HideMailto_Controller extends ContentController
namespace YourVendor;

class YourClass { }
{
    /**
     * The list of allowed domains to create a mailto: link to. By default, allow
     * all domains.
     *
     * TODO Maybe the default should be to allow the current domain only?
     */
    private static $allowed_domains = '*';

    public function __construct($dataRecord = null)
    {
        parent::__construct($dataRecord);
        return $this->index();

    }

    public function defaultAction($action)
    {
        return $this->index();
    }

    public $url = '';

    /**
     * This is called by default when this controller is executed.
     */
    public function index()
    {
        $member = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $user = '';
        $domain = '';
        $subject = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        // We have two situations to deal with, where urlParams['Action'] is an int (assume Member ID), or a string (assume username)
        if (is_numeric($this->getRequest()->param('Name'))) {
            // Action is numeric, assume it's a member ID and optional ID is the email subject
            $member = Member::get()->byID($this->getRequest()->param('Name'));
            if (!$member) {
                user_error("No member found with ID #" . $this->getRequest()->param('Name'), E_USER_ERROR); // No member found with this ID, perhaps we could redirect a user back instead of giving them a 500 error?
            }
            list($user, $domain) = explode('@', $member->Email);
            $subject = $this->getRequest()->param('ID');
        } else {
            // Action is not numeric, assume that Action is the username, ID is the domain and optional OtherID is the email subject
            $user = urldecode($this->getRequest()->param('Name'));
            $domain = urldecode($this->getRequest()->param('URL'));
            $subject = $this->getRequest()->param('Subject');
        }
        $emailString = "mailto: $user@$domain?subject=".$subject;
        // Make sure the domain is in the allowed domains
        if ((is_string(self::$allowed_domains) && self::$allowed_domains == '*') || in_array($domain, self::$allowed_domains)) {
            // Create the redirect
            header("Location: " . $emailString);
            header("Refresh: 0; url=". $emailString);
            echo $this->customise(array("RedirectBackURL" => $this->RedirectBackURL(), "Email" => $this->makeMailtoString($user, $domain, $subject)))->renderWith("HideMailto");
            $emailString = $this->makeMailtoString($user, $domain, $subject);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } else {
            user_error("We're not allowed to redirect to the domain '$domain', because it's not listed in the _config.php file", E_USER_ERROR);
        }
    }

    public function RedirectBackURL()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (isset($_SERVER['HTTP_REFERER'])) {
            $this->redirectBackURL = $_SERVER['HTTP_REFERER'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        if (!$this->redirectBackURL) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->redirectBackURL = Director::absoluteBaseURL();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        return $this->redirectBackURL;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }


    protected function makeMailtoString($user, $domain, $subject = '')
    {
        $target = 'mailto:' . $user . '@' . $domain;
        if ($subject) {
            $target .= '?subject=' . Convert::raw2mailto($subject);
        }
        $target = str_replace(".", "&x2e;", $target);
        $target = str_replace("@", "&x40;", $target);
        return $target;
    }
}


sunnysideup / silverstripe-hidemailto

Issues (26)

Security Analysis not enabled

code/HideMailto.php (22 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like