GoogleMapBasic

Complexity

Total Complexity

13

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	updateCMSFields()	0	25	4
B	canHaveMap()	0	18	9

<?php

/**
 *@author nicolaas[at] sunnysideup.co.nz
 *
 *
 **/


class GoogleMapBasic extends SiteTreeExtension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $db = array(

The property $db is not used and could be removed.

        'ShowMap' => 'Boolean',
        'StaticMap' => 'Boolean',
        'Address' => 'Text',
        'Lat' => 'Decimal(12,9)',
        'Lng' => 'Decimal(12,9)',
        'ZoomLevel' => 'Int',
        'InfoWindowContent' => 'HTMLText'
    );


    private static $include_in_classes = array();

The property $include_in_classes is not used and could be removed.

    private static $exclude_from_classes = array();

The property $exclude_from_classes is not used and could be removed.

    public function updateCMSFields(FieldList $fields)
    {
        if ($this->canHaveMap()) {
            $reloadMessage = " ";
            if (!$this->owner->ShowMap) {

The property ShowMap does not seem to exist in SS_Object.

                $reloadMessage = " (save (and publish) to see additional options)";
            }
            $fields->addFieldToTab("Root.Map", new CheckboxField("ShowMap", "Show map $reloadMessage"));
            if ($this->owner->ShowMap) {
                $fields->addFieldsToTab(
                    "Root.Map",
                    [
                        CheckboxField::create("StaticMap", "Show map as picture only"),
                        TextField::create("Address"),
                        NumericField::create("ZoomLevel", "Zoom (1 = world, 20 = too close)"),
                        NumericField::create("Lat", "Latitude")
                            ->setRightTitle('Optional, use in conjunction with Longitude if address is not accurate enough.'),
                        NumericField::create("Lng", "Longitude")
                            ->setRightTitle('Optional, use in conjunction with Latitude if address is not accurate enough.'),
                        HtmlEditorField::create("InfoWindowContent", "Info Window Content")->setRows(5)
                    ]
                );
            }
        }
    }

    protected function canHaveMap()
    {
        $include = Config::inst()->get("GoogleMapBasic", "include_in_classes");
        $exclude = Config::inst()->get("GoogleMapBasic", "exclude_from_classes");
        if (!is_array($exclude) || !is_array($include)) {
            user_error("include or exclude classes is NOT an array", E_USER_NOTICE);
            return true;
        }
        if (!count($include) && !count($exclude)) {
            return true;
        }
        if (count($include) && in_array($this->owner->ClassName, $include)) {

The property ClassName does not seem to exist in SS_Object.

            return true;
        }
        if (count($exclude) && !in_array($this->owner->ClassName, $exclude)) {
            return true;
        }
    }
}