GoogleMapDataResponse - Code Metrics - Inspection of "PSR-2" - sunnysideup/silverstripe-googlemap - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( a40b1f...acc53b )

by Nicolaas
created 2018-01-31 00:20 UTC
GoogleMapDataResponse F

↳ Parent: Project
Complexity

Total Complexity
Size/Duplication

Total Lines	698
Duplicated Lines	2.15 %
Coupling/Cohesion

Components	2
Dependencies	14
Importance

Changes
Metric	Value
wmc	94
lcom	2
cbo	14
dl	15
loc	698
rs	1.6251
c	0
b	0
f	0
27 Methods

Rating	Name	Duplication	Size	Complexity
A	session_var_name()	0	4	1
A	add_custom_google_map_session_data()	0	6	1
A	set_custom_google_map_session_data()	0	7	2
A	get_custom_google_map_session_data()	0	14	3
A	clear_custom_google_map_session_data()	0	4	1
C	init()	0	43	11
A	setOwner()	0	4	1
A	setTitle()	0	4	1
A	setLng()	0	4	1
A	setLat()	0	4	1
A	setFilterCode()	0	4	1
A	index()	0	4	1
A	showemptymap()	0	4	1
A	showpagepointsmapxml()	8	8	2
A	showchildpointsmapxml()	7	7	2
A	showdirectchildren()	0	7	2
B	showsearchpoint()	0	20	5
B	showpointbyid()	0	24	6
A	showcustompagesmapxml()	0	6	1
A	showcustomdosmapxml()	0	6	1
F	showaroundmexml()	0	62	16
C	updatemexml()	0	56	18
A	GoogleMapController()	0	7	2
A	makeXMLData()	0	14	1
A	xml_sheet()	0	17	4
B	quick_static_map()	0	30	6
A	make_static_map_url_into_image()	0	15	2
How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class
Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.
Complex classes like GoogleMapDataResponse often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use GoogleMapDataResponse, and based on these observations, apply Extract Interface, too.
<?php

/**
 * The way the map works is that you open a page, which loads the initial page
 * with the map points being loaded as a separate XML doc.
 *
 * This controller returns the Google Map data XML sheet
 * You can show one point by adding ?i=123
 * Where 123 is the ID of a GoogleMapLocationsObject
 *
 * Here are other return options for the Map .... *
 *
 * 'index' / 'showemptymap' => map without anything on it, fallback
 *
 * 'showpagepointsmapxml' => show points from the current page
 *
 * 'showchildpointsmapxml' => show points from the child pages (all child pages)
 *
 * 'showdirectchildren' => show points from the child pages (direct ones only)
 *
 * 'showsearchpoint' =>
 *
 * 'showcustompagesmapxml' => these are sitetree elements loaded by session
 *
 * 'showcustomdosmapxml' =>
 *
 * 'showdataobjects' =>
 *
 * 'updatemexml' =>
 *
 * 'showaroundmexml' =>
 *
 * 'showpointbyid' => can also be more than one ID
 *
 */

class GoogleMapDataResponse extends Controller
namespace YourVendor;

class YourClass { }
{
    private static $session_var_prefix = "addCustomGoogleMap";


    /**
     * set searches in show around me to a specific max radius
     * @var int
     */
    private static $max_radius_for_show_around_me = 20000;


    /**
     * Default URL handlers - (Action)/(ID)/(OtherID)
     */
    private static $url_handlers = array(

        '/$Action//$OwnerID/$Title/$Longitude/$Latitude/$FilterCode/$SecondFilterCode' => 'handleAction',
    );





    #################
    # SESSION MANAGEMENT
    #################

    protected static function session_var_name($filterCode = "")
    {
        return Config::inst()->get("GoogleMapDataResponse", "session_var_prefix")."_".$filterCode;
    }

    /**
     * @param Array $addCustomGoogleMapArrayNEW
     * @param string $filterCode
     *
     */
    public static function add_custom_google_map_session_data($addCustomGoogleMapArrayNEW, $filterCode = "")
    {
        $addCustomGoogleMapArrayOLD = Session::get(self::session_var_name($filterCode));
        $addCustomGoogleMapArrayNEW = array_merge($addCustomGoogleMapArrayOLD, $addCustomGoogleMapArrayNEW);
        Session::set(Session::get(self::session_var_name($filterCode), serialize($addCustomGoogleMapArrayNEW)));

    }

    /**
     *
     *
     * @param Array $addCustomGoogleMapArray
     * @param string $filterCode
     *
     */
    public static function set_custom_google_map_session_data($addCustomGoogleMapArray, $filterCode = "")
    {
        if (!is_array($addCustomGoogleMapArray)) {
            user_error("addCustomGoogleMapArray should be an array!");
        }
        Session::set(self::session_var_name($filterCode), serialize($addCustomGoogleMapArray));
    }

    /**
     * @param string $filterCode
     *
     * @return Array
     */
    public static function get_custom_google_map_session_data($filterCode = "")
    {
        $data = Session::get(self::session_var_name($filterCode));
        if (is_array($data)) {
            $addCustomGoogleMapArray = $data;
        } else {
            try {
                $addCustomGoogleMapArray = unserialize($data);
            } catch (Exception $e) {
                $addCustomGoogleMapArray = array();
            }
        }
        return $addCustomGoogleMapArray;
    }

    /**
     *
     * @param string $filterCode
     */
    public static function clear_custom_google_map_session_data($filterCode = "")
    {
        Session::clear(self::session_var_name($filterCode));
    }







    #################
    # BASICS
    #################
    /**
     * @inherited
     */
    private static $allowed_actions = array(

        'showemptymap' => true,
        'showpagepointsmapxml' => true,
        'showchildpointsmapxml' => true,
        'showdirectchildren' => true,
        'showsearchpoint' => true,
        'showcustompagesmapxml' => true,
        'showcustomdosmapxml' => true,
        'showdataobjects' => true,
        'updatemexml' => 'ADMIN',
        'showaroundmexml' => true,
        'showpointbyid' => true
    );

    /**
     * @var Array
     */
    private static $actions_without_owner = array(
        'showemptymap'
    );

    /**
     * The Page that is displaying the
     * @var SiteTree
     */
    protected $owner = null;

    /**
     * @var Float
     */
    protected $lng = 0;

    /**
     * @var Float
     */
    protected $lat = 0;

    /**
     * @var String
     */
    protected $title = "";

    /**
     * @var String
     */
    protected $filterCode = "";

    /**
     * @var String
     */
    protected $secondFilterCode = "";

    /**
     * @var GoogleMap
     */
    protected $map = null;











    #################
    # SET AND GET VARIABLES
    #################

    public function init()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        parent::init();
        $id = 0;
        if ($this->request->param("OwnerID")) {
            $id = intval($this->request->param("OwnerID"));
        } elseif (isset($_GET["i"])) {
            $i = intval($_GET["i"]);
            $point = GoogleMapLocationsObject::get()->byID($i);
            if (!$point) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                //New POINT
            } else {
                $id = $point->ParentID;
            }
        }
        if ($id) {
            $this->owner = SiteTree::get()->byID($id);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        }
        //HACK
        elseif (!$this->owner) {
            $this->owner = DataObject::get_one(
                'SiteTree',
                array("Title" => Convert::raw2sql($this->request->param("Title")))
            );
        }
        if ($this->owner || in_array($this->request->param("Action"), self::$actions_without_owner)) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            //all ok
        } elseif (in_array($this->request->param("Action"), self::$actions_without_owner)) {
            //ok too
            $this->owner = DataObject::get_one('SiteTree');
        } else {
            user_error("no owner has been identified for GoogleMapDataResponse", E_USER_NOTICE);
        }
        //END HACK
        $this->title = urldecode($this->request->param("Title"));
        $this->lng = floatval($this->request->param("Longitude"));
        $this->lat = floatval($this->request->param("Latitude"));
        $this->filterCode = urldecode($this->request->param("FilterCode"));
        $this->secondFilterCode = urldecode($this->request->param("SecondFilterCode"));
        if (!$this->title && $this->owner) {
            $this->title = $this->owner->Title;
        }
    }

    /**
     * @param object $owner
     */
    public function setOwner($owner)
    {
        $this->owner = $owner;
    }

    /**
     * @param String $title
     */
    public function setTitle($title)
    {
        $this->title = $title;
    }

    /**
     * @param float $lng
     */
    public function setLng($lng)
    {
        $this->lng = $lng;
    }

    /**
     * @param Float $lat
     */
    public function setLat($lat)
    {
        $this->lat = $lat;
    }

    /**
     * @param string $filterCode
     */
    public function setFilterCode($filterCode)
    {
        $this->filterCode = $filterCode;
    }











    #################
    # ACTIONS
    #################

    /**
     * @param SS_HTTPRequest
     *
     * @return String (XML)
     */
    public function index($request)
    {
        return $this->showemptymap($request);
    }

    /**
     * @param SS_HTTPRequest
     *
     * @return String (XML)
     */
    public function showemptymap($request)

    {
        return $this->makeXMLData(null, null, $this->title, $this->title." "._t("GoogleMap.MAP", "map"));
    }

    /**
     * @param SS_HTTPRequest
     *
     * @return String (XML)
     */
    public function showpagepointsmapxml($request)

    {
        $data = GoogleMapLocationsObject::get()->filter(array("ParentID" => $this->owner->ID));
        if ($data->count()) {
            return $this->makeXMLData(null, $data, $this->title, $this->title." "._t("GoogleMap.MAP", "map"));
        }
        return $this->showemptymap($request);
    }

    /**
     * @param SS_HTTPRequest
     *
     * @return String (XML)
     */
    public function showchildpointsmapxml($request)

    {
        if ($children = $this->owner->getChildrenOfType($this->owner, null)) {
            return $this->makeXMLData($children, null, $this->title, $this->title." "._t("GoogleMap.MAP", "map"));
        }
        return $this->showemptymap($request);
    }

    /**
     * @param SS_HTTPRequest
     *
     * @return String (XML)
     */
    public function showdirectchildren($request)
    {
        if ($children = Provider::get()) {
            return $this->makeXMLData($children, null, $this->title, $this->title." "._t("GoogleMap.MAP", "map"));
        }
        return $this->showemptymap($request);
    }

    /**
     * @param SS_HTTPRequest
     *
     * @return String (XML)

     */
    public function showsearchpoint($request)
    {
        if ($this->lat && $this->lng) {
            $point = GoogleMapLocationsObject::create();
            $point->ParentID = $this->owner->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $point->Latitude = $this->lat;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $point->Longitude = $this->lng;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $point->CustomPopUpWindowTitle = $this->title;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if ($this->address) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                die("get address to do");

                $point->CustomPopUpWindowInfo = $this->address;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            }
            if ($point) {
                $data = new ArrayList();
                $data->push($point);
                return $this->makeXMLData(null, $data, $this->title, $this->title);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }
        }
        return $this->showemptymap($request);
    }

    /**
     * @param SS_HTTPRequest
     *
     * @return String (XML)
     */
    public function showpointbyid($request)
    {
        $id = $request->param("FilterCode");
        $ids = explode(',', $id);
        foreach ($ids as $key => $id) {
            $ids[$key] = intval($id);
        }
        $className = Convert::raw2sql($request->param("SecondFilterCode"));
        $direct = false;
        if (! $className) {
            $direct = true;
        } elseif (! class_exists($className)) {
            $direct = true;
        }
        if ($direct) {
            $className = "GoogleMapLocationsObject";
        }
        $objects = $className::get()->filter(array("ID" => $ids));
        if ($direct) {
            return $this->makeXMLData(null, $objects, $this->title, $this->title);
        } else {
            return $this->makeXMLData($objects, null, $this->title, $this->title);
        }
    }


    /**
     * load data from session
     *
     * @param SS_HTTPRequest
     *
     * @return String (XML)
     */
    public function showcustompagesmapxml($request)

    {
        $addCustomGoogleMapArray = GoogleMapDataResponse::get_custom_google_map_session_data($this->filterCode);
        $pages = SiteTree::get()->filter(array("ID" => $addCustomGoogleMapArray));
        return $this->makeXMLData($pages, null, $this->title, $this->title);
    }

    /**
     * load a custom set of GoogleMapLocationsObjects
     *
     * @param SS_HTTPRequest
     *
     * @return String (XML)
     */
    public function showcustomdosmapxml($request)

    {
        $array = GoogleMapDataResponse::get_custom_google_map_session_data($this->filterCode);
        $googleMapLocationsObjects = GoogleMapLocationsObject::get()->filter(array("ID" => $array));
        return $this->makeXMLData(null, $googleMapLocationsObjects, $this->title, $this->title);
    }

    /**
     * Show what is around my points
     *
     * @param SS_HTTPRequest
     *
     * @return String (XML)
     */
    public function showaroundmexml($request)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $lng = 0;
        $lat = 0;
        $maxRadius = intval($this->Config()->get('max_radius_for_show_around_me')) - 0;
        if (isset($_GET['maxradius'])) {
            $maxRadius = intval($_GET['maxradius']);
        }
        $excludeIDList = array();
        $stage = '';
        if (Versioned::current_stage() == "Live") {
            $stage = "_Live";
        }
        if ($this->lng && $this->lat) {
            $lng = $this->lng;
            $lat = $this->lat;
        } elseif ($this->owner->ID) {
            //find the average!
            $objects = GoogleMapLocationsObject::get()->filter(array("ParentID" => $this->owner->ID));
            if ($count = $objects->count()) {
                foreach ($objects as $point) {
                    $lng += $point->Longitude;
                    $lat += $point->Latitude;
                }
                $lng = $lng / $count;
                $lat = $lat / $count;
            }
        }
        $classNameForParent = '';
        if ($otherClass = $this->filterCode) {
            $classNameForParent = $otherClass;
        }
        if ($this->title) {
            $title = $this->title;
        } else {
            $title = _t("GoogleMap.CLOSES_TO_ME", "Closest to me");
        }
        if ($lng && $lat) {
            $orderByRadius = GoogleMapLocationsObject::radius_definition($lng, $lat);
            $where = "(".$orderByRadius.") > 0 (".$orderByRadius.") < ".$maxRadius." AND \"GoogleMapLocationsObject\".\"Latitude\" <> 0 AND \"GoogleMapLocationsObject\".\"Longitude\" <> 0";
            if ($classNameForParent && !is_object($classNameForParent)) {
                $where .= " AND \"SiteTree".$stage."\".\"ClassName\" = '".$classNameForParent."'";
            }
            if (count($excludeIDList)) {
                $where .= " AND \"GoogleMapLocationsObject\".\"ID\" NOT IN (".implode(",", $excludeIDList).") ";
            }
            $objects = GoogleMapLocationsObject::get()
                ->where($where)
                ->sort($orderByRadius)
                ->leftJoin("SiteTree".$stage."", "SiteTree".$stage.".ID = GoogleMapLocationsObject.ParentID")
                ->limit(Config::inst()->get("GoogleMap", "number_shown_in_around_me"));
            if ($objects->count()) {
                return $this->makeXMLData(
                    null,
                    $objects,
                    $title,
                    Config::inst()->get("GoogleMap", "number_shown_in_around_me") . " "._t("GoogleMap.CLOSEST_POINTS", "closest points")
                );
            }
        }
        return $this->showemptymap($request);
    }

    /**
     * URL must contain for GET variables
     * i - ID of owner
     * a - action
     * x - lng
     * y - lat
     *
     * actions are:
     *   - add
     *   - move
     *   - remove
     *
     * @param SS_HTTPRequest
     *
     * @return String (message)

     */
    public function updatemexml($request)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        //we use request here, because the data comes from javascript!
        if ($this->owner->canEdit()) {
            if (isset($_REQUEST["x"]) && isset($_REQUEST["y"]) && isset($_REQUEST["i"]) && isset($_REQUEST["a"])) {
                $lng = floatval($_REQUEST["x"]);
                $lat = floatval($_REQUEST["y"]);
                $id = intval($_REQUEST["i"]);
                $action = $_REQUEST["a"];
                if ($lng && $lat) {
                    if (0 == $id && "add" == $action) {
                        $point = new GoogleMapLocationsObject;
                        $point->ParentID = $this->owner->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        $point->Longitude = $lng;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        $point->Latitude = $lat;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        $point->write();
                        return $point->ID;
                    } elseif ($id > 0 && "move" == $action) {
                        $point = GoogleMapLocationsObject::get()->byID($id);
                        if ($point) {
                            if ($point->ParentID == $this->owner->ID) {
                                $point->Longitude = $lng;
                                $point->Latitude = $lat;
                                $point->Address = "";
                                $point->FullAddress = "";
                                $point->write();
                                return  _t("GoogleMap.LOCATION_UPDATED", "location updated");
                            } else {
                                return _t("GoogleMap.NO_PERMISSION_TO_UPDATE", "you dont have permission to update that location");
                            }
                        } else {
                            return _t("GoogleMap.COULD_NOT_FIND_LOCATION", "could not find location");
                        }
                    } elseif ($id && "remove" == $action) {
                        $point = GoogleMapLocationsObject::get()->byID($id);
                        if ($point) {
                            if ($point->ParentID == $this->owner->ID) {
                                $point->delete();
                                $point = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                                return _t("GoogleMap.LOCATION_DELETED", "location deleted");
                            } else {
                                return _t("GoogleMap.NO_DELETE_PERMISSION", "you dont have permission to delete that location");
                            }
                        } else {
                            return _t("GoogleMap.COULD_NOT_FIND_LOCATION", "could not find location.");
                        }
                    }
                } else {
                    return _t("GoogleMap.LOCATION_NOT_DEFINED", "point not defined.");
                }
            } else {
                return _t("GoogleMap.MISSING_VARIABLES", "not enough information was provided.");
            }
        }
        return  _t("GoogleMap.POINT_NOT_UPDATED", "You do not have permission to change the map.");
    }







    #################
    # TEMPLATE METHODS
    #################
    /**
     *
     * @return GoogleMap
     */
    public function GoogleMapController()
    {
        if (!$this->map) {
            user_error("No map has been created");
        }
        return $this->map;
    }








    #################
    # PRIVATE PARTY
    #################

    /**
     * @param DataList $pages

     * @param DataList $dataPoints

     * @param string $title
     * @param string $selectionStatement
     *
     * @return String (XML)
     */
    protected function makeXMLData(
        $pages = null,
        $dataPoints = null,
        $title = '',
        $selectionStatement = ''

    ) {
        $this->response->addHeader("Content-Type", "text/xml; charset=\"utf-8\"");
        return self::xml_sheet(
            $pages,
            $dataPoints,
            $title,
            $selectionStatement = ''
        );
    }



    ################################
    # STATIC METHODS
    ################################

    public static function xml_sheet(

        $pages = null,
        $dataPoints = null,
        $title = '',
        $selectionStatement = ''
    ) {
        $map = Injector::inst()->get("GoogleMap");
        $map->setTitleOfMap($title);
        $map->setWhereStatementDescription($selectionStatement ? $selectionStatement : $title);
        if ($pages) {
            $map->setPageDataObjectSet($pages);
        } elseif ($dataPoints) {
            $map->setPoints($dataPoints);
        }
        $map->createDataPoints();
        return $map->renderWith("GoogleMapXml");
    }



    /**
     * var arrayOfLatitudeAndLongitude: Array (Latitude" => 123, "Longitude" => 123, "Marker" => "red1");
     * Marker is optional
     * @param Array arrayOfLatitudeAndLongitude
     * @param String title
     *
     * @return String (HTML - img tag)
     */

    public static function quick_static_map($arrayOfLatitudeAndLongitude, $title)
    {
        $staticMapURL = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $count = 0;
        //width
        $staticMapWidth = Config::inst()->get("GoogleMap", "google_map_width");
        if ($staticMapWidth > 512) {
            $staticMapWidth = 512;
        }
        //height
        $staticMapHeight = Config::inst()->get("GoogleMap", "google_map_height");
        if ($staticMapHeight > 512) {
            $staticMapHeight = 512;
        }
        $staticMapURL = "size=".$staticMapWidth."x".$staticMapHeight;
        if (count($arrayOfLatitudeAndLongitude)) {
            //http://maps.google.com/maps/api/staticmap?sensor=true&maptype=map&size=209x310&
            //markers=color:green%7Clabel:A%7C-45.0302,168.663
            //&markers=color:red%7Clabel:Q%7C-36.8667,174.767

            foreach ($arrayOfLatitudeAndLongitude as $row) {
                $staticMapURL .= '&amp;markers=color:'.$row["Colour"].'%7Clabel:'.$row["Label"].'%7C';
                $staticMapURL .= round($row["Latitude"], 6).",".round($row["Longitude"], 6);
                $count++;
            }
            if ($count == 1) {
                $staticMapURL .= '&amp;center='.$defaultCenter.'&amp;zoom='. Config::inst()->get("GoogleMap", "default_zoom");

            }
        }
        return self::make_static_map_url_into_image($staticMapURL, $title);
    }

    /**
     * @param String $staticMapURL
     * @param String $title
     *
     * @return String (HTML - img tag)
     */
    protected static function make_static_map_url_into_image($staticMapURL, $title)
    {
        $fullStaticMapURL =
            'http://maps.google.com/maps/api/staticmap?'
                .Config::inst()->get("GoogleMap", "static_map_settings").'&amp;'
                .$staticMapURL.'&amp;'
                .'key='.Config::inst()->get("GoogleMap", "google_map_api_key");
        if (Config::inst()->get("GoogleMap", "save_static_map_locally")) {
            $fileName = str_replace(array('&', '|', ',', '=', ';'), array('', '', '', '', ''), $staticMapURL);
            $length = strlen($fileName);
            $fileName = "_sGMap".substr(hash("md5", $fileName), 0, 35)."_".$length.".gif";
            $fullStaticMapURL = StaticMapSaverForHTTPS::convert_to_local_file(str_replace('&amp;', '&', $fullStaticMapURL), $fileName);
        }
        return '<img class="staticGoogleMap" src="'.$fullStaticMapURL.'" alt="map: '.Convert::raw2att($title).'" />';
    }
}

sunnysideup / silverstripe-googlemap
