GoogleCustomSearchPage_Record::add_entry() - Code Metrics - sunnysideup/silverstripe-googlecustomsearch - Measure and Improve Code Quality continuously with Scrutinizer

GoogleCustomSearchPage_Record::add_entry() A
last analyzed 2018-03-20 01:17 UTC

↳ Parent: GoogleCustomSearchPage_Record

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	8
nc	3
nop	2

<?php


class GoogleCustomSearchPage_Record extends DataObject
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        "Title" => "Varchar(200)",
        "URL" => "Varchar(255)"
    );

    /**
     * add new search entry
     *
     * @param String $keywordString
     * @param String $URL
     *
     * @return Int
     */
    public static function add_entry($keywordString, $URL = "")
    {
        if ($member = Member::currentUser()) {
            if ($member->IsShopAdmin()) {
                return -1;
            }
        }
        $obj = new GoogleCustomSearchPage_Record();
        $obj->Title = $keywordString;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $obj->URL = $URL;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        return $obj->write();
    }

    /**
     * remove spaces
     *
     */
    public function onBeforeWrite()
    {
        $this->Title = strtolower(trim(preg_replace('!\s+!', ' ', $this->Title)));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        parent::onBeforeWrite();
    }


    /**
     * standard SS method
     * @param Member $member

     * @return Boolean
     */
    public function canCreate($member = null)
    {
        return false;
    }

    /**
     * standard SS method
     * @param Member $member

     * @return Boolean
     */
    public function canEdit($member = null)
    {
        return false;
    }

    /**
     * standard SS method
     * @param Member $member

     * @return Boolean
     */
    public function canDelete($member = null)
    {
        return false;
    }
}


1			<?php
2
3
4			class GoogleCustomSearchPage_Record extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
5			{
6			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
7			"Title" => "Varchar(200)",
8			"URL" => "Varchar(255)"
9			);
10
11			/**
12			* add new search entry
13			*
14			* @param String $keywordString
15			* @param String $URL
16			*
17			* @return Int
18			*/
19			public static function add_entry($keywordString, $URL = "")
20			{
21			if ($member = Member::currentUser()) {
22			if ($member->IsShopAdmin()) {
23			return -1;
24			}
25			}
26			$obj = new GoogleCustomSearchPage_Record();
27			$obj->Title = $keywordString;
			0 ignored issues – show Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<GoogleCustomSearchPage_Record>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
28			$obj->URL = $URL;
			0 ignored issues – show Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `URL` does not exist on `object<GoogleCustomSearchPage_Record>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
29			return $obj->write();
30			}
31
32			/**
33			* remove spaces
34			*
35			*/
36			public function onBeforeWrite()
37			{
38			$this->Title = strtolower(trim(preg_replace('!\s+!', ' ', $this->Title)));
			0 ignored issues – show Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<GoogleCustomSearchPage_Record>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<GoogleCustomSearchPage_Record>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
39			parent::onBeforeWrite();
40			}
41
42
43			/**
44			* standard SS method
45			* @param Member $member
			0 ignored issues – show Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Should the type for parameter `$member` not be `Member\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
46			* @return Boolean
47			*/
48			public function canCreate($member = null)
49			{
50			return false;
51			}
52
53			/**
54			* standard SS method
55			* @param Member $member
			0 ignored issues – show Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Should the type for parameter `$member` not be `Member\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
56			* @return Boolean
57			*/
58			public function canEdit($member = null)
59			{
60			return false;
61			}
62
63			/**
64			* standard SS method
65			* @param Member $member
			0 ignored issues – show Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Should the type for parameter `$member` not be `Member\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
66			* @return Boolean
67			*/
68			public function canDelete($member = null)
69			{
70			return false;
71			}
72			}
73

sunnysideup / silverstripe-googlecustomsearch

GoogleCustomSearchPage_Record::add_entry() A last analyzed 2018-03-20 01:17 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

GoogleCustomSearchPage_Record::add_entry() A
last analyzed 2018-03-20 01:17 UTC