GiftVoucherProductPage_ProductOrderItem - Code Metrics - sunnysideup/silverstripe-gift_voucher - Measure and Improve Code Quality continuously with Scrutinizer

GiftVoucherProductPage_ProductOrderItem A
last analyzed 2018-06-20 01:04 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	110
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
wmc	13
lcom	0
cbo	3
dl	0
loc	110
rs	10
c	0
b	0
f	0

9 Methods

Rating	Name	Size	Complexity
A	i18n_singular_name()	4	1
A	i18n_plural_name()	4	1
A	onBeforeWrite()	5	1
A	getUnitPrice()	4	1
A	getTotal()	4	1
A	getCalculatedTotal()	4	1
A	setCustomCalculatedTotal()	9	2
A	setCustomDescription()	9	2
A	getTableSubTitle()	9	3

<?php




class GiftVoucherProductPage_ProductOrderItem extends Product_OrderItem
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        'ValueSet' => 'Currency',
        'Description' => 'Varchar(40)'
    );

    /* standard SS method.
    *
    * @var array
    */
    private static $api_access = array(

        'view' => array(
            'CalculatedTotal',
            'TableTitle',
            'TableSubTitleNOHTML',
            'Name',
            'TableValue',
            'Quantity',
            'BuyableID',
            'BuyableClassName',
            'Version',
            'UnitPrice',
            'Total',
            'Order',
            'InternalItemID',
        ),
    );

    /**
     * Standard SS variable.
     *
     * @var string
     */
    private static $singular_name = 'Order for Gift Item';

    public function i18n_singular_name()

    {
        return $this->Config()->get('singular_name');
    }

    /**
     * Standard SS variable.
     *
     * @var string
     */
    private static $plural_name = 'Orders for Gift Item';

    public function i18n_plural_name()

    {
        return $this->Config()->get('plural_name');
    }

    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        $this->CalculatedTotal = $this->ValueSet;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getUnitPrice($recalculate = false)

    {
        return $this->ValueSet;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getTotal($recalculate = false)
    {
        return $this->ValueSet * $this->Quantity;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getCalculatedTotal()
    {
        return $this->ValueSet * $this->Quantity;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * @param float $total
     * @return this

     */
    public function setCustomCalculatedTotal($total)
    {
        if (!$this->ValueSet) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->ValueSet = $total;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->write();
        }

        return $this;
    }

    /**
     * @param string $description
     * @return this

     */
    public function setCustomDescription($description)
    {
        if (! $this->Description) {

            $this->Description = $description;

            $this->write();
        }

        return $this;
    }

    public function getTableSubTitle()
    {
        $array = array();
        if ($this->Description || 1 == 1) {

            $array[] = Convert::raw2xml($this->Description);

        }
        $array[] = _t('GIFTVOUCHERPRODUCTPAGE.Value', 'Value: ').$this->UnitPriceAsMoney()->Nice();
        return implode('<br />', $array);
    }
}


1			<?php
2
3
4
5
6			class GiftVoucherProductPage_ProductOrderItem extends Product_OrderItem
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7			{
8			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
9			'ValueSet' => 'Currency',
10			'Description' => 'Varchar(40)'
11			);
12
13			/* standard SS method.
14			*
15			* @var array
16			*/
17			private static $api_access = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `$api_access` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
18			'view' => array(
19			'CalculatedTotal',
20			'TableTitle',
21			'TableSubTitleNOHTML',
22			'Name',
23			'TableValue',
24			'Quantity',
25			'BuyableID',
26			'BuyableClassName',
27			'Version',
28			'UnitPrice',
29			'Total',
30			'Order',
31			'InternalItemID',
32			),
33			);
34
35			/**
36			* Standard SS variable.
37			*
38			* @var string
39			*/
40			private static $singular_name = 'Order for Gift Item';
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `$singular_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
41			public function i18n_singular_name()
			0 ignored issues – show Documentation introduced 2018-02-21 04:04 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
42			{
43			return $this->Config()->get('singular_name');
44			}
45
46			/**
47			* Standard SS variable.
48			*
49			* @var string
50			*/
51			private static $plural_name = 'Orders for Gift Item';
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `$plural_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
52			public function i18n_plural_name()
			0 ignored issues – show Documentation introduced 2018-02-21 04:04 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
53			{
54			return $this->Config()->get('plural_name');
55			}
56
57			public function onBeforeWrite()
58			{
59			parent::onBeforeWrite();
60			$this->CalculatedTotal = $this->ValueSet;
			0 ignored issues – show Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `CalculatedTotal` does not exist on `object<GiftVoucherProductPage_ProductOrderItem>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `ValueSet` does not exist on `object<GiftVoucherProductPage_ProductOrderItem>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
61			}
62
63			public function getUnitPrice($recalculate = false)
			0 ignored issues – show Documentation introduced 2018-02-21 04:04 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
64			{
65			return $this->ValueSet;
			0 ignored issues – show Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `ValueSet` does not exist on `object<GiftVoucherProductPage_ProductOrderItem>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
66			}
67
68			public function getTotal($recalculate = false)
69			{
70			return $this->ValueSet * $this->Quantity;
			0 ignored issues – show Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `ValueSet` does not exist on `object<GiftVoucherProductPage_ProductOrderItem>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `Quantity` does not exist on `object<GiftVoucherProductPage_ProductOrderItem>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
71			}
72
73			public function getCalculatedTotal()
74			{
75			return $this->ValueSet * $this->Quantity;
			0 ignored issues – show Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `ValueSet` does not exist on `object<GiftVoucherProductPage_ProductOrderItem>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `Quantity` does not exist on `object<GiftVoucherProductPage_ProductOrderItem>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
76			}
77
78			/**
79			* @param float $total
80			* @return this
			0 ignored issues – show Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Should the return type not be `GiftVoucherProductPage_ProductOrderItem`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
81			*/
82			public function setCustomCalculatedTotal($total)
83			{
84			if (!$this->ValueSet) {
			0 ignored issues – show Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `ValueSet` does not exist on `object<GiftVoucherProductPage_ProductOrderItem>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
85			$this->ValueSet = $total;
			0 ignored issues – show Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `ValueSet` does not exist on `object<GiftVoucherProductPage_ProductOrderItem>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
86			$this->write();
87			}
88
89			return $this;
90			}
91
92			/**
93			* @param string $description
94			* @return this
			0 ignored issues – show Documentation introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report Should the return type not be `GiftVoucherProductPage_ProductOrderItem`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
95			*/
96			public function setCustomDescription($description)
97			{
98			if (! $this->Description) {
			0 ignored issues – show Bug introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `Description` does not seem to exist. Did you mean `description`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
99			$this->Description = $description;
			0 ignored issues – show Bug introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `Description` does not seem to exist. Did you mean `description`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
100			$this->write();
101			}
102
103			return $this;
104			}
105
106			public function getTableSubTitle()
107			{
108			$array = array();
109			if ($this->Description \|\| 1 == 1) {
			0 ignored issues – show Bug introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `Description` does not seem to exist. Did you mean `description`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
110			$array[] = Convert::raw2xml($this->Description);
			0 ignored issues – show Bug introduced 2017-01-03 01:18 UTC by Report Bug Copy Issue Report The property `Description` does not seem to exist. Did you mean `description`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
111			}
112			$array[] = _t('GIFTVOUCHERPRODUCTPAGE.Value', 'Value: ').$this->UnitPriceAsMoney()->Nice();
113			return implode('<br />', $array);
114			}
115			}
116

sunnysideup / silverstripe-gift_voucher

GiftVoucherProductPage_ProductOrderItem A last analyzed 2018-06-20 01:04 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

Duplication Side-by-Side

Filter issues like

GiftVoucherProductPage_ProductOrderItem A
last analyzed 2018-06-20 01:04 UTC