sunnysideup / silverstripe-geobrowser

code/BrowseCitiesPage.php

<?php

class BrowseCitiesPage extends BrowseAbstractPage
{

    /**
     * Standard SS static
     **/
    public static $icon = "geobrowser/images/treeicons/BrowseCitiesPage";

    /**
     * Standard SS static
     **/
    public static $default_parent = "BrowseRegionsPage";

    /**
     * Standard SS static
     **/
    public static $can_be_root = false;

    /**
     * Standard SS static
     **/
    public static $db = array(
        "Latitude" => "Double",
        "Longitude" => "Double",
        "TimeZone"=> "Varchar(10)",
        "County" => "Varchar(25)",
        "Code" => "Varchar(4)",
    );

    /**
     * Standard SS Static
     **/
    public static $defaults = array(
        "ShowInMenus" => false
    );
    
    /**
     * @param Array - $googleMapAddressArray: an array of geographic data provided by google maps
     * @param Int - $maxRadius: maximum number of kilometers (as the bird flies) between search point defined in $googleMapAddressArray and city found.
     * @return Object | false : returns a BrowseCitiesPage or false if nothing was found
     **/
    public static function get_clostest_city_page($googleMapAddressArray, $maxRadius = 500)
    {
        $cityPage = null;
        $suburbPage    = null;
        $bt = defined('DB::USE_ANSI_SQL') ? "\"" : "`";
        $existingDistance = $maxRadius+1;
        $newDistance = $maxRadius+1;
        $existingPage = null;
        $newPage = null;
        $radiusSelectionSQL = self::radiusDefinitionOtherTable($googleMapAddressArray[0], $googleMapAddressArray[1], "BrowseCitiesPage", "Latitude", "Longitude");
        $sqlQuery = new SQLQuery();
        $sqlQuery->select = array("{$bt}BrowseCitiesPage{$bt}.{$bt}ID{$bt}, ". $radiusSelectionSQL." as distance");
        $sqlQuery->from[] = "{$bt}BrowseCitiesPage{$bt}";
        $sqlQuery->where[] = $radiusSelectionSQL . " < ".$maxRadius;
        $sqlQuery->orderby = " distance ";
        $sqlQuery->limit = "1";

It seems like '1' of type string is incompatible with the declared type array of property $limit.

        $result = $sqlQuery->execute();
        $page = null;
        foreach ($result as $row) {
            $existingDistance = $row["distance"];
            $existingPage = DataObject::get_by_id("BrowseCitiesPage", $row["ID"]);
        }
        $radiusSelectionSQL = self::radiusDefinitionOtherTable($googleMapAddressArray[0], $googleMapAddressArray[1], "cities", "Latitude", "Longitude");
        $sqlQuery = new SQLQuery();
        $sqlQuery->select = array("cities.CityID", $radiusSelectionSQL." as distance");
        $sqlQuery->from[] = "{$bt}cities{$bt}";
        $sqlQuery->where[] = $radiusSelectionSQL . " < ".$maxRadius;
        $sqlQuery->orderby = " distance ";
        $sqlQuery->limit = "1";
        $result = $sqlQuery->execute();
        foreach ($result as $row) {
            $sameOne = false;
            if ($existingPage) {
                if ($row["CityID"] == $existingPage->HiddenDataID) {
                    $sameOne = true;
                }
            }
            if (!$sameOne) {
                $newPage = self::create_city_and_parents($row["CityID"]);
                $newDistance = $row["distance"];
            }
        }
        if (($newPage) && ($newDistance < $existingDistance) &&  ($newDistance < $maxRadius)) {
            $cityPage = $newPage;
        } elseif ($existingPage && $existingDistance < $maxRadius) {
            $cityPage = $existingPage;
        }
        if ($cityPage) {
            if ($cityPage->allowBrowseChildren()) {

The method allowBrowseChildren does only exist in BrowseCitiesPage, but not in DataObject.

                $suburbPage = BrowseSuburbPage::create_suburb($googleMapAddressArray, $cityPage);
            }
        }
        if ($suburbPage) {
            return $suburbPage;
        }
        return $cityPage;
    }

    /**
     * formulae for working out distance
     **/
    protected static function radiusDefinitionOtherTable($lon, $lat, $table, $latitudeField, $longitudeField)
    {
        $bt = defined('DB::USE_ANSI_SQL') ? "\"" : "`";
        return "(6378.137 * ACOS( ( SIN( PI( ) * ".$lat." /180 ) * SIN( PI( ) * {$bt}".$table."{$bt}.{$bt}".$latitudeField."{$bt} /180 ) ) + ( COS( PI( ) * ".$lat." /180 ) * cos( PI( ) * {$bt}".$table."{$bt}.{$bt}".$latitudeField."{$bt} /180 ) * COS( (PI( ) * {$bt}".$table."{$bt}.{$bt}".$longitudeField."{$bt} /180 ) - ( PI( ) *".$lon." /180 ) ) ) ) ) ";
    }

    /**
     * name for page level.
     **/
    public function GeoLevelName()
    {
        return "Cities";
    }
    
    /**
     * number for page level.
     **/
    public function GeoLevelNumber()
    {
        return 3;
    }
    
    /**
     * This static method creates a city page and all the required parent pages...
     *@param Int - $CityID: the ID for the city to create
     **/
    public static function create_city_and_parents($CityID)
    {
        $cityPage = null;
        //check if the city exists at all
        $sql = '
			SELECT cities.RegionID, regions.CountryID, countries.ContinentID From cities, regions, countries, continents
			WHERE
				cities.RegionID = regions.RegionID AND
				regions.CountryID = countries.CountryID AND
				countries.ContinentID = continents.ContinentID AND
				cities.CityID = '.$CityID.'
			LIMIT 1;';
        $result = DB::query($sql);

        foreach ($result as $row) {
            break;
        }
        $abstractHelpPage = new BrowseAbstractPage();
        if ($row) {

The expression $row of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            //1 check if world exists
            if ($worldPage = DataObject::get_one("BrowseWorldPage")) {
                //do nothing
            } else {
                $worldPage = new BrowseWorldPage();
                $name = "Find";
                $worldPage->Title = $name;
                $worldPage->MetaTitle = $name;
                $worldPage->MenuTitle = $name;
                $worldPage->writeToStage('Stage');
                $worldPage->publish('Stage', 'Live');
                $worldPage->flushCache();
            }

            //2 check if continent exists
            $ContinentID = $row["ContinentID"];

The variable $row seems to be defined by a foreach iteration on line 145. Are you sure the iterator is never empty, otherwise this variable is not defined?

            if ($continentPage = DataObject::get_one("BrowseContinentsPage", 'HiddenDataID = '.$ContinentID)) {
                //debug::show("continent exists");
            } else {
                //create continent
                $continents = $abstractHelpPage->getDataFromTable("continents", "ContinentID = ".$ContinentID, null);
                foreach ($continents as $continentData) {
                    $continentPage = new BrowseContinentsPage();
                    $continentPage->CreateContinent($continentData, $worldPage);
                }
            }

            //3 check if country exists
            $CountryID = $row["CountryID"];
            if ($countryPage = DataObject::get_one("BrowseCountriesPage", 'HiddenDataID = '.$CountryID)) {
                //debug::show("country exists");
            } else {
                //create Country
                $countries = $abstractHelpPage->getDataFromTable("countries", "CountryID = ".$CountryID, null);
                foreach ($countries as $countryData) {
                    $countryPage = new BrowseCountriesPage();
                    $countryPage->CreateCountry($countryData, $continentPage);
                }
            }

            //4 check if region exists
            $RegionID = $row["RegionID"];
            if ($regionPage = DataObject::get_one("BrowseRegionsPage", 'HiddenDataID = '.$RegionID)) {
                //debug::show("region exists");
            } else {
                //create region
                $regions = $abstractHelpPage->getDataFromTable("regions", "RegionID = ".$RegionID, null);
                foreach ($regions as $regionData) {
                    $regionPage = new BrowseRegionsPage();
                    $regionPage->CreateRegion($regionData, $countryPage);
                }
            }
            if ($cityPage = DataObject::get_one("BrowseCitiesPage", 'HiddenDataID = '.$CityID)) {
                //debug::show("city exists");
            } else {
                //create region
                $cities = $abstractHelpPage->getDataFromTable("cities", "CityID = ".$CityID, null);
                foreach ($cities as $city) {
                    $cityPage = new BrowseCitiesPage();
                    $cityPage->CreateCity($city, $regionPage);
                }
            }
        }
        return $cityPage;
    }

    /**
     * fix URLS
     * NOTE: you must set get variables: urls, from and to....
     **/
    public function requireDefaultRecords()
    {
        parent::requireDefaultRecords();
        if (isset($_GET["urls"]) && isset($_GET["from"]) && isset($_GET["to"])) {
            $dos = DataObject::get("SiteTree", null, null, null, $_GET["from"].','.$_GET["to"]);
            foreach ($dos as $page) {
                if (isset($page)) {
                    echo "<li>fixing ".$page->Title."</li>";
                    $page->URLSegment = $this->generateURLSegment($page->Title);
                    $page->writeToStage('Stage');
                    $page->publish('Stage', 'Live');
                    $page->flushCache();
                    $page->detroy();
                }
            }
        }
    }

    /**
     * Create a page
     * @param Array - $city: the data for the city
     * @param Object $parent: BrowseRegionsPage
     **/
    public function CreateCity(array $city, BrowseRegionsPage $parent)
    {
        if ($parent && isset($city["City"])) {
            $name = htmlentities($city["City"]);
            if (isset($name)) {
                if (isset($_GET["geobuild"])) {
                    echo "<li>creating ".$name."</li>";
                }
                $this->ParentID = $parent->ID;
                $this->Title = $name;
                $this->MetaTitle = $name;
                $this->MenuTitle = $name;
                $this->HiddenDataID = $city["CityID"];

                $this->Code = $city["Code"];
                $this->Latitude = $city["Latitude"];
                $this->Longitude = $city["Longitude"];
                $this->TimeZone = $city["TimeZone"];
                $this->County = htmlentities($city["County"]);
                $this->Code = $city["Code"];

                $this->CreateChildren = $parent->CreateAllChildren;
                $this->CreateAllChildren = $parent->CreateAllChildren;

                $this->URLSegment = $this->generateURLSegment($this->Title);

                $this->writeToStage('Stage');
                $this->publish('Stage', 'Live');
                $this->flushCache();
            } else {
                if (isset($_GET["geobuild"])) {
                    debug::show("No name can be found");
                }
            }
        } else {
            if (isset($_GET["geobuild"])) {
                debug::show("Parent does not exist");
            }
        }
    }
}

class BrowseCitiesPage_Controller extends BrowseAbstractPage_Controller
{
}