sunnysideup / silverstripe-geobrowser

code/BrowseAbstractPage.php

<?php

class BrowseAbstractPage extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     * Standard SS static
     **/
    public static $db = array(
        "CreateChildren" => "Boolean",
        "CreateAllChildren" => "Boolean",
        "HiddenDataID" => "Int",
        "AlternativeURL" => "Varchar",
        "ExtraNote" => "Varchar(255)"
    );

    /**
     * Standard SS static
     **/
    public static $breadcrumbs_delimiter = " » ";

    /**
     * Standard SS method: can only create if the parent exists...
     **/
    public function canCreate($member = null)

The return type could not be reliably inferred; please add a @return annotation.

    {
        $bt = defined('DB::USE_ANSI_SQL') ? "\"" : "`";

$bt is not used, you could remove the assignment.

        if ("BrowseAbstractPage" == $this->ClassName) {
            return false;
        } else {
            return parent::canCreate();
        }
    }

    /**
     * Name of the level
     **/
    public function GeoLevelName()
    {
        return "No level";
    }

    /**
     * Number of the level
     **/
    public function GeoLevelNumber()
    {
        return -1;
    }


    /**
     * works out if the child page needs to be created
     **/
    public function allowBrowseChildren()
    {
        if (DataObject::get_one("BrowseWorldPage")->LevelOfDetail > $this->GeoLevelNumber()) {

The if-else statement can be simplified to return \DataObject::get_one('BrowseWorldPage')->LevelOfDetail > $this->GeoLevelNumber();.

            return true;
        } else {
            return false;
        }
    }

    /**
     * retrieves data from a DB table that is not part of the DataObject Model.
     **/
    protected function getDataFromTable($tableName, $where  = null, $orderby = null)
    {
        $sqlQuery = new SQLQuery();

The class SQLQuery has been deprecated with message: since version 4.0

        $sqlQuery->select = array('*');
        $sqlQuery->from = array($tableName);
        if ($where) {
            $sqlQuery->where = array($where);
        }
        if ($orderby) {
            $sqlQuery->orderby = $orderby;
        }
        $result = $sqlQuery->execute();
        return $result;
    }

    /**
     * standard SS method
     **/
    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $fields = parent::getCMSFields();
        $fields->addFieldToTab("Root.Content.AddSubRegion", new CheckboxField("CreateChildren", "Create Child Pages (e.g. countries below continents)"));
        $fields->addFieldToTab("Root.Content.AddSubRegion", new CheckboxField("CreateAllChildren", "Create All Child Pages (e.g. countries, regions, and cities below continents)"));
        //$fields->addFieldToTab("Root.Content.AddSubRegion", new ReadonlyField("HiddenDataID", "Data ID number (should have number)"));

73% of this comment could be valid code. Did you maybe forget this after debugging?

        $fields->addFieldToTab("Root.Content.AddSubRegion", new LiteralField("build", "Create now... ", '<a href="db/build/?flush=1&geobuild=1">create pages now</a>'));

The call to LiteralField::__construct() has too many arguments starting with '<a href="db/build/?flush=1&geobuild=1">create pages now</a>'.

        if (!$this->allowBrowseChildren()) {
            $fields->removeFieldFromTab("Root.Content.AddSubRegion", "CreateChildren");
            $fields->removeFieldFromTab("Root.Content.AddSubRegion", "CreateAllChildren");
        }

        $fields->addFieldsToTab('Root.Content.Main', new TextField('AlternativeURL', 'Alternative URL'));

        return $fields;
    }

    /**
     * standard SS method
     **/
    public function onBeforeWrite()

The return type could not be reliably inferred; please add a @return annotation.

    {
        if ($this->CreateAllChildren) {
            $this->CreateChildren = 1;
        }
        return parent::onBeforeWrite();
    }
}

class BrowseAbstractPage_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
}