BrowseCountriesPage::requireDefaultRecords() - Code Metrics - sunnysideup/silverstripe-geobrowser - Measure and Improve Code Quality continuously with Scrutinizer

BrowseCountriesPage::requireDefaultRecords() C
last analyzed 2018-03-20 01:16 UTC

↳ Parent: BrowseCountriesPage

Complexity

Conditions	11
Paths	14

Size

Total Lines	26
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	26
rs	5.2653
c	0
b	0
f	0
cc	11
eloc	18
nc	14
nop	0

How to fix Complexity

<?php

class BrowseCountriesPage extends BrowseAbstractPage
namespace YourVendor;

class YourClass { }
{

    /**
     * Standard SS static
     **/
    public static $icon = "geobrowser/images/treeicons/BrowseCountriesPage";

    /**
     * Standard SS static
     **/
    public static $allowed_children = array("BrowseRegionsPage");

    /**
     * Standard SS static
     **/
    public static $default_child = "BrowseRegionsPage";

    /**
     * Standard SS static
     **/
    public static $default_parent = "BrowseContinentsPage";
    
    /**
     * Standard SS static
     **/
    public static $can_be_root = false;

    /**
     * Standard SS static
     **/
    public static $db = array(
        "Country" => "Varchar(50)" ,
        "ISO2" => "Varchar(2)" ,
        "Internet" => "Varchar(2)" ,
        "Capital" => "Varchar(25)" ,
        "NationalitySingular" => "Varchar(35)" ,
        "NationalityPlural" => "Varchar(35)" ,
        "Currency" => "Varchar(30)" ,
        "CurrencyCode" => "Varchar(3)" ,
        "Population" => "Int" ,
        "AdditionalTitle" => "Varchar(50)"
    );


    /**
     * Standard SS Static
     **/
    public static $defaults = array(
        "ShowInMenus" => false
    );
    
    /**
     * Standard SS Method
     **/
    public function getCMSFields()

    {
        $fields = parent::getCMSFields();
        return $fields;
    }

    public function GeoLevelName()
    {
        return "Countries";
    }

    public function GeoLevelNumber()
    {
        return 1;
    }

    /**
     * Standard SS Method
     * Setup records
     *
     **/
    public function requireDefaultRecords()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        parent::requireDefaultRecords();
        $bt = defined('DB::USE_ANSI_SQL') ? "\"" : "`";
        $parents = DataObject::get("BrowseCountriesPage");
        if ($parents && isset($_GET["geobuild"]) && $_GET["geobuild"] && $this->allowBrowseChildren()) {
            foreach ($parents as $parent) {
                if ($parent->HiddenDataID) {
                    echo "<li>creating regions for ".$parent->Title."<ul>";
                    $regions = $this->getDataFromTable("regions", "CountryID = ".$parent->HiddenDataID, "Region");
                    foreach ($regions as $region) {
                        if (!DataObject::get("BrowseRegionsPage", "{$bt}BrowseAbstractPage{$bt}.{$bt}HiddenDataID{$bt} = ".$region["RegionID"])) {
                            $page = new BrowseRegionsPage();
                            $page->CreateRegion($region, $parent);
                            $page->destroy();
                        }
                    }
                    echo "</ul></li>";
                } else {
                    if (isset($_GET["geobuild"])) {
                        debug::show("Parent does not exist");
                    }
                }
            }
        }
    }

    /**
     * Create a country based on an array and a Continent Parent
     **/
    public function CreateCountry(array $country, BrowseContinentsPage $parent)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if ($parent && isset($country["Country"])) {
            $name = htmlentities($country["Country"]);
            if ($name) {
                if (isset($_GET["geobuild"])) {
                    echo "<li>creating ".$name."</li>";
                }
                $this->ParentID = $parent->ID;
                $this->Title = $name;
                $this->MetaTitle = $name;
                $this->MenuTitle = $name;
                $this->HiddenDataID = $country["CountryID"];
                $this->ISO2 = $country["ISO2"];
                $this->Internet = $country["Internet"];
                $this->Capital = htmlentities($country["Capital"]);
                $this->NationalitySingular = htmlentities($country["NationalitySingular"]);
                $this->NationalityPlural = htmlentities($country["NationalityPlural"]);
                $this->Currency = $country["Currency"];
                $this->CurrencyCode = $country["CurrencyCode"];
                $this->Population = $country["Population"];
                $this->AdditionalTitle = htmlentities($country["Title"]);

                $this->CreateChildren = $parent->CreateAllChildren;
                $this->CreateAllChildren = $parent->CreateAllChildren;

                $this->writeToStage('Stage');
                $this->publish('Stage', 'Live');
                $this->flushCache();
            } else {
                if (isset($_GET["geobuild"])) {
                    debug::show("name does not exist");
                }
            }
        } else {
            if (isset($_GET["geobuild"])) {
                debug::show("Parent does not exist");
            }
        }
    }
}

class BrowseCountriesPage_Controller extends BrowseAbstractPage_Controller
namespace YourVendor;

class YourClass { }
{
}


1			<?php
2
3			class BrowseCountriesPage extends BrowseAbstractPage
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:19 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5
6			/**
7			* Standard SS static
8			**/
9			public static $icon = "geobrowser/images/treeicons/BrowseCountriesPage";
10
11			/**
12			* Standard SS static
13			**/
14			public static $allowed_children = array("BrowseRegionsPage");
15
16			/**
17			* Standard SS static
18			**/
19			public static $default_child = "BrowseRegionsPage";
20
21			/**
22			* Standard SS static
23			**/
24			public static $default_parent = "BrowseContinentsPage";
25
26			/**
27			* Standard SS static
28			**/
29			public static $can_be_root = false;
30
31			/**
32			* Standard SS static
33			**/
34			public static $db = array(
35			"Country" => "Varchar(50)" ,
36			"ISO2" => "Varchar(2)" ,
37			"Internet" => "Varchar(2)" ,
38			"Capital" => "Varchar(25)" ,
39			"NationalitySingular" => "Varchar(35)" ,
40			"NationalityPlural" => "Varchar(35)" ,
41			"Currency" => "Varchar(30)" ,
42			"CurrencyCode" => "Varchar(3)" ,
43			"Population" => "Int" ,
44			"AdditionalTitle" => "Varchar(50)"
45			);
46
47
48			/**
49			* Standard SS Static
50			**/
51			public static $defaults = array(
52			"ShowInMenus" => false
53			);
54
55			/**
56			* Standard SS Method
57			**/
58			public function getCMSFields()
			0 ignored issues – show Documentation introduced 2018-02-21 04:03 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
59			{
60			$fields = parent::getCMSFields();
61			return $fields;
62			}
63
64			public function GeoLevelName()
65			{
66			return "Countries";
67			}
68
69			public function GeoLevelNumber()
70			{
71			return 1;
72			}
73
74			/**
75			* Standard SS Method
76			* Setup records
77			*
78			**/
79			public function requireDefaultRecords()
			0 ignored issues – show Coding Style introduced 2018-02-21 04:03 UTC by Report Bug Copy Issue Report `requireDefaultRecords` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
80			{
81			parent::requireDefaultRecords();
82			$bt = defined('DB::USE_ANSI_SQL') ? "\"" : "`";
83			$parents = DataObject::get("BrowseCountriesPage");
84			if ($parents && isset($_GET["geobuild"]) && $_GET["geobuild"] && $this->allowBrowseChildren()) {
85			foreach ($parents as $parent) {
86			if ($parent->HiddenDataID) {
87			echo "<li>creating regions for ".$parent->Title."<ul>";
88			$regions = $this->getDataFromTable("regions", "CountryID = ".$parent->HiddenDataID, "Region");
89			foreach ($regions as $region) {
90			if (!DataObject::get("BrowseRegionsPage", "{$bt}BrowseAbstractPage{$bt}.{$bt}HiddenDataID{$bt} = ".$region["RegionID"])) {
91			$page = new BrowseRegionsPage();
92			$page->CreateRegion($region, $parent);
93			$page->destroy();
94			}
95			}
96			echo "</ul></li>";
97			} else {
98			if (isset($_GET["geobuild"])) {
99			debug::show("Parent does not exist");
100			}
101			}
102			}
103			}
104			}
105
106			/**
107			* Create a country based on an array and a Continent Parent
108			**/
109			public function CreateCountry(array $country, BrowseContinentsPage $parent)
			0 ignored issues – show Coding Style introduced 2018-02-21 04:03 UTC by Report Bug Copy Issue Report `CreateCountry` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
110			{
111			if ($parent && isset($country["Country"])) {
112			$name = htmlentities($country["Country"]);
113			if ($name) {
114			if (isset($_GET["geobuild"])) {
115			echo "<li>creating ".$name."</li>";
116			}
117			$this->ParentID = $parent->ID;
118			$this->Title = $name;
119			$this->MetaTitle = $name;
120			$this->MenuTitle = $name;
121			$this->HiddenDataID = $country["CountryID"];
122			$this->ISO2 = $country["ISO2"];
123			$this->Internet = $country["Internet"];
124			$this->Capital = htmlentities($country["Capital"]);
125			$this->NationalitySingular = htmlentities($country["NationalitySingular"]);
126			$this->NationalityPlural = htmlentities($country["NationalityPlural"]);
127			$this->Currency = $country["Currency"];
128			$this->CurrencyCode = $country["CurrencyCode"];
129			$this->Population = $country["Population"];
130			$this->AdditionalTitle = htmlentities($country["Title"]);
131
132			$this->CreateChildren = $parent->CreateAllChildren;
133			$this->CreateAllChildren = $parent->CreateAllChildren;
134
135			$this->writeToStage('Stage');
136			$this->publish('Stage', 'Live');
137			$this->flushCache();
138			} else {
139			if (isset($_GET["geobuild"])) {
140			debug::show("name does not exist");
141			}
142			}
143			} else {
144			if (isset($_GET["geobuild"])) {
145			debug::show("Parent does not exist");
146			}
147			}
148			}
149			}
150
151			class BrowseCountriesPage_Controller extends BrowseAbstractPage_Controller
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:19 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2017-01-03 01:19 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
152			{
153			}
154

sunnysideup / silverstripe-geobrowser

BrowseCountriesPage::requireDefaultRecords() C last analyzed 2018-03-20 01:16 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

BrowseCountriesPage::requireDefaultRecords() C
last analyzed 2018-03-20 01:16 UTC