Issues in FlashObject.php (master) - Issues in master - sunnysideup/silverstripe-flash - Measure and Improve Code Quality continuously with Scrutinizer

Issues (15)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/FlashObject.php (6 issues)

Labels

Severity

Minor 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
    @ see http://code.google.com/p/swfobject/wiki/documentation
    @ see http://www.swffix.org/swfobject/generator/
*/

class FlashObject extends ViewableData
namespace YourVendor;

class YourClass { }
{
    protected static $use_dynamic_insert = true;

    protected static $title = "MyFlashObjectTitle";

    protected static $filename = "flashObject.swf";

    protected static $flash_file_div_id = "FlashObject";

    protected static $width = 200;

    protected static $height = 200;

    protected static $flash_version = "6.0.0";

    protected static $alternative_content = '<a href="http://www.adobe.com/go/getflashplayer">get flash player</a>'; //no image here to save bandwidth

    protected static $param_array = array();

    protected static $external_flash_file = '';

    public function CreateFlashObject($Title = '', $FlashFileDivID = '', $FlashFilename = '', $AlternativeContent = '', $Width = 0, $Height = 0, $FlashVersion = '', $ParamArray = array(), $javascriptAlreadyAdded = false)
    {
        if (!$Title) {
            $Title  = self::$title ;
        }
        $Title = Convert::raw2js($Title);
        if (!$FlashFileDivID) {
            $FlashFileDivID  = self::$flash_file_div_id ;
        }
        $FlashFileID = Convert::raw2js($FlashFileDivID);
        if (!$AlternativeContent) {
            $AlternativeContent = self::$alternative_content;
        }
        if (!$Width) {
            $Width = self::$width;
        }
        $Width = intval($Width);
        if (!$Height) {
            $Height = self::$height;
        }
        $Height = intval($Height);
        if (!$FlashVersion) {
            $FlashVersion = self::$flash_version;
        }
        if (!$ParamArray) {

            $ParamArray = self::$param_array;
        }
        if (!$FlashFilename) {
            $FlashFilename = self::$filename;
        }
        $FlashFilename = Convert::raw2js($FlashFilename);
        $doSet = new DataObjectSet();
        if ($FlashFilename) {
            $params = '';
            $paramsJS = '';
            foreach ($ParamArray as $key=>$value) {
                $params .= '<param name="'.$key.'" value="'.Convert::Raw2ATT($value).'" />';
                $paramsJS .= '
					params.'.$key.' = "'.$value.'";';
            }
            $record = array(
                'ID' => $FlashFileID ,
                'FileName' => $FlashFilename,
                'Title' => $Title,
                'Width' => intval($Width),
                'Height' => intval($Height),
                'FlashVersion' => $FlashVersion,
                'AlternativeContent' => $AlternativeContent,
                'Parameters' => $params,
                'UseDynamicInsert' => self::$use_dynamic_insert
            );
            $doSet->push(new ArrayData($record));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            if (!$javascriptAlreadyAdded) {
                if (self::$use_dynamic_insert) {
                    $js = '
						jQuery(document).ready(
							function () {
								jQuery(".FlashAlternativeContent").hide();
								var flashvars = {};
								var params = {};
								'.$paramsJS.'
								var attributes = {};
								attributes.id = "'.$FlashFileDivID.'";
								swfobject.embedSWF("'.$FlashFilename.'", "'.$FlashFileDivID.'", "'.$Width.'", "'.$Height.'", "'.$FlashVersion.'","flash/swfobject/expressInstall.swf", flashvars, params, attributes);
								jQuery(".FlashAlternativeContent").fadeIn(3000);
							}
						);';
                } else {
                    $js = '
						jQuery(document).ready(
							function () {
								swfobject.registerObject("'.$FlashFileDivID.'", "'.$FlashVersion.'", "flash/swfobject/expressInstall.swf");
							}
						);';
                }
                Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
                Requirements::javascript("flash/javascript/swfobject.js");
                Requirements::customScript($js);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }
        }
        return $doSet;
    }


    public function CreateYouTubeVideo($title, $code, $width = 640, $height = 385, $fullScreen = false)
    {
        //important!
        self::$use_dynamic_insert = true;
        $code = trim($code);
        $id = self::$flash_file_div_id.$code;
        Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
        Requirements::javascript("flash/javascript/swfobject.js");
        Requirements::javascript("flash/javascript/YouTube.js");
        if ($fullScreen) {
            self::$width = 0;
            self::$height = 0;
            $call = 'YouTube.loadFullScreenVideo(\''.$code.'\');';
        } else {
            $call = 'YouTube.loadVideo(\''.$code.'\', '.$width.', '.$height.');';
        }
        $js = '
;(function($) {
	$(document).ready(
		function() {
			YouTube.setElementID(\''.$id.'\');
			'.$call.'
			jQuery("#wrapperFor-'.$id.'").click(
				function() {YouTube.loadNew("'.$code.'"); return false;}
			)
		}
	);
})(jQuery);';
        Requirements::customScript($js, "load".$code);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        return $this->CreateFlashObject(
            $title,
            $id,
            'http://www.youtube.com/v/'.$code.'?fs=1&amp;hl=en_US',
            '',
            $width,
            $height,
            0,
            self::$param_array/*,
            true //important!*/
        );
    }

    public static function has_external_flash_file()
    {
        self::$external_flash_file ? true : false;
    }
    public static function set_use_dynamic_insert($value)
    {
        self::$use_dynamic_insert = $value;
    }
    public static function set_filename($value)
    {
        self::$filename = $value;
    }
    public static function set_default_div_id($value)
    {
        self::$flash_file_div_id = $value;
    }
    public static function set_default_width($value)
    {
        self::$width = $value;
    }
    public static function set_default_height($value)
    {
        self::$height = $value;
    }
    public static function set_default_flash_version($value)
    {
        self::$flash_version = $value;
    }
    public static function set_default_alternative_content($value)
    {
        self::$alternative_content = $value;
    }
    public static function set_default_external_flash_file($value)
    {
        self::$external_flash_file = $value;
    }
    public static function add_param($name, $value)
    {
        self::$param_array[$name] = $value;
    }
}


1			<?php
2			/*
3			@ see http://code.google.com/p/swfobject/wiki/documentation
4			@ see http://www.swffix.org/swfobject/generator/
5			*/
6
7			class FlashObject extends ViewableData
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
8			{
9			protected static $use_dynamic_insert = true;
10
11			protected static $title = "MyFlashObjectTitle";
12
13			protected static $filename = "flashObject.swf";
14
15			protected static $flash_file_div_id = "FlashObject";
16
17			protected static $width = 200;
18
19			protected static $height = 200;
20
21			protected static $flash_version = "6.0.0";
22
23			protected static $alternative_content = '<a href="http://www.adobe.com/go/getflashplayer">get flash player</a>'; //no image here to save bandwidth
24
25			protected static $param_array = array();
26
27			protected static $external_flash_file = '';
28
29			public function CreateFlashObject($Title = '', $FlashFileDivID = '', $FlashFilename = '', $AlternativeContent = '', $Width = 0, $Height = 0, $FlashVersion = '', $ParamArray = array(), $javascriptAlreadyAdded = false)
30			{
31			if (!$Title) {
32			$Title = self::$title ;
33			}
34			$Title = Convert::raw2js($Title);
35			if (!$FlashFileDivID) {
36			$FlashFileDivID = self::$flash_file_div_id ;
37			}
38			$FlashFileID = Convert::raw2js($FlashFileDivID);
39			if (!$AlternativeContent) {
40			$AlternativeContent = self::$alternative_content;
41			}
42			if (!$Width) {
43			$Width = self::$width;
44			}
45			$Width = intval($Width);
46			if (!$Height) {
47			$Height = self::$height;
48			}
49			$Height = intval($Height);
50			if (!$FlashVersion) {
51			$FlashVersion = self::$flash_version;
52			}
53			if (!$ParamArray) {
			0 ignored issues – show Bug Best Practice introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$ParamArray` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
54			$ParamArray = self::$param_array;
55			}
56			if (!$FlashFilename) {
57			$FlashFilename = self::$filename;
58			}
59			$FlashFilename = Convert::raw2js($FlashFilename);
60			$doSet = new DataObjectSet();
61			if ($FlashFilename) {
62			$params = '';
63			$paramsJS = '';
64			foreach ($ParamArray as $key=>$value) {
65			$params .= '<param name="'.$key.'" value="'.Convert::Raw2ATT($value).'" />';
66			$paramsJS .= '
67			params.'.$key.' = "'.$value.'";';
68			}
69			$record = array(
70			'ID' => $FlashFileID ,
71			'FileName' => $FlashFilename,
72			'Title' => $Title,
73			'Width' => intval($Width),
74			'Height' => intval($Height),
75			'FlashVersion' => $FlashVersion,
76			'AlternativeContent' => $AlternativeContent,
77			'Parameters' => $params,
78			'UseDynamicInsert' => self::$use_dynamic_insert
79			);
80			$doSet->push(new ArrayData($record));
			0 ignored issues – show Documentation introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \ArrayData($record)` is of type `object<ArrayData>`, but the function expects a `object<DataObject>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
81			if (!$javascriptAlreadyAdded) {
82			if (self::$use_dynamic_insert) {
83			$js = '
84			jQuery(document).ready(
85			function () {
86			jQuery(".FlashAlternativeContent").hide();
87			var flashvars = {};
88			var params = {};
89			'.$paramsJS.'
90			var attributes = {};
91			attributes.id = "'.$FlashFileDivID.'";
92			swfobject.embedSWF("'.$FlashFilename.'", "'.$FlashFileDivID.'", "'.$Width.'", "'.$Height.'", "'.$FlashVersion.'","flash/swfobject/expressInstall.swf", flashvars, params, attributes);
93			jQuery(".FlashAlternativeContent").fadeIn(3000);
94			}
95			);';
96			} else {
97			$js = '
98			jQuery(document).ready(
99			function () {
100			swfobject.registerObject("'.$FlashFileDivID.'", "'.$FlashVersion.'", "flash/swfobject/expressInstall.swf");
101			}
102			);';
103			}
104			Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
105			Requirements::javascript("flash/javascript/swfobject.js");
106			Requirements::customScript($js);
			0 ignored issues – show Documentation introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$js` is of type `string`, but the function expects a `object<The>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
107			}
108			}
109			return $doSet;
110			}
111
112
113			public function CreateYouTubeVideo($title, $code, $width = 640, $height = 385, $fullScreen = false)
114			{
115			//important!
116			self::$use_dynamic_insert = true;
117			$code = trim($code);
118			$id = self::$flash_file_div_id.$code;
119			Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
120			Requirements::javascript("flash/javascript/swfobject.js");
121			Requirements::javascript("flash/javascript/YouTube.js");
122			if ($fullScreen) {
123			self::$width = 0;
124			self::$height = 0;
125			$call = 'YouTube.loadFullScreenVideo(\''.$code.'\');';
126			} else {
127			$call = 'YouTube.loadVideo(\''.$code.'\', '.$width.', '.$height.');';
128			}
129			$js = '
130			;(function($) {
131			$(document).ready(
132			function() {
133			YouTube.setElementID(\''.$id.'\');
134			'.$call.'
135			jQuery("#wrapperFor-'.$id.'").click(
136			function() {YouTube.loadNew("'.$code.'"); return false;}
137			)
138			}
139			);
140			})(jQuery);';
141			Requirements::customScript($js, "load".$code);
			0 ignored issues – show Documentation introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$js` is of type `string`, but the function expects a `object<The>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2017-01-03 01:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'load' . $code` is of type `string`, but the function expects a `object<Use>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
142			return $this->CreateFlashObject(
143			$title,
144			$id,
145			'http://www.youtube.com/v/'.$code.'?fs=1&hl=en_US',
146			'',
147			$width,
148			$height,
149			0,
150			self::$param_array/*,
151			true //important!*/
152			);
153			}
154
155			public static function has_external_flash_file()
156			{
157			self::$external_flash_file ? true : false;
158			}
159			public static function set_use_dynamic_insert($value)
160			{
161			self::$use_dynamic_insert = $value;
162			}
163			public static function set_filename($value)
164			{
165			self::$filename = $value;
166			}
167			public static function set_default_div_id($value)
168			{
169			self::$flash_file_div_id = $value;
170			}
171			public static function set_default_width($value)
172			{
173			self::$width = $value;
174			}
175			public static function set_default_height($value)
176			{
177			self::$height = $value;
178			}
179			public static function set_default_flash_version($value)
180			{
181			self::$flash_version = $value;
182			}
183			public static function set_default_alternative_content($value)
184			{
185			self::$alternative_content = $value;
186			}
187			public static function set_default_external_flash_file($value)
188			{
189			self::$external_flash_file = $value;
190			}
191			public static function add_param($name, $value)
192			{
193			self::$param_array[$name] = $value;
194			}
195			}
196

sunnysideup / silverstripe-flash

Issues (15)

Security Analysis no request data

code/FlashObject.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like