FaqOnePage

Complexity

Total Complexity

3

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	i18n_singular_name()	0	4	1
A	i18n_plural_name()	0	4	1
A	getCMSFields()	0	8	1

<?php
/**
 *@author nicolaas[at] sunnysideup.co.nz
 *@description: individual FAQ page. Usually, these are not viewed as they can be read completely from the parent (FAQ HOLDER) page.
 */
class FaqOnePage extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $icon = "mysite/images/treeicons/FaqOnePage";

The property $icon is not used and could be removed.

    private static $description = "Individual FAQ Page, displays the answer to one question";

The property $description is not used and could be removed.

    private static $default_parent = 'FaqHolderPage';

The property $default_parent is not used and could be removed.

    private static $can_be_root = false;

The property $can_be_root is not used and could be removed.

    private static $allowed_children = "none";

The property $allowed_children is not used and could be removed.

    private static $defaults = array(

The property $defaults is not used and could be removed.

        'ShowInMenus' => 0
    );

    private static $has_one = array();

The property $has_one is not used and could be removed.

    /**
     * Standard SS variable.
     */
    private static $singular_name = "FAQ Page";

The property $singular_name is not used and could be removed.

    public function i18n_singular_name()
    {
        return _t("FAQPage.SINGULARNAME", "FAQ Page");
    }

    /**
     * Standard SS variable.
     */
    private static $plural_name = "FAQ Pages";

The property $plural_name is not used and could be removed.

    public function i18n_plural_name()
    {
        return _t("FAQPage.PLURALNAME", "FAQ Pages");
    }

    //private static $has_many = array();

59% of this comment could be valid code. Did you maybe forget this after debugging?

    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $fields = parent::getCMSFields();
        $fields->replaceField("Title", new TextField("Title", "Question"));
        $fields->replaceField("MenuTitle", new TextField("MenuTitle", "Question - short version for menus"));
        $fields->replaceField("Content", new HtmlEditorField("Content", "Answer"));
        return $fields;
    }
}

class FaqOnePage_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public function init()
    {
        parent::init();
    }
}