FriendEmail - Code Metrics - sunnysideup/silverstripe-emailreferral - Measure and Improve Code Quality continuously with Scrutinizer

FriendEmail A
last analyzed 2018-03-20 01:14 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	5
lcom	0
cbo	1
dl	0
loc	51
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	ShortMessage()	4	1
A	getShortMessage()	4	1
A	canCreate()	4	1
A	canEdit()	4	1
A	canDelete()	4	1

<?php

class FriendEmail extends DataObject
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        'To' => 'Text',
        'Message' => 'Text',
        'From' => 'Text',
        'IPAddress' => 'Text'
    );

    private static $has_one = array(

        'Page' => 'Page'
    );

    private static $casting = array(

        "ShortMessage" => "Varchar"
    );

    public function ShortMessage()
    {
        return $this->getShortMessage();
    }
    public function getShortMessage()
    {
        return substr($this->Message, 0, 30);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function canCreate($member = null)
    {
        return false;
    }

    public function canEdit($member = null)
    {
        return false;
    }

    public function canDelete($member = null)
    {
        return false;
    }

    private static $searchable_fields = array('To', 'Message', 'From', 'IPAddress', 'Page.Title');


    private static $summary_fields = array('Created', 'To', 'ShortMessage', 'From', 'IPAddress', 'Page.Title');


    private static $singular_name = 'Message to Friend';


    private static $plural_name = 'Messages to Friends';


    private static $default_sort = 'Created DESC';

}


1			<?php
2
3			class FriendEmail extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
6			'To' => 'Text',
7			'Message' => 'Text',
8			'From' => 'Text',
9			'IPAddress' => 'Text'
10			);
11
12			private static $has_one = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
13			'Page' => 'Page'
14			);
15
16			private static $casting = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `$casting` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
17			"ShortMessage" => "Varchar"
18			);
19
20			public function ShortMessage()
21			{
22			return $this->getShortMessage();
23			}
24			public function getShortMessage()
25			{
26			return substr($this->Message, 0, 30);
			0 ignored issues – show Documentation introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `Message` does not exist on `object<FriendEmail>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
27			}
28
29			public function canCreate($member = null)
30			{
31			return false;
32			}
33
34			public function canEdit($member = null)
35			{
36			return false;
37			}
38
39			public function canDelete($member = null)
40			{
41			return false;
42			}
43
44			private static $searchable_fields = array('To', 'Message', 'From', 'IPAddress', 'Page.Title');
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `$searchable_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
45
46			private static $summary_fields = array('Created', 'To', 'ShortMessage', 'From', 'IPAddress', 'Page.Title');
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `$summary_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
47
48			private static $singular_name = 'Message to Friend';
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `$singular_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
49
50			private static $plural_name = 'Messages to Friends';
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `$plural_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
51
52			private static $default_sort = 'Created DESC';
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `$default_sort` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
53			}
54

sunnysideup / silverstripe-emailreferral

FriendEmail A last analyzed 2018-03-20 01:14 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like

FriendEmail A
last analyzed 2018-03-20 01:14 UTC