EmailAFriendForm - Code Metrics - sunnysideup/silverstripe-emailreferral - Measure and Improve Code Quality continuously with Scrutinizer

EmailAFriendForm B
last analyzed 2018-03-20 01:14 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	170
Duplicated Lines	3.53 %

Coupling/Cohesion

Components	1
Dependencies	18

Importance

Changes

Metric	Value
wmc	24
lcom	1
cbo	18
dl	6
loc	170
rs	7.3333
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	30	3
F	sendemailafriend()	6	100	21

How to fix Duplicated Code

<?php

class EmailAFriendForm extends Form
namespace YourVendor;

class YourClass { }
{

    /**
     * @var String
     */
    private static $friend_email_address_label = "Friend#039;s Email Address";


    /**
     * @var String
     */
    private static $message_label = "Message";


    /**
     * @var String
     */
    private static $your_email_address_label = "Your email address";


    /**
     * @var String
     */
    private static $send_label = 'Send';


    /**
     * yes or no
     * @var String
     */
    private static $mail_to_site_owner_only = 'no';


    /**
     * @param Controller $controller
     * @param String $name
     */
    public function __construct($controller, $name)
    {
        Requirements::themedCSS("EmailReferral", "emailreferral");
        Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
        Requirements::javascript("emailreferral/javascript/EmailReferralForm.js");

        $fields[] = new HiddenField('PageID', 'PageID', $controller->dataRecord->ID);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        $fields[] = new EmailField('YourMailAddress', $this->Config()->get("your_email_address_label"));
        $fields[] = new TextareaField(
            'Message',
            $this->Config()->get("message_label"),
            $this->Config()->get("EmailAFriendExtension", "default_message")
        );
        if ($this->Config()->get("mail_to_site_owner_only") != 'yes') {
            $fields[] = new LiteralField('AdditionalMessage', '<div id="additionalMessageStuff"><p>'.Director::absoluteURL($controller->Link()).'</p><p>Sent by: <span id="emailReplacer">[your email address]</span></p></div>');
            $fields[] = new EmailField('To', $this->Config()->get("friend_email_address_label"));
        }

        $fields = new FieldList($fields);

        $actions = new FieldList(new FormAction('sendemailafriend', $this->Config()->get("send_label")));
        if ($this->Config()->get("mail_to_site_owner_only") != 'yes') {
            $requiredFields = new RequiredFields(array('YourMailAddress', 'To', 'Message'));
        } else {
            $requiredFields = new RequiredFields(array('YourMailAddress', 'Message'));
        }

        parent::__construct($controller, $name, $fields, $actions, $requiredFields);
    }

    /**
     *
     * @param Array
     * @param EmailAFriendForm
     */
    public function sendemailafriend($RAW_data, $form)

    {
        $adminEmail = Config::inst()->get("Email", "admin_email");
        $data = Convert::raw2sql($RAW_data);
        if ($page = Page::get()->byID(intval($data['PageID']))) {
            $pageLink = $page->AbsoluteLink();
        }
        $toList = array();
        if ($this->Config()->get("mail_to_site_owner_only") != 'yes') {
            $tos = explode(',', $data['To']);
            foreach ($tos as $to) {
                $toList = array_merge($toList, explode(';', $to));
            }
        } else {
            $toList[] = $adminEmail;
        }
        if ($data['YourMailAddress']) {
            $toList[] = $data['YourMailAddress'];
        }
        $ip = EmailAFriendExtension::get_ip_user();
        $count = 0;
        if ($this->Config()->get("EmailAFriendExtension", "max_message_phour_pip")) {
            $anHourAgo = date('Y-m-d H:i:s', mktime(date('G') - 1, date('i'), date('s'), date('n'), date('j'), date('Y')));
            $count = FriendEmail::get()->filter(
                array(
                    "IPAddress" => $ip,
                    "Created:GreaterThan" => $anHourAgo
                )
            )->count();
        }
        if ($this->Config()->get("mail_to_site_owner_only") != 'yes') {
            $mailFrom = $data['YourMailAddress'];
        } else {
            if ($this->Config()->get("EmailAFriendExtension", "sender_name")) {
                $mailFrom = $this->Config()->get("EmailAFriendExtension", "sender_name");
                if ($this->Config()->get("EmailAFriendRole", "sender_email_address")) {
                    $mailFrom .= ' <' . $this->Config()->get("EmailAFriendExtension", "sender_email_address") . '>';
                }
            } elseif ($this->Config()->get("EmailAFriendExtension", "sender_email_address")) {
                $mailFrom = $this->Config()->get("EmailAFriendExtension", "sender_email_address");
            } else {
                $mailFrom = $adminEmail;
            }
        }
        foreach ($toList as $index => $to) {
            $messagesPerHour = $this->Config()->get("EmailAFriendExtension", "max_message_phour_pip");
            if ($messagesPerHour && $count > $messagesPerHour) {
                $stopIndex = $index;
                break;
            } else {
                $friendEmail = new FriendEmail();
                $friendEmail->To = $to;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $friendEmail->Message = $data['Message'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $friendEmail->From = $data['YourMailAddress'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $friendEmail->IPAddress = $ip;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $friendEmail->PageID = $data['PageID'];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $friendEmail->write();
                $subject = $this->Config()->get("EmailAFriendExtension", "mail_subject");
                $subject .= ' | sent by '.$data['YourMailAddress'];
                $email = new Email(
                    $mailFrom,
                    $to,
                    $subject,
                    Convert::raw2xml($data['Message']) . '<br/><br/>Page Link : ' . $pageLink. '<br /><br />Sent by: '.$data['YourMailAddress']
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                );
                $outcome = $email->send();
                if ($outcome) {

                    $count++;
                } else {
                    unset($toList[$index]);
                }
            }
        }

        if (count($toList) > 0) {
            $content = '';
            $endIndex = isset($stopIndex) ? $stopIndex : count($toList);
            if (! isset($stopIndex) || $stopIndex > 0) {
                $content .= '<p class="message good">This page has been successfully e-mailed to the following addresses :</p><ul>';
                for ($i = 0; $i < $endIndex; $i++) {

                    $content .= '<li>' . $toList[$i] . '</li>';
                }
                $content .= '</ul>';
            }
            if ($endIndex < count($toList)) {
                $content .= '<p class="message required">This page could not be e-mailed to the following addresses :</p><ul>';
                for ($i = $endIndex; $i < count($toList); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                    $content .= '<li>' . $toList[$i] . '</li>';
                }
                $content .= '</ul>';
            }
        } else {
            $content = '<p class="message required bad">This page has not been e-mailed to anyone.</p>';
        }

        $content .= '<br/><p><a href="' . $this->controller->Link() . '">Send more?</a>.</p>';

        $templateData = array("EmailAFriendForm" => null, "EmailAFriendThankYouContent" => $content);
        return $this->customise($templateData)->renderWith('EmailAFriendHolder');
    }
}


1		<?php
2
3		class EmailAFriendForm extends Form
		0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4		{
5
6		/**
7		* @var String
8		*/
9		private static $friend_email_address_label = "Friend#039;s Email Address";
		0 ignored issues – show Unused Code introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `$friend_email_address_label` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
10
11		/**
12		* @var String
13		*/
14		private static $message_label = "Message";
		0 ignored issues – show Unused Code introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `$message_label` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
15
16		/**
17		* @var String
18		*/
19		private static $your_email_address_label = "Your email address";
		0 ignored issues – show Unused Code introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `$your_email_address_label` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
20
21		/**
22		* @var String
23		*/
24		private static $send_label = 'Send';
		0 ignored issues – show Unused Code introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `$send_label` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
25
26		/**
27		* yes or no
28		* @var String
29		*/
30		private static $mail_to_site_owner_only = 'no';
		0 ignored issues – show Unused Code introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `$mail_to_site_owner_only` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
31
32		/**
33		* @param Controller $controller
34		* @param String $name
35		*/
36		public function __construct($controller, $name)
37		{
38		Requirements::themedCSS("EmailReferral", "emailreferral");
39		Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
40		Requirements::javascript("emailreferral/javascript/EmailReferralForm.js");
41
42		$fields[] = new HiddenField('PageID', 'PageID', $controller->dataRecord->ID);
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report `$fields` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$fields = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
43
44		$fields[] = new EmailField('YourMailAddress', $this->Config()->get("your_email_address_label"));
45		$fields[] = new TextareaField(
46		'Message',
47		$this->Config()->get("message_label"),
48		$this->Config()->get("EmailAFriendExtension", "default_message")
49		);
50		if ($this->Config()->get("mail_to_site_owner_only") != 'yes') {
51		$fields[] = new LiteralField('AdditionalMessage', '<div id="additionalMessageStuff"><p>'.Director::absoluteURL($controller->Link()).'</p><p>Sent by: <span id="emailReplacer">[your email address]</span></p></div>');
52		$fields[] = new EmailField('To', $this->Config()->get("friend_email_address_label"));
53		}
54
55		$fields = new FieldList($fields);
56
57		$actions = new FieldList(new FormAction('sendemailafriend', $this->Config()->get("send_label")));
58		if ($this->Config()->get("mail_to_site_owner_only") != 'yes') {
59		$requiredFields = new RequiredFields(array('YourMailAddress', 'To', 'Message'));
60		} else {
61		$requiredFields = new RequiredFields(array('YourMailAddress', 'Message'));
62		}
63
64		parent::__construct($controller, $name, $fields, $actions, $requiredFields);
65		}
66
67		/**
68		*
69		* @param Array
70		* @param EmailAFriendForm
71		*/
72		public function sendemailafriend($RAW_data, $form)
		0 ignored issues – show Unused Code introduced 2018-02-21 04:02 UTC by Report Bug Copy Issue Report The parameter `$form` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
73		{
74		$adminEmail = Config::inst()->get("Email", "admin_email");
75		$data = Convert::raw2sql($RAW_data);
76		if ($page = Page::get()->byID(intval($data['PageID']))) {
77		$pageLink = $page->AbsoluteLink();
78		}
79		$toList = array();
80		if ($this->Config()->get("mail_to_site_owner_only") != 'yes') {
81		$tos = explode(',', $data['To']);
82		foreach ($tos as $to) {
83		$toList = array_merge($toList, explode(';', $to));
84		}
85		} else {
86		$toList[] = $adminEmail;
87		}
88		if ($data['YourMailAddress']) {
89		$toList[] = $data['YourMailAddress'];
90		}
91		$ip = EmailAFriendExtension::get_ip_user();
92		$count = 0;
93		if ($this->Config()->get("EmailAFriendExtension", "max_message_phour_pip")) {
94		$anHourAgo = date('Y-m-d H:i:s', mktime(date('G') - 1, date('i'), date('s'), date('n'), date('j'), date('Y')));
95		$count = FriendEmail::get()->filter(
96		array(
97		"IPAddress" => $ip,
98		"Created:GreaterThan" => $anHourAgo
99		)
100		)->count();
101		}
102		if ($this->Config()->get("mail_to_site_owner_only") != 'yes') {
103		$mailFrom = $data['YourMailAddress'];
104		} else {
105		if ($this->Config()->get("EmailAFriendExtension", "sender_name")) {
106		$mailFrom = $this->Config()->get("EmailAFriendExtension", "sender_name");
107		if ($this->Config()->get("EmailAFriendRole", "sender_email_address")) {
108		$mailFrom .= ' <' . $this->Config()->get("EmailAFriendExtension", "sender_email_address") . '>';
109		}
110		} elseif ($this->Config()->get("EmailAFriendExtension", "sender_email_address")) {
111		$mailFrom = $this->Config()->get("EmailAFriendExtension", "sender_email_address");
112		} else {
113		$mailFrom = $adminEmail;
114		}
115		}
116		foreach ($toList as $index => $to) {
117		$messagesPerHour = $this->Config()->get("EmailAFriendExtension", "max_message_phour_pip");
118		if ($messagesPerHour && $count > $messagesPerHour) {
119		$stopIndex = $index;
120		break;
121		} else {
122		$friendEmail = new FriendEmail();
123		$friendEmail->To = $to;
		0 ignored issues – show Documentation introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `To` does not exist on `object<FriendEmail>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
124		$friendEmail->Message = $data['Message'];
		0 ignored issues – show Documentation introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `Message` does not exist on `object<FriendEmail>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
125		$friendEmail->From = $data['YourMailAddress'];
		0 ignored issues – show Documentation introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `From` does not exist on `object<FriendEmail>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
126		$friendEmail->IPAddress = $ip;
		0 ignored issues – show Documentation introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `IPAddress` does not exist on `object<FriendEmail>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
127		$friendEmail->PageID = $data['PageID'];
		0 ignored issues – show Documentation introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The property `PageID` does not exist on `object<FriendEmail>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
128		$friendEmail->write();
129		$subject = $this->Config()->get("EmailAFriendExtension", "mail_subject");
130		$subject .= ' \| sent by '.$data['YourMailAddress'];
131		$email = new Email(
132		$mailFrom,
133		$to,
134		$subject,
135		Convert::raw2xml($data['Message']) . '<br/><br/>Page Link : ' . $pageLink. '<br /><br />Sent by: '.$data['YourMailAddress']
		0 ignored issues – show Bug introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The variable `$pageLink` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
136		);
137		$outcome = $email->send();
138		if ($outcome) {
		0 ignored issues – show Bug Best Practice introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report The expression `$outcome` of type `string[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
139		$count++;
140		} else {
141		unset($toList[$index]);
142		}
143		}
144		}
145
146		if (count($toList) > 0) {
147		$content = '';
148		$endIndex = isset($stopIndex) ? $stopIndex : count($toList);
149		if (! isset($stopIndex) \|\| $stopIndex > 0) {
150		$content .= '<p class="message good">This page has been successfully e-mailed to the following addresses :</p><ul>';
151	View Code Duplication	for ($i = 0; $i < $endIndex; $i++) {
		0 ignored issues – show Duplication introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
152		$content .= '<li>' . $toList[$i] . '</li>';
153		}
154		$content .= '</ul>';
155		}
156		if ($endIndex < count($toList)) {
157		$content .= '<p class="message required">This page could not be e-mailed to the following addresses :</p><ul>';
158	View Code Duplication	for ($i = $endIndex; $i < count($toList); $i++) {
		0 ignored issues – show Performance Best Practice introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history... Duplication introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
159		$content .= '<li>' . $toList[$i] . '</li>';
160		}
161		$content .= '</ul>';
162		}
163		} else {
164		$content = '<p class="message required bad">This page has not been e-mailed to anyone.</p>';
165		}
166
167		$content .= '<br/><p><a href="' . $this->controller->Link() . '">Send more?</a>.</p>';
168
169		$templateData = array("EmailAFriendForm" => null, "EmailAFriendThankYouContent" => $content);
170		return $this->customise($templateData)->renderWith('EmailAFriendHolder');
171		}
172		}
173

sunnysideup / silverstripe-emailreferral

EmailAFriendForm B last analyzed 2018-03-20 01:14 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like

EmailAFriendForm B
last analyzed 2018-03-20 01:14 UTC