EmailAFriendExtension_Controller

Complexity

Total Complexity

8

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	EmailAFriendForm()	0	4	1
A	emailafriend()	0	9	2
A	EmailAFriendShowForm()	0	4	1
A	EmailAFriendLink()	0	6	2
A	setEmailAFriendThankYouContent()	0	4	1
A	EmailAFriendThankYouContent()	0	4	1

<?php



class EmailAFriendExtension_Controller extends Extension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $allowed_actions = array('EmailAFriendForm', 'emailafriend');

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

    protected $emailAFriendShowForm = false;

    /**
     * @return EmailAFriendForm
     */
    public function EmailAFriendForm()
    {
        return new EmailAFriendForm($this->owner, 'EmailAFriendForm');
    }

    public function emailafriend($request)

The return type could not be reliably inferred; please add a @return annotation.

    {
        $this->showForm = true;

The property showForm does not seem to exist. Did you mean emailAFriendShowForm?

        if ($request->isAjax()) {
            return $this->owner->renderWith('EmailAFriendHolder', 'Page_emailafriend');
        } else {
            return $this->owner->renderWith('EmailAFriendHolder_NOAJAX');
        }
    }

    public function EmailAFriendShowForm()
    {
        return $this->emailAFriendShowForm;
    }

    /**
     * @return String
     */
    public function EmailAFriendLink()
    {
        if ($this->owner->request->param("Action") != "emailafriend") {
            return $this->owner->Link('emailafriend');
        }
    }
    protected $emailAFriendThankYouContent = "";

    public function setEmailAFriendThankYouContent($v)
    {
        $this->emailAFriendThankYouContent = $v;
    }

    public function EmailAFriendThankYouContent()
    {
        return $this->emailAFriendThankYouContent;
    }
}