EmailReminder_NotificationSchedule

Complexity

Total Complexity

77

Size/Duplication

Total Lines	539
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	15

Importance

Changes

0

20 Methods

Rating	Name	Duplication	Size	Complexity
A	i18n_singular_name()	0	4	1
A	i18n_plural_name()	0	4	1
A	populateDefaults()	0	12	1
D	getCMSFields()	0	146	10
A	dataObjectOptions()	0	4	1
A	emailFieldOptions()	0	4	1
A	dateFieldOptions()	0	4	1
C	getFieldsFromDataObject()	0	24	8
A	hasValidDataObject()	0	4	3
A	hasValidDataObjectFields()	0	15	4
A	getTitle()	0	6	3
B	hasValidFields()	0	13	6
B	validate()	0	14	5
A	onBeforeWrite()	0	7	2
A	onAfterWrite()	0	11	3
A	getReplacerObject()	0	6	2
A	getMailOutObject()	0	12	3
A	SampleFieldDataForRecords()	0	14	3
C	CurrentRecords()	0	57	15
B	whereStatementForDays()	0	23	4

<?php

class EmailReminder_NotificationSchedule extends DataObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     * @var int
     */
    private static $grace_days = 3;

The property $grace_days is not used and could be removed.

    /**
     * @var string
     */
    private static $default_data_object = 'Member';

The property $default_data_object is not used and could be removed.

    /**
     * @var string
     */
    private static $default_date_field = '';

The property $default_date_field is not used and could be removed.

    /**
     * @var string
     */
    private static $default_email_field = '';

The property $default_email_field is not used and could be removed.

    /**
     * @var string
     */
    private static $replaceable_record_fields = array('FirstName', 'Surname', 'Email');

The property $replaceable_record_fields is not used and could be removed.

    /**
     * @var string
     */
    private static $include_method = 'EmailReminderInclude';

The property $include_method is not used and could be removed.

    /**
     * @var string
     */
    private static $exclude_method = 'EmailReminderExclude';

The property $exclude_method is not used and could be removed.

    /**
     * @var string
     */
    private static $mail_out_class = 'EmailReminder_DailyMailOut';

The property $mail_out_class is not used and could be removed.

    private static $singular_name = 'Email Reminder Schedule';

Consider using a different property name as you override a private property of the parent class.

    public function i18n_singular_name()
    {
        return self::$singular_name;
    }

    private static $plural_name = 'Email Reminder Schedules';

Consider using a different property name as you override a private property of the parent class.

    public function i18n_plural_name()
    {
        return self::$plural_name;
    }

    private static $db = array(

The property $db is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

        'DataObject' => 'Varchar(100)',
        'EmailField' => 'Varchar(100)',
        'DateField' => 'Varchar(100)',
        'Days' => 'Int',
        'RepeatDays' => 'Int',
        'BeforeAfter' => "Enum('before,after,immediately','before')",
        'EmailFrom' => 'Varchar(100)',
        'EmailSubject' => 'Varchar(100)',
        'Content' => 'HTMLText',
        'Disable' => 'Boolean',
        'SendTestTo' => 'Text'
    );


    private static $has_many = array(

The property $has_many is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

        'EmailsSent' => 'EmailReminder_EmailRecord'
    );

    private static $summary_fields = array(

The property $summary_fields is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

        'EmailSubject',
        'Days'
    );

    private static $field_labels = array(

The property $field_labels is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

        'DataObject' => 'Class/Table',
        'Days' => 'Days from Expiry',
        'RepeatDays' => 'Repeat cycle days'
    );

    public function populateDefaults()
    {
        parent::populateDefaults();
        $this->DataObject = $this->Config()->get('default_data_object');

The property DataObject does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __set, maybe consider adding a @property annotation.

        $this->EmailField = $this->Config()->get('default_email_field');

The property EmailField does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __set, maybe consider adding a @property annotation.

        $this->DateField = $this->Config()->get('default_date_field');

The property DateField does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __set, maybe consider adding a @property annotation.

        $this->Days = 7;

The property Days does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __set, maybe consider adding a @property annotation.

        $this->RepeatDays = 300;

The property RepeatDays does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __set, maybe consider adding a @property annotation.

        $this->BeforeAfter = 'before';

The property BeforeAfter does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __set, maybe consider adding a @property annotation.

        $this->EmailFrom = Config::inst()->get('Email', 'admin_email');

The property EmailFrom does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __set, maybe consider adding a @property annotation.

        $this->EmailSubject = 'Your memberships expires in [days] days';

The property EmailSubject does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __set, maybe consider adding a @property annotation.

    }

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $emailsSentField = $fields->dataFieldByName('EmailsSent');
        $fields->removeFieldFromTab('Root', 'EmailsSent');

        $fields->addFieldToTab(
            'Root.Main',
            CheckboxField::create('Disable')
        );
        $fields->addFieldToTab(
            'Root.Main',
            $dataObjecField = DropdownField::create(
                'DataObject',
                'Table/Class Name',
                $this->dataObjectOptions()
            )
            ->setRightTitle('Type a valid table/class name')
        );
        if ($this->Config()->get('default_data_object')) {
            $fields->replaceField('DataObject', $dataObjecField->performReadonlyTransformation());
        }



        $fields->addFieldToTab(
            'Root.Main',
            $emailFieldField = DropdownField::create(
                'EmailField',
                'Email Field',
                $this->emailFieldOptions()
            )
            ->setRightTitle('Select the field that will contain a valid email address')
            ->setEmptyString('[ Please select ]')
        );
        if ($this->Config()->get('default_email_field')) {
            $fields->replaceField('EmailField', $emailFieldField->performReadonlyTransformation());
        }

        $fields->addFieldToTab(
            'Root.Main',
            $dateFieldField = DropdownField::create(
                'DateField',
                'Date Field',
                $this->dateFieldOptions()
            )
            ->setRightTitle('Select a valid Date field to calculate when reminders should be sent')
            ->setEmptyString('[ Please select ]')
        );
        if ($this->Config()->get('default_date_field')) {
            $fields->replaceField('DateField', $dateFieldField->performReadonlyTransformation());
        }

        $fields->removeFieldsFromTab(
            'Root.Main',
            array('Days', 'BeforeAfter', 'RepeatDays')
        );
        $fields->addFieldsToTab(
            'Root.Main',
            array(
                DropdownField::create('BeforeAfter', 'Before / After Expiration', array('before' => 'before', 'after' => 'after', 'immediately' => 'immediately'))
                    ->setRightTitle('Are the days listed above before or after the actual expiration date.'),
                NumericField::create('Days', 'Days')
                    ->setRightTitle('How many days in advance (before) or in arrears (after) of the expiration date should this email be sent? </br>This field is ignored if set to send immediately.'),
                NumericField::create('RepeatDays', 'Repeat Cycle Days')
                    ->setRightTitle(
                        '
                        Number of days after which the same reminder can be sent to the same email address.
                        <br />We allow an e-mail to be sent to one specific email address for one specific reminder only once.
                        <br />In this field you can indicate for how long we will apply this rule.'
                )
            )
        );
        $fields->addFieldsToTab(
            'Root.EmailContent',
            array(
                TextField::create('EmailFrom', 'Email From Address')
                    ->setRightTitle('The email from address, eg: "My Company &lt;info@example.com&gt;"'),
                $subjectField = TextField::create('EmailSubject', 'Email Subject Line')
                    ->setRightTitle('The subject of the email'),
                $contentField = HTMLEditorField::create('Content', 'Email Content')
                    ->SetRows(20)
            )
        );
        if ($obj = $this->getReplacerObject()) {

Are you sure the assignment to $obj is correct as $this->getReplacerObject() (which targets EmailReminder_NotificationSchedule::getReplacerObject()) seems to always return null.

            $html = $obj->replaceHelpList($asHTML = true);
            $otherFieldsThatCanBeUsed = $this->getFieldsFromDataObject(array('*'));
            $replaceableFields = $this->Config()->get('replaceable_record_fields');
            if (count($otherFieldsThatCanBeUsed)) {
                $html .= '<h3>You can also use the record fields (not replaced in tests):</h3><ul>';
                foreach ($otherFieldsThatCanBeUsed as $key => $value) {
                    if (in_array($key, $replaceableFields)) {
                        $html .= '<li><strong>$'.$key.'</strong> <span>'.$value.'</span></li>';
                    }
                }
            }
            $html .= '</ul>';
            $subjectField->setRightTitle('for replacement options, please see below ...');
            $contentField->setRightTitle($html);
        }
        $fields->addFieldsToTab(
            'Root.Sent',
            array(
                TextareaField::create('SendTestTo', 'Send test email to ...')
                    ->setRightTitle(
                        '
                        Separate emails by commas, a test email will be sent every time you save this Email Reminder, if you do not want test emails to be sent make sure this field is empty
                        '
                    )
                    ->SetRows(3)
            )
        );
        if ($emailsSentField) {
            $config = $emailsSentField->getConfig();

The method getConfig() does not exist on FormField. Did you maybe mean config()?

            $config->removeComponentsByType('GridFieldAddExistingAutocompleter');
            $fields->addFieldToTab(
                'Root.Sent',
                $emailsSentField
            );
        }
        $records = $this->CurrentRecords();
        if ($records) {
            $fields->addFieldsToTab(
                'Root.Review',
                array(
                    GridField::create(
                        'CurrentRecords',
                        'Today we are sending to ...',
                        $records
                    ),
                    LiteralField::create(
                        'SampleSelectStatement',
                        '<h3>Here is a sample statement used to select records:</h3>
                        <pre>'.$this->whereStatementForDays().'</pre>'
                    ),
                    LiteralField::create(
                        'SampleFieldDataForRecords',
                        '<h3>sample of '.$this->DateField.' field values:</h3>

The property DateField does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

                        <li>'.implode('</li><li>', $this->SampleFieldDataForRecords()).'</li>'
                    )
                )
            );
        }
        return $fields;
    }

    /**
     * @return array

Should the return type not be null|array?

     */
    protected function dataObjectOptions()
    {
        return ClassInfo::subclassesFor("DataObject");
    }

    /**
     * @return array
     */
    protected function emailFieldOptions()
    {
        return $this->getFieldsFromDataObject(array('Varchar', 'Email'));
    }

    /**
     * @return array
     */
    protected function dateFieldOptions()
    {
        return $this->getFieldsFromDataObject(array('Date'));
    }


    /**
     * list of database fields available
     * @param  array $fieldTypeMatchArray - strpos filter
     * @return array
     */
    protected function getFieldsFromDataObject($fieldTypeMatchArray = array())
    {
        $array = array();
        if ($this->hasValidDataObject()) {
            $object = Injector::inst()->get($this->DataObject);

The property DataObject does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

            if ($object) {
                $allOptions = $object->stat('db');
                $fieldLabels = $object->fieldLabels();
                foreach ($allOptions as $fieldName => $fieldType) {
                    foreach ($fieldTypeMatchArray as $matchString) {
                        if ((strpos($fieldType, $matchString) !== false) || $matchString == '*') {
                            if (isset($fieldLabels[$fieldName])) {
                                $label = $fieldLabels[$fieldName];
                            } else {
                                $label = $fieldName;
                            }
                            $array[$fieldName] = $label;
                        }
                    }
                }
            }
        }
        return $array;
    }


    /**
     * Test if valid classname has been set
     * @param null
     * @return Boolean
     */
    public function hasValidDataObject()
    {
        return (! $this->DataObject) || ClassInfo::exists($this->DataObject) ? true : false;

The property DataObject does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    /**
     * Test if valid fields have been set
     * @param null
     * @return Boolean
     */
    public function hasValidDataObjectFields()
    {
        if (!$this->hasValidDataObject()) {
            return false;
        }
        $emailFieldOptions = $this->emailFieldOptions();
        if (!isset($emailFieldOptions[$this->EmailField])) {

The property EmailField does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

            return false;
        }
        $dateFieldOptions = $this->dateFieldOptions();
        if (!isset($dateFieldOptions[$this->DateField])) {

The property DateField does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

This if statement, and the following return statement can be replaced with return isset($dateFieldOptions[$this->DateField]);.

            return false;
        }
        return true;
    }

    /**
     * @return string
     */
    public function getTitle()
    {
        $niceTitle = '[' . $this->EmailSubject . '] // send ';

The property EmailSubject does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

        $niceTitle .= ($this->BeforeAfter === 'immediately') ?  $this->BeforeAfter : $this->Days . ' days '.$this->BeforeAfter.' Expiration Date';

The property BeforeAfter does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

The property Days does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

        return ($this->hasValidDataObjectFields()) ? $niceTitle : 'uncompleted';
    }

    /**
     * @return boolean
     */
    public function hasValidFields()
    {
        if (!$this->hasValidDataObject()) {
            return false;
        }
        if (!$this->hasValidDataObjectFields()) {
            return false;
        }
        if ($this->EmailFrom && $this->EmailSubject && $this->Content) {

The property EmailFrom does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

The property EmailSubject does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

The property Content does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

This if statement, and the following return statement can be replaced with return $this->EmailFrom && $this->EmailSubject && $this->Content;.

            return true;
        }
        return false;
    }

    /**
     * @return boolean

Should the return type not be ValidationResult?

     */
    public function validate()
    {
        $valid = parent::validate();
        if ($this->exists()) {
            if (! $this->hasValidDataObject()) {
                $valid->error('Please enter valid Tabe/Class name ("' . htmlspecialchars($this->DataObject) .'" does not exist)');

The property DataObject does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

            } elseif (! $this->hasValidDataObjectFields()) {
                $valid->error('Please select valid fields for both Email & Date');
            } elseif (! $this->hasValidFields()) {
                $valid->error('Please fill in all fields.  Make sure not to forget the email details (from who, subject, content)');
            }
        }
        return $valid;
    }

    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        if ($this->RepeatDays < ($this->Days * 3)) {

The property RepeatDays does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

The property Days does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

            $this->RepeatDays = ($this->Days * 3);

The property RepeatDays does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __set, maybe consider adding a @property annotation.

The property Days does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

        }
    }

    public function onAfterWrite()
    {
        parent::onAfterWrite();
        if ($this->SendTestTo) {

The property SendTestTo does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

            if ($mailOutObject = $this->getMailOutObject()) {
                $mailOutObject->setTestOnly(true);
                $mailOutObject->setVerbose(true);
                $mailOutObject->run(null);

null is of type null, but the function expects a object<SS_HTTPRequest>.

            }
        }
    }

    /**
     *
     * @return null | EmailReminder_ReplacerClassInterface
     */
    public function getReplacerObject()
    {
        if ($mailOutObject = $this->getMailOutObject()) {
            return $mailOutObject->getReplacerObject();
        }
    }

    /**
     *
     * @return null | ScheduledTask

Should the return type not be BuildTask|null?

     */
    public function getMailOutObject()
    {
        $mailOutClass = $this->Config()->get('mail_out_class');
        if (class_exists($mailOutClass)) {
            $obj = Injector::inst()->get($mailOutClass);
            if ($obj instanceof BuildTask) {
                return $obj;
            } else {
                user_error($mailOutClass.' needs to be an instance of a Scheduled Task');
            }
        }
    }

    /**
     * @param int $limit
     * @return array

Should the return type not be array|null?

     */
    public function SampleFieldDataForRecords($limit = 200)
    {
        if ($this->hasValidFields()) {
            $className = $this->DataObject;

The property DataObject does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __set, maybe consider adding a @property annotation.

            $objects = $className::get()->sort('RAND()')
                ->where('"'.$this->DateField.'" IS NOT NULL AND "'.$this->DateField.'" <> \'\' AND "'.$this->DateField.'" <> 0')

The property DateField does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

                ->limit($limit);
            if ($objects->count()) {
                return array_unique($objects->column($this->DateField));

The property DateField does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

            } else {
                return array();
            }
        }
    }


    /**
     * @return DataList | null
     */
    public function CurrentRecords()
    {
        if ($this->hasValidFields()) {
            $className = $this->DataObject;

The property DataObject does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __set, maybe consider adding a @property annotation.

            // Use StartsWith to match Date and DateTime fields
            $records = $className::get()->where($this->whereStatementForDays());
            //sample record
            $firstRecord = $records->first();
            if($firstRecord && $firstRecord->exists()) {
                //methods
                $includeMethod = $this->Config()->get('include_method');
                $excludeMethod = $this->Config()->get('exclude_method');

                //included method?
                $hasIncludeMethod = false;
                if($record->hasMethod($includeMethod)) {

The variable $record seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

                    $includedRecords = [0 => 0];
                    $hasIncludeMethod = true;
                }

                //excluded method?
                $hasExcludeMethod = false;
                if($record->hasMethod($excludeMethod)) {

The variable $record seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

                    $excludedRecords = [0 => 0];
                    $hasExcludeMethod = true;
                }

                //see who is in and out
                if($hasIncludeMethod || $hasExcludeMethod) {
                    foreach($records as $record) {
                        if($hasIncludeMethod) {
                            $in = $record->$includeMethod($this, $records);
                            if($in === true) {
                                $includedRecords[$record->ID] = $record->ID;

The variable $includedRecords does not seem to be defined for all execution paths leading up to this point.

                            }
                        }
                        if($hasExcludeMethod) {
                            $out = $record->$excludeMethod($this, $records);
                            if($out === true) {
                                $excludedRecords[$record->ID] = $record->ID;

The variable $excludedRecords does not seem to be defined for all execution paths leading up to this point.

                            }
                        }
                    }
                }

                //apply inclusions and exclusions
                if($hasIncludeMethod) {
                    $records = $className::get()->filter(['ID' => $includedRecords]);
                }
                if($hasExcludeMethod) {
                    $records = $records->exclude(['ID' => $excludedRecords]);
                }
            }
            return $records;
        }
    }

    /**
     * BeforeAfter = 'after'
     * Days = 3
     * GraceDays = 2
     *  -> minDays = -5 days start of day
     *  -> maxDays = -3 days end of day
     *
     * @return string
     */
    protected function whereStatementForDays()
    {
        if ($this->hasValidFields()) {
            $sign = $this->BeforeAfter == 'before' ? '+' : '-';

The property BeforeAfter does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

            $graceDays = 10; //Config::inst()->get('EmailReminder_NotificationSchedule', 'grace_days');

72% of this comment could be valid code. Did you maybe forget this after debugging?

            if ($sign == '+') {
                $minDays = $sign . ($this->Days - $graceDays) . ' days';

The property Days does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

                $maxDays = $sign . $this->Days . ' days';

The property Days does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

                $minDate = date('Y-m-d', strtotime($minDays)).' 00:00:00';
                $maxDate = date('Y-m-d', strtotime($maxDays)).' 23:59:59';
            } else {
                $minDays = $sign . ($this->Days) . ' days';

The property Days does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

                $maxDays = $sign . $this->Days - $graceDays . ' days';

The property Days does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

                //we purposely change these days around here ...
                $minDate = date('Y-m-d', strtotime($maxDays)).' 00:00:00';
                $maxDate = date('Y-m-d', strtotime($minDays)).' 23:59:59';
            }

            return '("'. $this->DateField.'" BETWEEN \''.$minDate.'\' AND \''.$maxDate.'\')';

The property DateField does not exist on object<EmailReminder_NotificationSchedule>. Since you implemented __get, maybe consider adding a @property annotation.

        }
        return '1 == 2';
    }
}