EmailReminder_Mailer::sendHTML() - Code Metrics - Inspection of "MINOR: modifying functionality so that this can be..." - sunnysideup/silverstripe-email_reminder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7f78e2...8137fc )

unknown

created 2018-01-12 00:24 UTC

EmailReminder_Mailer::sendHTML() B

↳ Parent: EmailReminder_Mailer

Complexity

Conditions	3
Paths	3

Size

Total Lines	29
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	29
rs	8.8571
c	0
b	0
f	0
cc	3
eloc	24
nc	3
nop	7

<?php


class EmailReminder_Mailer extends Mailer
namespace YourVendor;

class YourClass { }
{
    private static $css_file = 'email_reminder/css/example.css';


    public function sendHTML(
        $to,
        $from,
        $subject,
        $htmlContent,
        $attachedFiles = false,
        $customheaders = false,
        $plainContent = false
    ) {
        $cssFileLocation = Director::baseFolder() . Config::inst()->get("EmailReminder_Mailer", "css_file");
        if ($cssFileLocation) {
            if (file_exists($cssFileLocation)) {
                $cssFileHandler = fopen($cssFileLocation, 'r');
                $css = fread($cssFileHandler,  filesize($cssFileLocation));
                fclose($cssFileHandler);
                $emog = new \Pelago\Emogrifier($htmlContent, $css);
                $htmlContent = $emog->emogrify();
            }
        }
        return parent::sendHTML(
            $to,
            $from,
            $subject,
            $htmlContent,
            $attachedFiles,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $customheaders,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $plainContent
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
    }
}


1			<?php
2
3
4			class EmailReminder_Mailer extends Mailer
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:16 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
5			{
6			private static $css_file = 'email_reminder/css/example.css';
			0 ignored issues – show Unused Code introduced 2017-01-03 01:16 UTC by Report Bug Copy Issue Report The property `$css_file` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
7
8			public function sendHTML(
9			$to,
10			$from,
11			$subject,
12			$htmlContent,
13			$attachedFiles = false,
14			$customheaders = false,
15			$plainContent = false
16			) {
17			$cssFileLocation = Director::baseFolder() . Config::inst()->get("EmailReminder_Mailer", "css_file");
18			if ($cssFileLocation) {
19			if (file_exists($cssFileLocation)) {
20			$cssFileHandler = fopen($cssFileLocation, 'r');
21			$css = fread($cssFileHandler, filesize($cssFileLocation));
22			fclose($cssFileHandler);
23			$emog = new \Pelago\Emogrifier($htmlContent, $css);
24			$htmlContent = $emog->emogrify();
25			}
26			}
27			return parent::sendHTML(
28			$to,
29			$from,
30			$subject,
31			$htmlContent,
32			$attachedFiles,
			0 ignored issues – show Documentation introduced 2018-01-12 00:25 UTC by Report Bug Copy Issue Report `$attachedFiles` is of type `boolean`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33			$customheaders,
			0 ignored issues – show Documentation introduced 2018-01-12 00:25 UTC by Report Bug Copy Issue Report `$customheaders` is of type `boolean`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
34			$plainContent
			0 ignored issues – show Documentation introduced 2018-01-12 00:25 UTC by Report Bug Copy Issue Report `$plainContent` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
35			);
36			}
37			}
38

sunnysideup / silverstripe-email_reminder

Push — master ( 7f78e2...8137fc )

EmailReminder_Mailer::sendHTML() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like