Issues in EVCPage.php (master) - Issues in master - sunnysideup/silverstripe-electric-vehicle-calculator - Measure and Improve Code Quality continuously with Scrutinizer

Issues (84)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/EVCPage.php (28 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


class EVCPage extends Page
namespace YourVendor;

class YourClass { }
{
}


class EVCPage_Controller extends Page_Controller
namespace YourVendor;

class YourClass { }
{
    private static $allowed_actions = array(

        "show" => true,
        "save" => true,
        "retrieve" => true,
        "reset" => true,
        "previous" => true,
        "lock" => true
    );

    public function init()
    {
        parent::init();
        Requirements::javascript("framework/thirdparty/jquery/jquery.js");
        if(Director::isLive()) {
            Requirements::themedCSS('ElectricVehicleCalculator.min', 'electric-vehicle-calculator');
            // Requirements::javascript("https://cdnjs.cloudflare.com/ajax/libs/Chart.js/2.5.0/Chart.bundle.min.js");

            Requirements::javascript("electric-vehicle-calculator/thirdparty/chartjs/Chart.min.js");
            Requirements::javascript("electric-vehicle-calculator/javascript/ElectricVehicleCalculator.min.js");
        } else {
            Requirements::themedCSS('ElectricVehicleCalculator', 'electric-vehicle-calculator');
            Requirements::javascript("electric-vehicle-calculator/thirdparty/chartjs/Chart.min.js");
            // Requirements::javascript("https://cdnjs.cloudflare.com/ajax/libs/Chart.js/2.5.0/Chart.bundle.min.js");

            Requirements::javascript("electric-vehicle-calculator/javascript/ElectricVehicleCalculator.js");
        }
    }

    protected $evcDataSet = null;

    public function index()

    {
        $code = Session::get("EVCLastCode");
        $this->evcDataSet = EVCDataSet::find_or_create($code, true);
        if (!$code) {
            $code = $this->evcDataSet->Code;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            Session::set("EVCLastCode", $code);
        }
        return $this->redirect($this->evcDataSet->MyLink($this, "show"));
    }

    function BackgroundImage()

    {
        if(rand(0,1) == 1) {
            $v =  '/electric-vehicle-calculator/images/nz-road1.jpg';
        } else {
            $v = '/electric-vehicle-calculator/images/nz-road2.jpg';
        }
        return Controller::join_links (
            Director::absoluteBaseURL(),
            $v
        );
    }

    public function HasCustomTitle()
    {
        if ($this->evcDataSet && $this->evcDataSet->Title) {
            return true;
        }
    }

    public function Title()

    {
        if ($this->HasCustomTitle()) {
            return Convert::raw2xml(urldecode($this->evcDataSet->Title));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        return Convert::raw2xml($this->Title);
    }

    public function MetaTitle()

    {
        if ($this->HasCustomTitle()) {
            return Convert::raw2xml(urldecode($this->evcDataSet->Title));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        return Convert::raw2xml($this->MetaTitle);
    }

    public function show($request)

    {
        $code = $request->param("ID");
        $this->evcDataSet = EVCDataSet::find_or_create($code, false);
        if ($this->evcDataSet && $this->evcDataSet->exists()) {
            Requirements::javascript('electric-vehicle-calculator/javascript/ElectricVehicleCalculator.js');
            $link = $this->Link();
            if($link === '/') {
                $link = '/home/';
            }
            //Requirements::javascript("assets/evc/translations.js");

            Requirements::customScript("
                EVC.serverInteraction.baseLink = '".$link."';
                EVC.serverInteraction.serverKey = '".$this->evcDataSet->Code."';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ", "EVCSetBasics");
            Requirements::customScript($this->evcDataSet->returnValuesAsJS(), "EVCreturnValuesAsJS");
            return array();
        } else {
            return $this->httpError(404);
        }
    }

    /**
     * returns empty string on error...
     * ajax method ...
     * @return string
     */
    public function save($request)
    {
        $code = $request->param("ID");
        $this->evcDataSet = EVCDataSet::find_or_create($code, true);
        //save it
        $key = Convert::raw2sql($request->getVar("key"));
        $value = Convert::raw2sql($request->getVar("value"));
        if ($newCode = $this->evcDataSet->setValue($key, $value)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            Session::set("EVCLastCode", $newCode);
            Session::save();
            return $newCode;
        }
    }

    public function retrieve($request)

    {
        $code = $request->param("ID");
        $this->evcDataSet = EVCDataSet::find_or_create($code, false);
        if ($this->evcDataSet && $this->evcDataSet->exists() && $this->evcDataSet->Data) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            Session::set("EVCLastCode", $this->evcDataSet->Code);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            Session::save();
            return $this->redirect($this->evcDataSet->MyLink($this, "show"));
        } else {
            return $this->httpError(404);
        }
    }

    public function reset($request)

    {
        Session::set("EVCLastCode", "");
        Session::clear("EVCLastCode");
        Session::save();
        return $this->redirect($this->Link());
    }

    /**
     * ajax method ...
     *
     */
    public function lock($request)

    {
        $code = $request->param("ID");
        $this->evcDataSet = EVCDataSet::find_or_create($code, false);
        $title = $request->getVar("title");
        if ($title && $this->evcDataSet && $this->evcDataSet->exists()) {
            if ($title == "ignore") {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                //no need to do anything
            } else {
                $this->evcDataSet = $this->evcDataSet->getCopyIfNeeded();
                $this->evcDataSet->Locked = true;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->evcDataSet->Title = Convert::raw2sql(urldecode($title));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->evcDataSet->write();
            }
            return $this->evcDataSet->MyLink($this, "retrieve");
        }
        return "ERROR!";
    }

    public function EVCDataSet()
    {
        return $this->evcDataSet;
    }

    public function IsLocked()

    {
        return $this->evcDataSet->Locked;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }


    protected $previousCalculations = null;

    public function previous($request)
    {
        $this->previousCalculations = PaginatedList::create(EVCDataSet::get()->filter(array("Locked" => 1))->where("Title IS NOT NULL AND Title <> ''"));
        $this->previousCalculations->setPageLength(100);
        return array();
    }

    public function PreviousCalculations()
    {
        return $this->previousCalculations;
    }
}


1			<?php
2
3
4			class EVCPage extends Page
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
5			{
6			}
7
8
9			class EVCPage_Controller extends Page_Controller
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
10			{
11			private static $allowed_actions = array(
			0 ignored issues – show Unused Code introduced 2017-01-03 01:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$allowed_actions` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
12			"show" => true,
13			"save" => true,
14			"retrieve" => true,
15			"reset" => true,
16			"previous" => true,
17			"lock" => true
18			);
19
20			public function init()
21			{
22			parent::init();
23			Requirements::javascript("framework/thirdparty/jquery/jquery.js");
24			if(Director::isLive()) {
25			Requirements::themedCSS('ElectricVehicleCalculator.min', 'electric-vehicle-calculator');
26			// Requirements::javascript("https://cdnjs.cloudflare.com/ajax/libs/Chart.js/2.5.0/Chart.bundle.min.js");
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-04-15 00:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
27			Requirements::javascript("electric-vehicle-calculator/thirdparty/chartjs/Chart.min.js");
28			Requirements::javascript("electric-vehicle-calculator/javascript/ElectricVehicleCalculator.min.js");
29			} else {
30			Requirements::themedCSS('ElectricVehicleCalculator', 'electric-vehicle-calculator');
31			Requirements::javascript("electric-vehicle-calculator/thirdparty/chartjs/Chart.min.js");
32			// Requirements::javascript("https://cdnjs.cloudflare.com/ajax/libs/Chart.js/2.5.0/Chart.bundle.min.js");
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-04-15 00:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
33			Requirements::javascript("electric-vehicle-calculator/javascript/ElectricVehicleCalculator.js");
34			}
35			}

sunnysideup / silverstripe-electric-vehicle-calculator

Issues (84)

Security Analysis not enabled

code/EVCPage.php (28 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like