GSTTaxModifierOptions - Code Metrics - Inspection of "PATCH: removing superfluous code" - sunnysideup/silverstripe-ecommerce_tax - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ac5f0e...2f6691 )

by Nicolaas

created 2018-01-09 20:29 UTC

GSTTaxModifierOptions A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	277
Duplicated Lines	15.88 %

Coupling/Cohesion

Components	2
Dependencies	11

Importance

Changes

Metric	Value
wmc	30
lcom	2
cbo	11
dl	44
loc	277
rs	10
c	0
b	0
f	0

16 Methods

Rating	Name	Duplication	Size	Complexity
A	i18n_singular_name()	0	4	1
A	i18n_plural_name()	0	4	1
A	canCreate()	11	11	3
A	canView()	11	11	3
A	canEdit()	11	11	3
A	canDelete()	11	11	3
A	getCMSFields()	0	12	2
A	Title()	0	4	1
A	getTitle()	0	9	2
A	populateDefaults()	0	17	4
A	onBeforeWrite()	0	9	2
A	EcomConfig()	0	4	1
A	CountryName()	0	4	1
A	getCountryName()	0	4	1
A	PercentageNice()	0	4	1
A	getPercentageNice()	0	4	1

How to fix Duplicated Code

<?php

/**
 *@author nicolaas [at] sunnysideup.co.nz
 *
 **/

class GSTTaxModifierOptions extends DataObject
namespace YourVendor;

class YourClass { }
{

    /**
     * standard SS variable
     * @var Array
     */
    private static $db = array(

        "CountryCode" => "Varchar(3)",
        "Code" => "Varchar(12)",
        "Name" => "Varchar(175)",
        "LegalNotice" => "Varchar(255)",
        "InclusiveOrExclusive" => "Enum('Inclusive,Exclusive', 'Inclusive')",
        "Rate" => "Double",
        "DoesNotApplyToAllProducts" => "Boolean",
        "AppliesToAllCountries" => "Boolean"
    );

    /**
     * standard SS variable
     * @var Array
     */
    private static $defaults = array(

        "InclusiveOrExclusive" => "Inclusive"
    );

    /**
     * standard SS variable
     * @var Array
     */
    private static $casting = array(

        "CountryName" => "Varchar",
        "PercentageNice" => "Varchar"
    );

    /**
     * standard SS variable
     * @var Array
     */
    private static $indexes = array(

        "Code" => true
    );

    /**
     * standard SS variable
     * @var Array
     */
    private static $searchable_fields = array(

        "CountryCode" => "PartialMatchFilter",
        "Code" => "PartialMatchFilter",
        "Name" => "PartialMatchFilter"
    );

    /**
     * standard SS variable
     * @var Array
     */
    private static $field_labels = array(

        "CountryName" => "Country Name",
        "CountryCode" => "Country Code",
        "Code" => "Code for tax",
        "Name" => "Name for tax",
        "InclusiveOrExclusive" => "Inclusive/Exclusive",
        "LegalNotice" => "Here you can put your GST number or VAT registration number",
        "Rate" => "Rate (e.g. 0.125 = 12.5%)",
        "PercentageNice" => "Percentage",
        "DoesNotApplyToAllProducts" => "Added to individual products only"
    );


    /**
     * standard SS variable
     * @var Array
     */
    private static $summary_fields = array(

        "CountryName" => 'Country',
        "Code" => 'Code',
        "Name" => 'Title',
        "InclusiveOrExclusive"  => 'Type',
        "PercentageNice" => 'Percentage'
    );

    /**
     * standard SS variable
     * @var String
     */
    private static $singular_name = "Tax Option";

    public function i18n_singular_name()
    {
        return _t("GSTTaxModifierOptions.TAXOPTION", "Tax Option");
    }


    /**
     * standard SS variable
     * @var String
     */
    private static $plural_name = "Tax Options";

    public function i18n_plural_name()
    {
        return _t("GSTTaxModifierOptions.TAXOPTIONS", "Tax Options");
    }

    /**
     * standard SS method
     * @param Member | NULL
     * @return Boolean

     */
    public function canCreate($member = null)

    {
        $extended = $this->extendedCan(__FUNCTION__, $member);
        if ($extended !== null) {
            return $extended;
        }
        if (Permission::checkMember($member, Config::inst()->get("EcommerceRole", "admin_permission_code"))) {
            return true;
        }
        return parent::canCreate($member);
    }

    /**
     * standard SS method
     * @param Member | NULL
     * @return Boolean

     */
    public function canView($member = null)

    {
        $extended = $this->extendedCan(__FUNCTION__, $member);
        if ($extended !== null) {
            return $extended;
        }
        if (Permission::checkMember($member, Config::inst()->get("EcommerceRole", "admin_permission_code"))) {
            return true;
        }
        return parent::canCreate($member);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * standard SS method
     * @param Member | NULL
     * @return Boolean

     */
    public function canEdit($member = null)

    {
        $extended = $this->extendedCan(__FUNCTION__, $member);
        if ($extended !== null) {
            return $extended;
        }
        if (Permission::checkMember($member, Config::inst()->get("EcommerceRole", "admin_permission_code"))) {
            return true;
        }
        return parent::canEdit($member);
    }

    /**
     * standard SS method
     * @param Member | NULL
     * @return Boolean

     */
    public function canDelete($member = null)

    {
        $extended = $this->extendedCan(__FUNCTION__, $member);
        if ($extended !== null) {
            return $extended;
        }
        if (Permission::checkMember($member, Config::inst()->get("EcommerceRole", "admin_permission_code"))) {
            return true;
        }
        return parent::canDelete($member);
    }

    /**
     * standard SS method
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fieldLabels = $this->Config()->get("field_labels");
        $fields->replaceField("CountryCode", new DropDownField("CountryCode", $fieldLabels["CountryCode"], EcommerceCountry::get_country_dropdown()));
        $InclusiveOrExclusive = "Inclusive";
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if ($this->EcomConfig()->ShopPricesAreTaxExclusive) {
            $InclusiveOrExclusive = "Exclusive";
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }
        $fields->replaceField("InclusiveOrExclusive", new ReadonlyField("InclusiveOrExclusive", "This tax is: ..., you can change this setting in the e-commerce configuration."));
        return $fields;
    }

    public function Title()
    {
        return $this->getTitle();
    }
    public function getTitle()
    {
        if ($this->AppliesToAllCountries) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $country = _t("GSTTExModifierOption.WORLDWIDE", "world-wide");
        } else {
            $country = $this->CountryCode;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        return $this->Name." ($country, ".number_format($this->Rate * 100, 2) . '%)';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * standard SS method
     */
    public function populateDefaults()
    {
        parent::populateDefaults();
        //can only run after first dev/build
        if (Security::database_is_ready()) {
            $controller = Controller::curr();
            if ($controller instanceof DatabaseAdmin) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                //cant do this now.
            } else {
                if ($this->EcomConfig()->ShopPricesAreTaxExclusive) {
                    $this->InclusiveOrExclusive = "Exclusive";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                } else {
                    $this->InclusiveOrExclusive = "Inclusive";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                }
            }
        }
    }

    /**
     * standard SS method
     */
    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        if ($this->EcomConfig()->ShopPricesAreTaxExclusive) {
            $this->InclusiveOrExclusive = "Exclusive";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } else {
            $this->InclusiveOrExclusive = "Inclusive";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }

    // /**
    //  * standard SS method
    //  */
    // public function requireDefaultRecords()

    // {
    //     parent::requireDefaultRecords();

    //     DB::query("
    //         UPDATE \"GSTTaxModifierOptions\"
    //         SET \"InclusiveOrExclusive\" = 'Inclusive'
    //         WHERE \"InclusiveOrExclusive\" <> 'Exclusive'"
    //     );
    // }

    /**
     * returns the instance of EcommerceDBConfig
     *
     * @return EcommerceDBConfig
     **/
    public function EcomConfig()
    {
        return EcommerceDBConfig::current_ecommerce_db_config();
    }

    public function CountryName()
    {
        return $this->getCountryName();
    }
    public function getCountryName()
    {
        return EcommerceCountry::find_title($this->CountryCode);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function PercentageNice()
    {
        return $this->getPercentageNice();
    }
    public function getPercentageNice()
    {
        return DBField::create_field("Text", ($this->Rate * 100)."%");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php
2
3			/**
4			*@author nicolaas [at] sunnysideup.co.nz
5			*
6			**/
7
8			class GSTTaxModifierOptions extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9			{
10
11			/**
12			* standard SS variable
13			* @var Array
14			*/
15			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
16			"CountryCode" => "Varchar(3)",
17			"Code" => "Varchar(12)",
18			"Name" => "Varchar(175)",
19			"LegalNotice" => "Varchar(255)",
20			"InclusiveOrExclusive" => "Enum('Inclusive,Exclusive', 'Inclusive')",
21			"Rate" => "Double",
22			"DoesNotApplyToAllProducts" => "Boolean",
23			"AppliesToAllCountries" => "Boolean"
24			);
25
26			/**
27			* standard SS variable
28			* @var Array
29			*/
30			private static $defaults = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report The property `$defaults` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
31			"InclusiveOrExclusive" => "Inclusive"
32			);
33
34			/**
35			* standard SS variable
36			* @var Array
37			*/

sunnysideup / silverstripe-ecommerce_tax

Push — master ( ac5f0e...2f6691 )

GSTTaxModifierOptions A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

16 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like