GSTTaxDecorator

Complexity

Total Complexity

14

Size/Duplication

Total Lines	131
Duplicated Lines	13.74 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	BuyableCalculatedExcludedFrom()	9	9	3
A	BuyableCalculatedAdditionalTax()	9	9	3
B	updateCMSFields()	0	64	6
A	TaxInclusivePrice()	0	4	1
A	TaxExclusivePrice()	0	4	1

<?php


/**
 * @author Nicolaas [at] sunnysideup.co.nz
 * @package: ecommerce
 * @sub-package: ecommerce_tax
 * @description: special tax rules for individual buyables
 *
 *
 */


class GSTTaxDecorator extends DataExtension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     * standard SS method
     * @return Array
     */
    private static $many_many = array(

The property $many_many is not used and could be removed.

        "ExcludedFrom" => "GSTTaxModifierOptions",
        "AdditionalTax" => "GSTTaxModifierOptions"
    );

    /**
     * for variations, use product for data
     * @return DataList
     */
    public function BuyableCalculatedExcludedFrom()

This method seems to be duplicated in your project.

    {
        if ($this->owner instanceof ProductVariation) {

The class ProductVariation does not exist. Did you forget a USE statement, or did you not list all dependencies?

            if ($product = $this->owner->Product()) {
                return $product->ExcludedFrom();
            }
        }
        return $this->owner->ExcludedFrom();
    }

    /**
     * for variations, use product for data
     * @return DataList
     */
    public function BuyableCalculatedAdditionalTax()

This method seems to be duplicated in your project.

    {
        if ($this->owner instanceof ProductVariation) {

The class ProductVariation does not exist. Did you forget a USE statement, or did you not list all dependencies?

            if ($product = $this->owner->Product()) {
                return $product->AdditionalTax();
            }
        }
        return $this->owner->AdditionalTax();
    }


    /**
     * standard SS method
     * @param Object - $fields (FieldList)
     * @return Object - FieldList

Should the return type not be object|null?

     */
    public function updateCMSFields(FieldList $fields)
    {
        $additionalWhereForDefault = "";
        $fields->removeByName("ExcludedFrom");
        $fields->removeByName("AdditionalTax");
        $tabName = "Root.Tax";
        if ($this->owner instanceof ProductVariation) {

The class ProductVariation does not exist. Did you forget a USE statement, or did you not list all dependencies?

            $fields->addFieldToTab(
                $tabName,
                new LiteralField(
                    "SeeProductForAdditionalTax",
                    _t("GSTTaxModifier.SEE_PARENT", "See parent Product for Additional Tax")
                )
            );
        } else {
            //additional taxes
            $additionalOptions = GSTTaxModifierOptions::get()->filter(array("DoesNotApplyToAllProducts" => 1));
            if ($additionalOptions->count()) {
                $additionalOptionsList = $additionalOptions->map()->toArray();
                $fields->addFieldToTab(
                    $tabName,
                    new CheckboxSetField(
                        "AdditionalTax",
                        _t("GSTTaxMofidifier.ADDITIONAL_TAXES", "Additional taxes ..."),
                        $additionalOptionsList
                    )
                );
            }
        }
        if ($this->owner instanceof ProductVariation) {

The class ProductVariation does not exist. Did you forget a USE statement, or did you not list all dependencies?

            $fields->addFieldToTab(
                $tabName,
                new LiteralField(
                    "SeeProductForExcludedFrom",
                    _t("GSTTaxModifier.SEE_PARRENT", "See parent product for excluded taxes")
                )
            );
        } else {
            //excluded options
            $excludedOptions = GSTTaxModifierOptions::get()->filter(array("DoesNotApplyToAllProducts" => 0));
            if ($excludedOptions->count()) {
                $excludedOptionsList = $excludedOptions->map()->toArray();
                $fields->addFieldToTab(
                    $tabName,
                    new CheckboxSetField(
                        "ExcludedFrom",
                        _t("GSTTaxMofidifier.EXCLUDE_TAXES", "Taxes that do not apply ..."),
                        $excludedOptionsList
                    )
                );
                $additionalWhereForDefault = " \"GSTTaxModifierOptions\".\"ID\" NOT IN (".implode(", ", $excludedOptions->map("ID", "ID")->toArray()).")";
            }
        }
        //default options
        $defaultOptions = GSTTaxModifierOptions::get()
            ->filter(array("DoesNotApplyToAllProducts" => 0))
            ->where($additionalWhereForDefault);
        if ($defaultOptions->count()) {
            $fields->addFieldToTab(
                $tabName,
                new ReadonlyField("AlwaysApplies", "+ ".implode(", ", $defaultOptions->map()->toArray()).".")
            );
        }
    }

    /**
     * returns the calculated price for the buyable including tax
     * @return float

Should the return type not be double|null?

     *
     */
    public function TaxInclusivePrice()
    {
        user_error("to be completed");
    }

    /**
     * returns the calculated price for the buyable excluding tax
     * @return float

Should the return type not be double|null?

     *
     */
    public function TaxExclusivePrice()
    {
        user_error("to be completed");
    }
}