Issues in StockControlPing.php (master) - Issues in master - sunnysideup/silverstripe-ecommerce_stockcontrol - Measure and Improve Code Quality continuously with Scrutinizer

Issues (201)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/model/StockControlPing.php (12 issues)

Labels

Severity

Minor 12

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * connection with external stock setting systems
 * as an orderstep
 *
 *
 */


class StockControlPing_OrderStep extends OrderStep
{
    private static $db = array(

        "URLToPing" => "Varchar(200)",
        "Username" => "Varchar(30)",
        "Password" => "Varchar(30)"
    );

    private static $defaults = array(

        "CustomerCanEdit" => 0,
        "CustomerCanPay" => 0,
        "CustomerCanCancel" => 0,
        "Name" => "StockControlPing",
        "Code" => "STOCKCONTROLPING",
        "Sort" => 23,
        "ShowAsInProcessOrder" => 1
    );

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->addFieldToTab("Root.Main", new HeaderField("HowToSaveSubmittedOrder", _t("OrderStep.STOCKCONTROLPING", "Please enter details below"), 3), "URLToPing");
        return $fields;
    }

    /**
     * Can run this step once any items have been submitted.
     * @param DataObject - $order Order
     * @return Boolean
     **/
    public function initStep(Order $order)
    {
        return true;
    }

    /**
     * Add a member to the order - in case he / she is not a shop admin.
     * @param DataObject - $order Order
     * @return Boolean
     **/
    public function doStep(Order $order)
    {
        $stockControlPing = StockControlPing_OrderStatusLog::get()
            ->filter(array('OrderID' => $order->ID))->First();
        if (!$stockControlPing) {
            if ($this->Username && $this->Password) {
                $authentication = array(
                    CURLOPT_USERPWD =>
                    $this->Username.":".$this->Password
                );
            } else {
                $authentication = array();
            }
            $outcome = $this->curlGet(
                $this->URLToPing,
                array(
                    "id" => $order->ID,
                    "link" => urlencode($order->APILink())
                ),
                $authentication
            );
            //create record
            $obj = new StockControlPing_OrderStatusLog();
            $obj->OrderID = $order->ID;
            $obj->Note = $outcome;
            $obj->write();
        }
        return true;
    }

    /**
     * go to next step if order has been submitted.
     *@param DataObject - $order Order
     *@return DataObject | Null	(next step OrderStep)
     **/
    public function nextStep(Order $order)
    {
        if ($order->IsSubmitted()) {
            return parent::nextStep($order);
        }
        return null;
    }

    /**
     *
     * @return Boolean
     */
    protected function hasCustomerMessage()
    {
        return false;
    }

    /**
     * Explains the current order step.
     * @return String
     */
    protected function myDescription()
    {
        return _t("OrderStep.STOCKCONTROLPING_DESCRIPTION", "Sends a 'ping' to a third-party stock control system.");
    }


    /**
     * Send a GET requst using cURL
     * @source php.net
     * @param string $url to request
     * @param array $get values to send
     * @param array $options for cURL
     * @return string
     */
    protected function curlGet($url, array $get = null, array $options = array())
    {
        $defaults = array(
            CURLOPT_URL => $url. (strpos($url, '?') === false ? '?' : ''). http_build_query($get),
            CURLOPT_HEADER => 0,
            CURLOPT_RETURNTRANSFER => true,
            CURLOPT_TIMEOUT => 4
        );
        $ch = curl_init();
        curl_setopt_array($ch, ($options + $defaults));
        if (! $result = curl_exec($ch)) {
            return curl_error($ch);
        }
        curl_close($ch);
        return $result;
    }
}


class StockControlPing_OrderStatusLog extends OrderStatusLog
{
    private static $singular_name = "Stock Control External Ping";

    public function i18n_singular_name()
    {
        return _t("OrderStatusLog.STOCKCONTROLEXTERNALPING", "Stock Control External Ping");
    }

    private static $plural_name = "Stock Control External Pings";

    public function i18n_plural_name()
    {
        return _t("OrderStatusLog.STOCKCONTROLEXTERNALPINGS", "Stock Control External Pings");
    }

    private static $defaults = array(

        'Title' => 'Ping External Service',
        'Note' => 'HTMLText',
        'InternalUseOnly' => 1
    );
}

/**
 *
 *
 *
 *
 *
 *	Example of POST:
 * 	function TestPost() {
 *
 *		$baseURL = Director::absoluteBaseURL();
 *
 *		// 1) My Personal Data
 *
 *		$className = 'StockControlPing_IncomingUpdate';
 *		$fields = array(
 *			'AllowPurchase' => 0,
 *			'InternalItemID' => "xxxx",
 * 			//below are optional (if you include ID then you leave out InternalItemID)k6
 *
 * 			//'BuyableClassName' => 'Product',
 * 			//'BuyableID' => 123,
 *		);
 *
 *		// 2) The Query
 *
 *		$url = "{$baseURL}/api/ecommerce/v1/{$className}.xml";
 *		$body = $fields;
 *		$c = curl_init($url);
 *		curl_setopt($c, CURLOPT_POST, true);
 *		curl_setopt($c, CURLOPT_POSTFIELDS, $body);
 *		curl_setopt($c, CURLOPT_RETURNTRANSFER, true);
 *		$page = curl_exec($c);
 *		curl_close($c);
 *
 *		// 3) The XML Result
 *		return $page;
 *	}
 *
 *
 */
class StockControlPing_IncomingUpdate extends DataObject
{
    private static $api_access = array(

        'create' => array('InternalItemID', 'BuyableClassName', 'BuyableID', 'AllowPurchase'),
        'add' => array('InternalItemID', 'BuyableClassName', 'BuyableID', 'AllowPurchase'),
        'view' => array('InternalItemID', 'BuyableClassName', 'BuyableID', 'AllowPurchase')
    );

    private static $db = array(

        "InternalItemID" => "Varchar(30)",
        "BuyableClassName" => "Varchar(50)",
        "BuyableID" => "Int",
        "AllowPurchase" => "Boolean",
        "Actioned" => "Boolean"
    );

    private static $indexes = [

        'LastEdited' => true
    ];

    private static $default_sort = [

        'LastEdited' => 'DESC',
        'ID' => 'DESC'
    ];

    private static $singular_name = "External Update to Product Availability";

    public function i18n_singular_name()
    {
        return _t("StockControlPing.EXTERNALUPDATETOPRODUCTAVAILABILITY", "External Update to Product Availability");
    }

    private static $plural_name = "External Updates to Product Availability";

    public function i18n_plural_name()
    {
        return _t("StockControlPing.EXTERNALUPDATESTOPRODUCTAVAILABILITY", "External Updates to Product Availability");
    }

    public function canView($member = null)
    {
        return $this->canDoAnything($member);
    }

    public function canCreate($member = null)
    {
        return $this->canDoAnything($member);
    }

    public function canEdit($member = null)
    {
        return false;
    }

    public function canDelete($member = null)
    {
        return false;
    }

    protected function canDoAnything($member = null)

    {
        $shopAdminCode = EcommerceConfig::get("EcommerceRole", "admin_permission_code");
        if (!Permission::check("ADMIN") && !Permission::check($shopAdminCode)) {
            Security::permissionFailure($this, _t('Security.PERMFAILURE', ' This page is secured and you need administrator rights to access it. Enter your credentials below and we will send you right along.'));
        }
        return true;
    }


    public function onAfterWrite()
    {
        parent::onAfterWrite();
        //TODO: move to findBuyable in Core Ecommerce Code!
        if (!$this->Actioned) {
            $internalItemID = Convert::raw2sql($this->InternalItemID);
            $id = intval($this->ID);
            $className = Convert::raw2sql($this->BuyableClassName);
            $allowPurchase = $this->AllowPurchase ? 1 : 0;
            if ($className) {
                if ($className && $id) {
                    $buyable = $className::get()->byID($id);
                } else {
                    $buyable = $className::get()->filter(array('InternalItemID' => $internalItemID))->First();
                }
            } else {
                $buyablesArray = EcommerceConfig::get($className = "EcommerceDBConfig", $identifier = "array_of_buyables");
                if (is_array($buyablesArray)) {
                    if (count($buyablesArray)) {
                        foreach ($buyablesArray as $className) {
                            $buyable = $className::get()->filter(array('InternalItemID' => $internalItemID))->First();
                            if ($buyable) {
                                break;
                            }
                        }
                    }
                }
            }
            if ($buyable) {
                if ($buyable->AllowPurchase =! $allowPurchase) {
                    $buyable->AllowPurchase = $allowPurchase;
                    if ($buyable instanceof SiteTree) {
                        $buyable->writeToStage('Stage');
                        $buyable->publish('Stage', 'Live');
                    } else {
                        $buyable->write();
                    }
                }
                $this->BuyableClassName = $buyable->ClassName;
                $this->BuyableID = $buyable->ID;
            }
            $this->Actioned = 1;
            $this->write();
        }
    }
}


1		<?php
2
3		/**
4		* connection with external stock setting systems
5		* as an orderstep
6		*
7		*
8		*/
9
10
11		class StockControlPing_OrderStep extends OrderStep
12		{
13		private static $db = array(
		0 ignored issues – show Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
14		"URLToPing" => "Varchar(200)",
15		"Username" => "Varchar(30)",
16		"Password" => "Varchar(30)"
17		);
18
19		private static $defaults = array(
		0 ignored issues – show Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$defaults` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
20		"CustomerCanEdit" => 0,
21		"CustomerCanPay" => 0,
22		"CustomerCanCancel" => 0,
23		"Name" => "StockControlPing",
24		"Code" => "STOCKCONTROLPING",
25		"Sort" => 23,
26		"ShowAsInProcessOrder" => 1
27		);
28
29		public function getCMSFields()
30		{
31		$fields = parent::getCMSFields();
32		$fields->addFieldToTab("Root.Main", new HeaderField("HowToSaveSubmittedOrder", _t("OrderStep.STOCKCONTROLPING", "Please enter details below"), 3), "URLToPing");
33		return $fields;
34		}
35
36		/**
37		* Can run this step once any items have been submitted.
38		* @param DataObject - $order Order
39		* @return Boolean
40		**/
41		public function initStep(Order $order)
42		{
43		return true;
44		}
45
46		/**
47		* Add a member to the order - in case he / she is not a shop admin.
48		* @param DataObject - $order Order
49		* @return Boolean
50		**/
51		public function doStep(Order $order)
52		{
53		$stockControlPing = StockControlPing_OrderStatusLog::get()
54		->filter(array('OrderID' => $order->ID))->First();
55		if (!$stockControlPing) {
56		if ($this->Username && $this->Password) {
57		$authentication = array(
58		CURLOPT_USERPWD =>
59		$this->Username.":".$this->Password
60		);
61		} else {
62		$authentication = array();
63		}
64		$outcome = $this->curlGet(
65		$this->URLToPing,
66		array(
67		"id" => $order->ID,
68		"link" => urlencode($order->APILink())
69		),
70		$authentication
71		);
72		//create record
73		$obj = new StockControlPing_OrderStatusLog();
74		$obj->OrderID = $order->ID;
75		$obj->Note = $outcome;
76		$obj->write();
77		}
78		return true;
79		}
80
81		/**
82		* go to next step if order has been submitted.
83		*@param DataObject - $order Order
84		*@return DataObject \| Null (next step OrderStep)
85		**/
86		public function nextStep(Order $order)
87		{
88		if ($order->IsSubmitted()) {
89		return parent::nextStep($order);
90		}
91		return null;
92		}
93
94		/**
95		*
96		* @return Boolean
97		*/
98		protected function hasCustomerMessage()
99		{
100		return false;
101		}
102
103		/**
104		* Explains the current order step.
105		* @return String
106		*/
107		protected function myDescription()
108		{
109		return _t("OrderStep.STOCKCONTROLPING_DESCRIPTION", "Sends a 'ping' to a third-party stock control system.");
110		}
111
112
113		/**
114		* Send a GET requst using cURL
115		* @source php.net
116		* @param string $url to request
117		* @param array $get values to send
118		* @param array $options for cURL
119		* @return string
120		*/
121		protected function curlGet($url, array $get = null, array $options = array())
122		{
123		$defaults = array(
124		CURLOPT_URL => $url. (strpos($url, '?') === false ? '?' : ''). http_build_query($get),
125		CURLOPT_HEADER => 0,
126		CURLOPT_RETURNTRANSFER => true,
127		CURLOPT_TIMEOUT => 4
128		);
129		$ch = curl_init();
130		curl_setopt_array($ch, ($options + $defaults));
131		if (! $result = curl_exec($ch)) {
132		return curl_error($ch);
133		}
134		curl_close($ch);
135		return $result;
136		}
137		}
138
139
140		class StockControlPing_OrderStatusLog extends OrderStatusLog
141		{
142		private static $singular_name = "Stock Control External Ping";
		0 ignored issues – show Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$singular_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
143		public function i18n_singular_name()
144		{
145		return _t("OrderStatusLog.STOCKCONTROLEXTERNALPING", "Stock Control External Ping");
146		}
147
148		private static $plural_name = "Stock Control External Pings";
		0 ignored issues – show Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$plural_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
149		public function i18n_plural_name()
150		{
151		return _t("OrderStatusLog.STOCKCONTROLEXTERNALPINGS", "Stock Control External Pings");
152		}
153
154		private static $defaults = array(
		0 ignored issues – show Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$defaults` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
155		'Title' => 'Ping External Service',
156		'Note' => 'HTMLText',
157		'InternalUseOnly' => 1
158		);
159		}
160
161		/**
162		*
163		*
164		*
165		*
166		*
167		* Example of POST:
168		* function TestPost() {
169		*
170		* $baseURL = Director::absoluteBaseURL();
171		*
172		* // 1) My Personal Data
173		*
174		* $className = 'StockControlPing_IncomingUpdate';
175		* $fields = array(
176		* 'AllowPurchase' => 0,
177		* 'InternalItemID' => "xxxx",
178		* //below are optional (if you include ID then you leave out InternalItemID)k6
179		*
180		* //'BuyableClassName' => 'Product',
181		* //'BuyableID' => 123,
182		* );
183		*
184		* // 2) The Query
185		*
186		* $url = "{$baseURL}/api/ecommerce/v1/{$className}.xml";
187		* $body = $fields;
188		* $c = curl_init($url);
189		* curl_setopt($c, CURLOPT_POST, true);
190		* curl_setopt($c, CURLOPT_POSTFIELDS, $body);
191		* curl_setopt($c, CURLOPT_RETURNTRANSFER, true);
192		* $page = curl_exec($c);
193		* curl_close($c);
194		*
195		* // 3) The XML Result
196		* return $page;
197		* }
198		*
199		*
200		*/
201		class StockControlPing_IncomingUpdate extends DataObject
202		{
203		private static $api_access = array(
		0 ignored issues – show Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$api_access` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
204		'create' => array('InternalItemID', 'BuyableClassName', 'BuyableID', 'AllowPurchase'),
205		'add' => array('InternalItemID', 'BuyableClassName', 'BuyableID', 'AllowPurchase'),
206		'view' => array('InternalItemID', 'BuyableClassName', 'BuyableID', 'AllowPurchase')
207		);
208
209		private static $db = array(
		0 ignored issues – show Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
210		"InternalItemID" => "Varchar(30)",
211		"BuyableClassName" => "Varchar(50)",
212		"BuyableID" => "Int",
213		"AllowPurchase" => "Boolean",
214		"Actioned" => "Boolean"
215		);
216
217		private static $indexes = [
		0 ignored issues – show Unused Code introduced 2017-08-15 05:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$indexes` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
218		'LastEdited' => true
219		];
220
221		private static $default_sort = [
		0 ignored issues – show Unused Code introduced 2017-08-15 05:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$default_sort` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
222		'LastEdited' => 'DESC',
223		'ID' => 'DESC'
224		];
225
226		private static $singular_name = "External Update to Product Availability";
		0 ignored issues – show Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$singular_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
227		public function i18n_singular_name()
228		{
229		return _t("StockControlPing.EXTERNALUPDATETOPRODUCTAVAILABILITY", "External Update to Product Availability");
230		}
231
232		private static $plural_name = "External Updates to Product Availability";
		0 ignored issues – show Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$plural_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
233		public function i18n_plural_name()
234		{
235		return _t("StockControlPing.EXTERNALUPDATESTOPRODUCTAVAILABILITY", "External Updates to Product Availability");
236		}
237
238		public function canView($member = null)
239		{
240		return $this->canDoAnything($member);
241		}
242
243		public function canCreate($member = null)
244		{
245		return $this->canDoAnything($member);
246		}
247
248		public function canEdit($member = null)
249		{
250		return false;
251		}
252
253		public function canDelete($member = null)
254		{
255		return false;
256		}
257
258	View Code Duplication	protected function canDoAnything($member = null)
		0 ignored issues – show Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$member` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
259		{
260		$shopAdminCode = EcommerceConfig::get("EcommerceRole", "admin_permission_code");
261		if (!Permission::check("ADMIN") && !Permission::check($shopAdminCode)) {
262		Security::permissionFailure($this, _t('Security.PERMFAILURE', ' This page is secured and you need administrator rights to access it. Enter your credentials below and we will send you right along.'));
263		}
264		return true;
265		}
266
267
268		public function onAfterWrite()
269		{
270		parent::onAfterWrite();
271		//TODO: move to findBuyable in Core Ecommerce Code!
272		if (!$this->Actioned) {
273		$internalItemID = Convert::raw2sql($this->InternalItemID);
274		$id = intval($this->ID);
275		$className = Convert::raw2sql($this->BuyableClassName);
276		$allowPurchase = $this->AllowPurchase ? 1 : 0;
277		if ($className) {
278		if ($className && $id) {
279		$buyable = $className::get()->byID($id);
280		} else {
281		$buyable = $className::get()->filter(array('InternalItemID' => $internalItemID))->First();
282		}
283		} else {
284		$buyablesArray = EcommerceConfig::get($className = "EcommerceDBConfig", $identifier = "array_of_buyables");
285		if (is_array($buyablesArray)) {
286		if (count($buyablesArray)) {
287		foreach ($buyablesArray as $className) {
288		$buyable = $className::get()->filter(array('InternalItemID' => $internalItemID))->First();
289		if ($buyable) {
290		break;
291		}
292		}
293		}
294		}
295		}
296		if ($buyable) {
297		if ($buyable->AllowPurchase =! $allowPurchase) {
298		$buyable->AllowPurchase = $allowPurchase;
299		if ($buyable instanceof SiteTree) {
300		$buyable->writeToStage('Stage');
301		$buyable->publish('Stage', 'Live');
302		} else {
303		$buyable->write();
304		}
305		}
306		$this->BuyableClassName = $buyable->ClassName;
307		$this->BuyableID = $buyable->ID;
308		}
309		$this->Actioned = 1;
310		$this->write();
311		}
312		}
313		}
314

sunnysideup / silverstripe-ecommerce_stockcontrol

Issues (201)

Security Analysis not enabled

code/model/StockControlPing.php (12 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like